From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] clk: mmp: add clock definition for pxa168
Date: Tue, 31 Jul 2012 11:54:42 +0000 [thread overview]
Message-ID: <201207311154.42866.arnd@arndb.de> (raw)
In-Reply-To: <1343716792-10399-2-git-send-email-xiechao.mail@gmail.com>
On Tuesday 31 July 2012, Chao Xie wrote:
> +#define APBC_RTC APBC_REG(0x28)
> +#define APBC_TWSI0 APBC_REG(0x2c)
> +#define APBC_KPC APBC_REG(0x30)
> +#define APBC_UART0 APBC_REG(0x00)
> +#define APBC_UART1 APBC_REG(0x04)
> +#define APBC_GPIO APBC_REG(0x08)
> +#define APBC_PWM0 APBC_REG(0x0c)
> +#define APBC_PWM1 APBC_REG(0x10)
> +#define APBC_PWM2 APBC_REG(0x14)
> +#define APBC_PWM3 APBC_REG(0x18)
> +#define APBC_SSP0 APBC_REG(0x81c)
> +#define APBC_SSP1 APBC_REG(0x820)
> +#define APBC_SSP2 APBC_REG(0x84c)
> +#define APBC_SSP3 APBC_REG(0x858)
> +#define APBC_SSP4 APBC_REG(0x85c)
> +#define APBC_TWSI1 APBC_REG(0x6c)
> +#define APBC_UART2 APBC_REG(0x70)
> +
> +#define APMU_SDH0 APMU_REG(0x54)
> +#define APMU_SDH1 APMU_REG(0x58)
> +#define APMU_USB APMU_REG(0x5c)
> +#define APMU_DISP0 APMU_REG(0x4c)
> +#define APMU_CCIC0 APMU_REG(0x50)
> +#define APMU_DFC APMU_REG(0x60)
Same comment as for patch 1: get the address from the device tree and just
define those macros to the offset, like:
#define APBC_RTC 0x28
apbc_clks[rtc_clk] = mmp_clk_register_apbc(rtc_clk, clk32k, APBC_RTC, 10, APBC_POWER_CTRL, mmp_clk_lock);
clk_register_clkdev(apbc_clks[rtc_clk], NULL, "sa1100-rtc");
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Chao Xie <xiechao.mail@gmail.com>
Cc: haojian.zhuang@gmail.com, mturquette@linaro.org,
viresh.linux@gmail.com, s.hauer@pengutronix.de,
chao.xie@marvell.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] clk: mmp: add clock definition for pxa168
Date: Tue, 31 Jul 2012 11:54:42 +0000 [thread overview]
Message-ID: <201207311154.42866.arnd@arndb.de> (raw)
In-Reply-To: <1343716792-10399-2-git-send-email-xiechao.mail@gmail.com>
On Tuesday 31 July 2012, Chao Xie wrote:
> +#define APBC_RTC APBC_REG(0x28)
> +#define APBC_TWSI0 APBC_REG(0x2c)
> +#define APBC_KPC APBC_REG(0x30)
> +#define APBC_UART0 APBC_REG(0x00)
> +#define APBC_UART1 APBC_REG(0x04)
> +#define APBC_GPIO APBC_REG(0x08)
> +#define APBC_PWM0 APBC_REG(0x0c)
> +#define APBC_PWM1 APBC_REG(0x10)
> +#define APBC_PWM2 APBC_REG(0x14)
> +#define APBC_PWM3 APBC_REG(0x18)
> +#define APBC_SSP0 APBC_REG(0x81c)
> +#define APBC_SSP1 APBC_REG(0x820)
> +#define APBC_SSP2 APBC_REG(0x84c)
> +#define APBC_SSP3 APBC_REG(0x858)
> +#define APBC_SSP4 APBC_REG(0x85c)
> +#define APBC_TWSI1 APBC_REG(0x6c)
> +#define APBC_UART2 APBC_REG(0x70)
> +
> +#define APMU_SDH0 APMU_REG(0x54)
> +#define APMU_SDH1 APMU_REG(0x58)
> +#define APMU_USB APMU_REG(0x5c)
> +#define APMU_DISP0 APMU_REG(0x4c)
> +#define APMU_CCIC0 APMU_REG(0x50)
> +#define APMU_DFC APMU_REG(0x60)
Same comment as for patch 1: get the address from the device tree and just
define those macros to the offset, like:
#define APBC_RTC 0x28
apbc_clks[rtc_clk] = mmp_clk_register_apbc(rtc_clk, clk32k, APBC_RTC, 10, APBC_POWER_CTRL, mmp_clk_lock);
clk_register_clkdev(apbc_clks[rtc_clk], NULL, "sa1100-rtc");
Arnd
next prev parent reply other threads:[~2012-07-31 11:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 6:39 [PATCH 1/5] clk: mmp: add mmp specific clocks Chao Xie
2012-07-31 6:39 ` Chao Xie
2012-07-31 6:39 ` [PATCH 2/5] clk: mmp: add clock definition for pxa168 Chao Xie
2012-07-31 6:39 ` Chao Xie
2012-07-31 11:54 ` Arnd Bergmann [this message]
2012-07-31 11:54 ` Arnd Bergmann
2012-08-02 7:24 ` Chao Xie
2012-08-02 7:24 ` Chao Xie
2012-08-02 10:30 ` Arnd Bergmann
2012-08-02 10:30 ` Arnd Bergmann
2012-07-31 6:39 ` [PATCH 3/5] clk: mmp: add clock definition for pxa910 Chao Xie
2012-07-31 6:39 ` Chao Xie
2012-07-31 6:39 ` [PATCH 4/5] clk: mmp: add clock definition for mmp2 Chao Xie
2012-07-31 6:39 ` Chao Xie
2012-07-31 11:47 ` [PATCH 1/5] clk: mmp: add mmp specific clocks Arnd Bergmann
2012-07-31 11:47 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207311154.42866.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.