All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: "Schumaker, Bryan" <Bryan.Schumaker@netapp.com>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [nfs:devel 46/51] fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode'
Date: Tue, 31 Jul 2012 14:10:07 +0000	[thread overview]
Message-ID: <20120731141007.GA20369@localhost> (raw)
In-Reply-To: <1343743122.519.4.camel@lade.trondhjem.org>

> > Easy enough, the patch that fixes it is the last one in the series that I sent in yesterday.
> 
> I don't understand. That is the patch series that Fengguang was testing
> afaik. His tests were on 
> 
> tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
> head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09
> 
> which includes your patch series from yesterday, no?

Trond, I typically do commit-by-commit tests and will complain if
*any* point of the tree is not bisect-able. A fix at the HEAD won't
stop the email notification for a defect in the middle point..

On the other hand, I do maintain a list of non-rebaseable
tree/branches, on which the HEAD commit will be tested first, and only
if any problems are found, go back to find out the first bad commit.

If you prefer the latter behavior, I can add your tree or any branch
of it to the non-rebaseable list.

Thanks,
Fengguang

WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: "Schumaker, Bryan" <Bryan.Schumaker@netapp.com>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [nfs:devel 46/51] fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode'
Date: Tue, 31 Jul 2012 22:10:07 +0800	[thread overview]
Message-ID: <20120731141007.GA20369@localhost> (raw)
In-Reply-To: <1343743122.519.4.camel@lade.trondhjem.org>

> > Easy enough, the patch that fixes it is the last one in the series that I sent in yesterday.
> 
> I don't understand. That is the patch series that Fengguang was testing
> afaik. His tests were on 
> 
> tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
> head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09
> 
> which includes your patch series from yesterday, no?

Trond, I typically do commit-by-commit tests and will complain if
*any* point of the tree is not bisect-able. A fix at the HEAD won't
stop the email notification for a defect in the middle point..

On the other hand, I do maintain a list of non-rebaseable
tree/branches, on which the HEAD commit will be tested first, and only
if any problems are found, go back to find out the first bad commit.

If you prefer the latter behavior, I can add your tree or any branch
of it to the non-rebaseable list.

Thanks,
Fengguang

  parent reply	other threads:[~2012-07-31 14:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31  2:43 [nfs:devel 46/51] fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode' Fengguang Wu
2012-07-31  2:43 ` Fengguang Wu
2012-07-31  3:14 ` Myklebust, Trond
2012-07-31 12:47   ` Bryan Schumaker
2012-07-31 12:47     ` Bryan Schumaker
2012-07-31 12:55     ` Myklebust, Trond
2012-07-31 12:55       ` Myklebust, Trond
2012-07-31 13:05       ` Bryan Schumaker
2012-07-31 13:05         ` Bryan Schumaker
2012-07-31 13:30         ` Bryan Schumaker
2012-07-31 13:30           ` Bryan Schumaker
2012-07-31 13:33           ` Myklebust, Trond
2012-07-31 13:33             ` Myklebust, Trond
2012-07-31 13:44             ` Bryan Schumaker
2012-07-31 13:44               ` Bryan Schumaker
2012-07-31 13:51               ` Fengguang Wu
2012-07-31 13:51                 ` Fengguang Wu
2012-07-31 13:55                 ` Bryan Schumaker
2012-07-31 13:55                   ` Bryan Schumaker
2012-07-31 14:16                   ` Fengguang Wu
2012-07-31 14:16                     ` Fengguang Wu
2012-07-31 14:18                     ` Bryan Schumaker
2012-07-31 14:18                       ` Bryan Schumaker
2012-07-31 13:58               ` Myklebust, Trond
2012-07-31 13:58                 ` Myklebust, Trond
2012-07-31 14:08                 ` Bryan Schumaker
2012-07-31 14:08                   ` Bryan Schumaker
2012-07-31 14:10                 ` Fengguang Wu [this message]
2012-07-31 14:10                   ` Fengguang Wu
2012-07-31 14:28                   ` Myklebust, Trond
2012-07-31 14:36                     ` Fengguang Wu
2012-07-31 14:36                       ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120731141007.GA20369@localhost \
    --to=fengguang.wu@intel.com \
    --cc=Bryan.Schumaker@netapp.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.