From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] mv643xx.c: Add basic device tree support.
Date: Tue, 31 Jul 2012 20:18:32 +0000 [thread overview]
Message-ID: <201207312018.33432.arnd@arndb.de> (raw)
In-Reply-To: <20120731192458.GE28852@lunn.ch>
On Tuesday 31 July 2012, Andrew Lunn wrote:
> This pattern is used in other places, e.g. when creating the
> clocks. The macro MV643XX_ETH_NAME is also used when creating the
> platform data, and in the driver itself.
>
> Are you suggested we replace this with "mv643xx_eth.0"? Or is adding
> the macro
>
> #define MV643XX_ETH_NAME0 "mv643xx_eth.0"
>
> in include/linux/mv643xx_eth.h O.K, since grep will find it, and
> induce the grep'er to perform a second grep on the macro?
I meant the former. Just remove the macro entirely, or at least
don't add new users.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Ian Molton <ian.molton@codethink.co.uk>,
linux-arm-kernel@lists.infradead.org,
thomas.petazzoni@free-electrons.com, ben.dooks@codethink.co.uk,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 3/6] mv643xx.c: Add basic device tree support.
Date: Tue, 31 Jul 2012 20:18:32 +0000 [thread overview]
Message-ID: <201207312018.33432.arnd@arndb.de> (raw)
In-Reply-To: <20120731192458.GE28852@lunn.ch>
On Tuesday 31 July 2012, Andrew Lunn wrote:
> This pattern is used in other places, e.g. when creating the
> clocks. The macro MV643XX_ETH_NAME is also used when creating the
> platform data, and in the driver itself.
>
> Are you suggested we replace this with "mv643xx_eth.0"? Or is adding
> the macro
>
> #define MV643XX_ETH_NAME0 "mv643xx_eth.0"
>
> in include/linux/mv643xx_eth.h O.K, since grep will find it, and
> induce the grep'er to perform a second grep on the macro?
I meant the former. Just remove the macro entirely, or at least
don't add new users.
Arnd
next prev parent reply other threads:[~2012-07-31 20:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 15:45 [PATCH v2 0/6] mv643xx Ethernet DT support and CSB1724 board support Ian Molton
2012-07-31 15:45 ` Ian Molton
2012-07-31 15:45 ` [PATCH v2 1/6] Initial csb1724 board support (FDT) Ian Molton
2012-07-31 15:45 ` Ian Molton
2012-07-31 16:43 ` Andrew Lunn
2012-07-31 16:43 ` Andrew Lunn
2012-07-31 15:45 ` [PATCH v2 2/6] mv643xx.c: Remove magic numbers Ian Molton
2012-07-31 15:45 ` Ian Molton
2012-07-31 15:45 ` [PATCH v2 3/6] mv643xx.c: Add basic device tree support Ian Molton
2012-07-31 15:45 ` Ian Molton
2012-07-31 16:46 ` Andrew Lunn
2012-07-31 16:46 ` Andrew Lunn
2012-08-01 8:50 ` Ian Molton
2012-08-01 8:50 ` Ian Molton
2012-07-31 18:23 ` Arnd Bergmann
2012-07-31 18:23 ` Arnd Bergmann
2012-07-31 19:24 ` Andrew Lunn
2012-07-31 19:24 ` Andrew Lunn
2012-07-31 20:18 ` Arnd Bergmann [this message]
2012-07-31 20:18 ` Arnd Bergmann
2012-07-31 15:45 ` [PATCH v2 4/6] kirkwood: Add a clock setup helper for mv643xx ethernet Ian Molton
2012-07-31 15:45 ` [PATCH v2 5/6] csb1724: Enable device tree based mv643xx ethernet support Ian Molton
2012-07-31 15:45 ` Ian Molton
2012-07-31 15:45 ` [PATCH v2 6/6] DT: Convert all kirkwood boards with mv643xx that use DT Ian Molton
2012-07-31 15:45 ` Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207312018.33432.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.