From: Dong Aisheng <b29396@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>, "lrg@ti.com" <lrg@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [alsa-devel] [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN
Date: Wed, 1 Aug 2012 10:46:33 +0800 [thread overview]
Message-ID: <20120801024630.GA30492@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120728143957.GJ2128@S2101-09.ap.freescale.net>
On Sat, Jul 28, 2012 at 10:39:59PM +0800, Shawn Guo wrote:
> On Fri, Jul 27, 2012 at 07:18:42PM +0800, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng@linaro.org>
> >
> > LINE_IN also needs VAG_POWER on or we may hear noise when directly
> > route LINE_IN to Headphone Mux.
>
> The following is what I see from sgtl5000 data sheet about VAG_POWER.
>
> VAG is the internal voltage reference for the ADC and DAC.
>
> Are you seeing any info that requires VAG_POWER in route of LINE_IN to
> Headphone Mux? Or it's only a result from your testing?
>
No, it's from the test result.
Maybe i should have added a FIXME for this.
> Does it also fix the noise issue you mentioned with normal recording
> (LINE_IN to ADC) before?
>
ADC also needs VAG power which already fixed by:
commit f0cdcf3 (ASoC: sgtl5000: Enable VAG when DAC/ADC up)
This patch is only for direct LINE_IN to Headphone Mux.
Regards
Dong Aisheng
WARNING: multiple messages have this Message-ID (diff)
From: b29396@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN
Date: Wed, 1 Aug 2012 10:46:33 +0800 [thread overview]
Message-ID: <20120801024630.GA30492@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120728143957.GJ2128@S2101-09.ap.freescale.net>
On Sat, Jul 28, 2012 at 10:39:59PM +0800, Shawn Guo wrote:
> On Fri, Jul 27, 2012 at 07:18:42PM +0800, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng@linaro.org>
> >
> > LINE_IN also needs VAG_POWER on or we may hear noise when directly
> > route LINE_IN to Headphone Mux.
>
> The following is what I see from sgtl5000 data sheet about VAG_POWER.
>
> VAG is the internal voltage reference for the ADC and DAC.
>
> Are you seeing any info that requires VAG_POWER in route of LINE_IN to
> Headphone Mux? Or it's only a result from your testing?
>
No, it's from the test result.
Maybe i should have added a FIXME for this.
> Does it also fix the noise issue you mentioned with normal recording
> (LINE_IN to ADC) before?
>
ADC also needs VAG power which already fixed by:
commit f0cdcf3 (ASoC: sgtl5000: Enable VAG when DAC/ADC up)
This patch is only for direct LINE_IN to Headphone Mux.
Regards
Dong Aisheng
next prev parent reply other threads:[~2012-08-01 2:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 11:18 [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN Dong Aisheng
2012-07-27 11:18 ` Dong Aisheng
2012-07-28 14:39 ` Shawn Guo
2012-07-28 14:39 ` [alsa-devel] " Shawn Guo
2012-07-31 15:46 ` Mark Brown
2012-07-31 15:46 ` [alsa-devel] " Mark Brown
2012-08-01 2:46 ` Dong Aisheng [this message]
2012-08-01 2:46 ` Dong Aisheng
2012-07-31 15:40 ` Mark Brown
2012-07-31 15:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801024630.GA30492@shlinux2.ap.freescale.net \
--to=b29396@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@ti.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.