From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: soc-io: Only force use regmap if the codec have it implemented
Date: Wed, 1 Aug 2012 13:40:21 +0100 [thread overview]
Message-ID: <20120801124021.GQ11892@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <50191F0D.6090807@ti.com>
On Wed, Aug 01, 2012 at 03:20:29PM +0300, Peter Ujfalusi wrote:
> On 08/01/2012 03:16 PM, Mark Brown wrote:
> > On Wed, Aug 01, 2012 at 03:01:45PM +0300, Peter Ujfalusi wrote:
> >> case SND_SOC_REGMAP:
> >> /* Device has made its own regmap arrangements */
> >> - codec->using_regmap = true;
> > No, this is crazy.
> Why?
> We set it when we have confirmed that the codec actually have regmap of it's own.
You're changing the function setting up register I/O to ignore what's
being set. This is silly - the soc-io code is doing exactly the right
thing here. Abstraction, folks.
next prev parent reply other threads:[~2012-08-01 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 12:01 [PATCH] ASoC: soc-io: Only force use regmap if the codec have it implemented Peter Ujfalusi
2012-08-01 12:16 ` Mark Brown
2012-08-01 12:20 ` Peter Ujfalusi
2012-08-01 12:40 ` Mark Brown [this message]
2012-08-01 13:09 ` Peter Ujfalusi
2012-08-01 13:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801124021.GQ11892@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.