From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: soc-io: Only force use regmap if the codec have it implemented
Date: Wed, 01 Aug 2012 16:09:30 +0300 [thread overview]
Message-ID: <50192A8A.3080204@ti.com> (raw)
In-Reply-To: <20120801124021.GQ11892@opensource.wolfsonmicro.com>
On 08/01/2012 03:40 PM, Mark Brown wrote:
> You're changing the function setting up register I/O to ignore what's
> being set. This is silly - the soc-io code is doing exactly the right
> thing here.
Well, it overrides the codec->read/write/bulk_write_raw callbacks, sets the
codec->using_regmap to true regardless if the codec have regmap or not.
It should only do all of these if the regmap is there IMHO.
The soc-core calls snd_soc_codec_set_cache_io() if codec->control_data is NULL
at the moment.
Reverting commit
38cbf95 ASoC: core: Try to use regmap if the driver doesn't set up any I/O
would fix the issue as well without changing the soc-io file.
We can as well return if the codec does not have the regmap and
snd_soc_codec_set_cache_io() fails in the SND_SOC_REGMAP case.
--
Péter
next prev parent reply other threads:[~2012-08-01 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 12:01 [PATCH] ASoC: soc-io: Only force use regmap if the codec have it implemented Peter Ujfalusi
2012-08-01 12:16 ` Mark Brown
2012-08-01 12:20 ` Peter Ujfalusi
2012-08-01 12:40 ` Mark Brown
2012-08-01 13:09 ` Peter Ujfalusi [this message]
2012-08-01 13:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50192A8A.3080204@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.