All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	Praveen Paneri <p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org,
	kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
	broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org
Subject: Re: [PATCH 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Date: Wed, 1 Aug 2012 15:20:01 +0000	[thread overview]
Message-ID: <201208011520.02353.arnd@arndb.de> (raw)
In-Reply-To: <1343826351-8756-1-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

On Wednesday 01 August 2012, Praveen Paneri wrote:
> This patch set introduces a phy driver for samsung SoCs. It uses the existing
> transceiver infrastructure to provide phy control functions. Use of this driver
> can be extended for usb host phy as well. Over the period of time all the phy
> related code for most of the samsung SoCs can be integrated here.
> Removing the existing phy code from mach-s3c64xx but not from other machine 
> code.This driver is tested with smdk6410 and Exynos4210(with DT).

This looks very nice overall, great work!

We will still have to take care of the pmu isolation callback in the
long run, when we get to the point of removing all auxdata. Do you
have a plan on how to do that? If yes, it would be good to mention
that in the changelog.

My guess is that the PMU code should be moved into a higher-level
abstraction. I don't know if you would use one of those we already
have or whether you'd introduce a new subsystem for those. Apparently
other platforms have similar issues, so I'd suggest you leave the
callback for now, but we should at some point discuss what to to
about it.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Date: Wed, 1 Aug 2012 15:20:01 +0000	[thread overview]
Message-ID: <201208011520.02353.arnd@arndb.de> (raw)
In-Reply-To: <1343826351-8756-1-git-send-email-p.paneri@samsung.com>

On Wednesday 01 August 2012, Praveen Paneri wrote:
> This patch set introduces a phy driver for samsung SoCs. It uses the existing
> transceiver infrastructure to provide phy control functions. Use of this driver
> can be extended for usb host phy as well. Over the period of time all the phy
> related code for most of the samsung SoCs can be integrated here.
> Removing the existing phy code from mach-s3c64xx but not from other machine 
> code.This driver is tested with smdk6410 and Exynos4210(with DT).

This looks very nice overall, great work!

We will still have to take care of the pmu isolation callback in the
long run, when we get to the point of removing all auxdata. Do you
have a plan on how to do that? If yes, it would be good to mention
that in the changelog.

My guess is that the PMU code should be moved into a higher-level
abstraction. I don't know if you would use one of those we already
have or whether you'd introduce a new subsystem for those. Apparently
other platforms have similar issues, so I'd suggest you leave the
callback for now, but we should at some point discuss what to to
about it.

	Arnd

  parent reply	other threads:[~2012-08-01 15:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-01 13:05 [PATCH 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs Praveen Paneri
2012-08-01 13:05 ` Praveen Paneri
     [not found] ` <1343826351-8756-1-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-08-01 13:05   ` [PATCH 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg Praveen Paneri
2012-08-01 13:05     ` Praveen Paneri
     [not found]     ` <1343826351-8756-2-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-08-05 21:54       ` Heiko Stübner
2012-08-05 21:54         ` Heiko Stübner
     [not found]         ` <201208052354.18978.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2012-08-06  8:20           ` Praveen Paneri
2012-08-06  8:20             ` Praveen Paneri
2012-08-06  8:23             ` Kyungmin Park
2012-08-06  8:23               ` Kyungmin Park
     [not found]               ` <CAH9JG2Wo83_rO6fEazWij9wo=w7atdCqeuqJUmCPJYeYQ4t5dw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-06  9:23                 ` Heiko Stübner
2012-08-06  9:23                   ` Heiko Stübner
2012-08-06  9:51                   ` Praveen Paneri
2012-08-06  9:51                     ` Praveen Paneri
     [not found]                     ` <CAD6zSYPyRGgxVXFhcLSqjOpERq-jLrsqnjYNXM3jKsjymiLaTA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-07  3:57                       ` Praveen Paneri
2012-08-07  3:57                         ` Praveen Paneri
2012-08-07  4:33                         ` Kyungmin Park
2012-08-07  4:33                           ` Kyungmin Park
2012-08-01 13:05   ` [PATCH 2/5] usb: s3c-hsotg: Adding phy driver support Praveen Paneri
2012-08-01 13:05     ` Praveen Paneri
2012-08-01 13:05   ` [PATCH 3/5] ARM: S3C64XX: Removing old phy setup code Praveen Paneri
2012-08-01 13:05     ` Praveen Paneri
2012-08-01 13:05   ` [PATCH 4/5] ARM: S3C64XX: Enabling sec_usbphy driver Praveen Paneri
2012-08-01 13:05     ` Praveen Paneri
2012-08-01 13:05   ` [PATCH 5/5] ARM: Exynos4210: " Praveen Paneri
2012-08-01 13:05     ` Praveen Paneri
2012-08-01 15:20   ` Arnd Bergmann [this message]
2012-08-01 15:20     ` [PATCH 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs Arnd Bergmann
2012-08-02  5:44     ` Praveen Paneri
2012-08-02  5:44       ` Praveen Paneri
2012-08-02 11:26       ` Arnd Bergmann
2012-08-02 11:26         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208011520.02353.arnd@arndb.de \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.