From: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
To: Thierry Reding
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] iommu: Include linux/notifier.h
Date: Fri, 3 Aug 2012 16:08:26 +0200 [thread overview]
Message-ID: <20120803140826.GF1996@amd.com> (raw)
In-Reply-To: <1343226290-32511-2-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
On Wed, Jul 25, 2012 at 04:24:50PM +0200, Thierry Reding wrote:
> The linux/iommu.h header uses types defined in linux/notifier.h but
> doesn't include it.
>
> Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Better than adding the header-file is to add a forward declaration for
struct notifier_block. I added a patch to iommu/fixes for this.
Thanks,
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joerg.roedel@amd.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: <iommu@lists.linux-foundation.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] iommu: Include linux/notifier.h
Date: Fri, 3 Aug 2012 16:08:26 +0200 [thread overview]
Message-ID: <20120803140826.GF1996@amd.com> (raw)
In-Reply-To: <1343226290-32511-2-git-send-email-thierry.reding@avionic-design.de>
On Wed, Jul 25, 2012 at 04:24:50PM +0200, Thierry Reding wrote:
> The linux/iommu.h header uses types defined in linux/notifier.h but
> doesn't include it.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Better than adding the header-file is to add a forward declaration for
struct notifier_block. I added a patch to iommu/fixes for this.
Thanks,
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2012-08-03 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 14:24 [PATCH 1/2] iommu: Include linux/types.h Thierry Reding
2012-07-25 14:24 ` Thierry Reding
[not found] ` <1343226290-32511-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2012-07-25 14:24 ` [PATCH 2/2] iommu: Include linux/notifier.h Thierry Reding
2012-07-25 14:24 ` Thierry Reding
[not found] ` <1343226290-32511-2-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2012-08-03 14:08 ` Joerg Roedel [this message]
2012-08-03 14:08 ` Joerg Roedel
[not found] ` <20120803140826.GF1996-5C7GfCeVMHo@public.gmane.org>
2012-08-03 14:26 ` Thierry Reding
2012-08-03 14:26 ` Thierry Reding
2012-08-03 14:07 ` [PATCH 1/2] iommu: Include linux/types.h Joerg Roedel
2012-08-03 14:07 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803140826.GF1996@amd.com \
--to=joerg.roedel-5c7gfcevmho@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.