All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [GIT PULL] irq fix
Date: Fri, 3 Aug 2012 18:37:15 +0200	[thread overview]
Message-ID: <20120803163715.GA1721@gmail.com> (raw)

Linus,

Please pull the latest irq-urgent-for-linus git tree from:

   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-urgent-for-linus

   HEAD: dc9b229a58dc0dfed34272ff26c6d5fd17c674e0 genirq: Allow irq chips to mark themself oneshot safe

 Thanks,

	Ingo

------------------>
Thomas Gleixner (1):
      genirq: Allow irq chips to mark themself oneshot safe


 include/linux/irq.h |    1 +
 kernel/irq/manage.c |   15 ++++++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 553fb66..216b0ba 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -349,6 +349,7 @@ enum {
 	IRQCHIP_MASK_ON_SUSPEND		= (1 <<  2),
 	IRQCHIP_ONOFFLINE_ENABLED	= (1 <<  3),
 	IRQCHIP_SKIP_SET_WAKE		= (1 <<  4),
+	IRQCHIP_ONESHOT_SAFE		= (1 <<  5),
 };
 
 /* This include will go away once we isolated irq_desc usage to core code */
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 8c54823..2e326d1 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -960,6 +960,18 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
 	}
 
 	/*
+	 * Drivers are often written to work w/o knowledge about the
+	 * underlying irq chip implementation, so a request for a
+	 * threaded irq without a primary hard irq context handler
+	 * requires the ONESHOT flag to be set. Some irq chips like
+	 * MSI based interrupts are per se one shot safe. Check the
+	 * chip flags, so we can avoid the unmask dance at the end of
+	 * the threaded handler for those.
+	 */
+	if (desc->irq_data.chip->flags & IRQCHIP_ONESHOT_SAFE)
+		new->flags &= ~IRQF_ONESHOT;
+
+	/*
 	 * The following block of code has to be executed atomically
 	 */
 	raw_spin_lock_irqsave(&desc->lock, flags);
@@ -1033,7 +1045,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
 		 */
 		new->thread_mask = 1 << ffz(thread_mask);
 
-	} else if (new->handler == irq_default_primary_handler) {
+	} else if (new->handler == irq_default_primary_handler &&
+		   !(desc->irq_data.chip->flags & IRQCHIP_ONESHOT_SAFE)) {
 		/*
 		 * The interrupt was requested with handler = NULL, so
 		 * we use the default primary handler for it. But it

             reply	other threads:[~2012-08-03 16:37 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 16:37 Ingo Molnar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-05  9:42 [GIT PULL] IRQ fix Ingo Molnar
2026-04-05 22:33 ` pr-tracker-bot
2026-03-22  8:03 Ingo Molnar
2026-03-22 18:04 ` pr-tracker-bot
2026-01-18  9:40 Ingo Molnar
2026-01-19 13:54 ` pr-tracker-bot
2025-12-21  8:27 Ingo Molnar
2025-12-23 19:40 ` pr-tracker-bot
2025-11-15  9:09 Ingo Molnar
2025-11-15 18:26 ` pr-tracker-bot
2025-04-26  8:28 Ingo Molnar
2025-04-26 17:05 ` pr-tracker-bot
2025-02-08  9:12 Ingo Molnar
2025-02-08 20:07 ` pr-tracker-bot
2024-12-29  8:40 Ingo Molnar
2024-12-29 18:22 ` pr-tracker-bot
2024-05-25 10:48 Ingo Molnar
2024-05-25 21:53 ` pr-tracker-bot
2024-05-05  9:06 Ingo Molnar
2024-05-05 19:43 ` pr-tracker-bot
2024-04-28  8:05 Ingo Molnar
2024-04-28 19:28 ` pr-tracker-bot
2024-04-14  7:54 Ingo Molnar
2024-04-14 18:48 ` pr-tracker-bot
2024-03-18  9:40 Ingo Molnar
2024-03-18 16:48 ` pr-tracker-bot
2023-10-28 13:17 Ingo Molnar
2023-10-28 18:17 ` pr-tracker-bot
2021-05-15  7:44 Ingo Molnar
2021-05-15 17:55 ` pr-tracker-bot
2020-01-18 17:19 Ingo Molnar
2020-01-18 21:05 ` pr-tracker-bot
2019-09-12  8:35 Ingo Molnar
2019-09-12 10:15 ` pr-tracker-bot
2017-11-05 14:37 Ingo Molnar
2017-03-07 20:24 Ingo Molnar
2016-12-23 22:46 Ingo Molnar
2016-11-14  7:59 Ingo Molnar
2016-10-28  8:33 [GIT PULL] irq fix Ingo Molnar
2016-08-12 19:22 [GIT PULL] IRQ fix Ingo Molnar
2016-01-08 12:42 [GIT PULL] irq fix Ingo Molnar
2015-05-15  7:13 Ingo Molnar
2014-04-16 12:59 Ingo Molnar
2013-10-04  7:51 Ingo Molnar
2011-12-05 19:03 Ingo Molnar
2011-06-13  9:51 Ingo Molnar
2011-05-03 11:48 Ingo Molnar
2011-04-22 13:33 Ingo Molnar
2011-04-07 17:46 Ingo Molnar
2011-02-03 17:14 Ingo Molnar
2010-12-08  8:05 Ingo Molnar
2009-11-10 17:50 Ingo Molnar
2009-08-10 18:15 Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120803163715.GA1721@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.