From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: [GIT PULL] irq fix
Date: Fri, 4 Oct 2013 09:51:40 +0200 [thread overview]
Message-ID: <20131004075140.GA13294@gmail.com> (raw)
Linus,
Please pull the latest irq-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-urgent-for-linus
HEAD: 0d119fb57614fe947aa9048f61d680bbede64170 Merge branch 'irq/urgent-v2' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks into irq/urgent
Frederic's minimal fix for hardirq/softirq nesting crashes.
Thanks,
Ingo
------------------>
Frederic Weisbecker (1):
irq: Force hardirq exit's softirq processing on its own stack
kernel/softirq.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 53cc09c..d7d498d 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -328,10 +328,19 @@ void irq_enter(void)
static inline void invoke_softirq(void)
{
- if (!force_irqthreads)
- __do_softirq();
- else
+ if (!force_irqthreads) {
+ /*
+ * We can safely execute softirq on the current stack if
+ * it is the irq stack, because it should be near empty
+ * at this stage. But we have no way to know if the arch
+ * calls irq_exit() on the irq stack. So call softirq
+ * in its own stack to prevent from any overrun on top
+ * of a potentially deep task stack.
+ */
+ do_softirq();
+ } else {
wakeup_softirqd();
+ }
}
static inline void tick_irq_exit(void)
next reply other threads:[~2013-10-04 7:51 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 7:51 Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-05 9:42 [GIT PULL] IRQ fix Ingo Molnar
2026-04-05 22:33 ` pr-tracker-bot
2026-03-22 8:03 Ingo Molnar
2026-03-22 18:04 ` pr-tracker-bot
2026-01-18 9:40 Ingo Molnar
2026-01-19 13:54 ` pr-tracker-bot
2025-12-21 8:27 Ingo Molnar
2025-12-23 19:40 ` pr-tracker-bot
2025-11-15 9:09 Ingo Molnar
2025-11-15 18:26 ` pr-tracker-bot
2025-04-26 8:28 Ingo Molnar
2025-04-26 17:05 ` pr-tracker-bot
2025-02-08 9:12 Ingo Molnar
2025-02-08 20:07 ` pr-tracker-bot
2024-12-29 8:40 Ingo Molnar
2024-12-29 18:22 ` pr-tracker-bot
2024-05-25 10:48 Ingo Molnar
2024-05-25 21:53 ` pr-tracker-bot
2024-05-05 9:06 Ingo Molnar
2024-05-05 19:43 ` pr-tracker-bot
2024-04-28 8:05 Ingo Molnar
2024-04-28 19:28 ` pr-tracker-bot
2024-04-14 7:54 Ingo Molnar
2024-04-14 18:48 ` pr-tracker-bot
2024-03-18 9:40 Ingo Molnar
2024-03-18 16:48 ` pr-tracker-bot
2023-10-28 13:17 Ingo Molnar
2023-10-28 18:17 ` pr-tracker-bot
2021-05-15 7:44 Ingo Molnar
2021-05-15 17:55 ` pr-tracker-bot
2020-01-18 17:19 Ingo Molnar
2020-01-18 21:05 ` pr-tracker-bot
2019-09-12 8:35 Ingo Molnar
2019-09-12 10:15 ` pr-tracker-bot
2017-11-05 14:37 Ingo Molnar
2017-03-07 20:24 Ingo Molnar
2016-12-23 22:46 Ingo Molnar
2016-11-14 7:59 Ingo Molnar
2016-10-28 8:33 [GIT PULL] irq fix Ingo Molnar
2016-08-12 19:22 [GIT PULL] IRQ fix Ingo Molnar
2016-01-08 12:42 [GIT PULL] irq fix Ingo Molnar
2015-05-15 7:13 Ingo Molnar
2014-04-16 12:59 Ingo Molnar
2012-08-03 16:37 Ingo Molnar
2011-12-05 19:03 Ingo Molnar
2011-06-13 9:51 Ingo Molnar
2011-05-03 11:48 Ingo Molnar
2011-04-22 13:33 Ingo Molnar
2011-04-07 17:46 Ingo Molnar
2011-02-03 17:14 Ingo Molnar
2010-12-08 8:05 Ingo Molnar
2009-11-10 17:50 Ingo Molnar
2009-08-10 18:15 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004075140.GA13294@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.