All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] serial: ifx6x60: fix paging fault on spi_register_driver
@ 2012-08-07  5:12 Fengguang Wu
  2012-08-07 10:13 ` Alan Cox
  0 siblings, 1 reply; 2+ messages in thread
From: Fengguang Wu @ 2012-08-07  5:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Alan Cox, linux-serial, linux-kernel, Russ Gorby

[  117.240866] BUG: unable to handle kernel paging request at 815b627c
[  117.240866] IP: [<813fe94b>] spi_register_driver+0xb/0x50
...
[  117.240866] Call Trace:
[  117.240866]  [<817de977>] ifx_spi_init+0xbe/0xf0

The root cause is, spi_register_driver() is trying to write into the
passed *const* struct spi_driver.

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 drivers/tty/serial/ifx6x60.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux.orig/drivers/tty/serial/ifx6x60.c	2012-05-24 19:03:07.408430953 +0800
+++ linux/drivers/tty/serial/ifx6x60.c	2012-08-07 12:57:05.499312357 +0800
@@ -1331,7 +1331,7 @@ static const struct spi_device_id ifx_id
 MODULE_DEVICE_TABLE(spi, ifx_id_table);
 
 /* spi operations */
-static const struct spi_driver ifx_spi_driver = {
+static struct spi_driver ifx_spi_driver = {
 	.driver = {
 		.name = DRVNAME,
 		.pm = &ifx_spi_pm,

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] serial: ifx6x60: fix paging fault on spi_register_driver
  2012-08-07  5:12 [PATCH] serial: ifx6x60: fix paging fault on spi_register_driver Fengguang Wu
@ 2012-08-07 10:13 ` Alan Cox
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2012-08-07 10:13 UTC (permalink / raw)
  To: Fengguang Wu
  Cc: Greg Kroah-Hartman, Alan Cox, linux-serial, linux-kernel,
	Russ Gorby

On Tue, 7 Aug 2012 13:12:47 +0800
Fengguang Wu <fengguang.wu@intel.com> wrote:

> [  117.240866] BUG: unable to handle kernel paging request at 815b627c
> [  117.240866] IP: [<813fe94b>] spi_register_driver+0xb/0x50
> ...
> [  117.240866] Call Trace:
> [  117.240866]  [<817de977>] ifx_spi_init+0xbe/0xf0
> 
> The root cause is, spi_register_driver() is trying to write into the
> passed *const* struct spi_driver.
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Acked-by: Alan Cox <alan@linux.intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-07 10:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-07  5:12 [PATCH] serial: ifx6x60: fix paging fault on spi_register_driver Fengguang Wu
2012-08-07 10:13 ` Alan Cox

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.