From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: OMAP: clean up some smatch warnings, fix some printk(KERN_ERR ...
Date: Tue, 7 Aug 2012 03:40:23 -0700 [thread overview]
Message-ID: <20120807104023.GV11011@atomide.com> (raw)
In-Reply-To: <20120807103439.8053.65054.stgit@dusk.lan>
* Paul Walmsley <paul@pwsan.com> [120807 03:35]:
> --- a/arch/arm/mach-omap1/lcd_dma.c
> +++ b/arch/arm/mach-omap1/lcd_dma.c
> @@ -94,7 +94,6 @@ void omap_set_lcd_dma_b1_rotation(int rotate)
> if (cpu_is_omap15xx()) {
> printk(KERN_ERR "DMA rotation is not supported in 1510 mode\n");
> BUG();
> - return;
> }
> lcd_dma.rotate = rotate;
> }
> @@ -154,7 +153,6 @@ static void set_b1_regs(void)
> break;
> default:
> BUG();
> - return;
> }
>
> vxres = lcd_dma.vxres ? lcd_dma.vxres : lcd_dma.xres;
> @@ -234,7 +232,6 @@ static void set_b1_regs(void)
> break;
> default:
> BUG();
> - return; /* Suppress warning about uninitialized vars */
> }
>
> if (cpu_is_omap15xx()) {
I think these will cause new randconfig warnings without CONFIG_BUG set.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: OMAP: clean up some smatch warnings, fix some printk(KERN_ERR ...
Date: Tue, 7 Aug 2012 03:40:23 -0700 [thread overview]
Message-ID: <20120807104023.GV11011@atomide.com> (raw)
In-Reply-To: <20120807103439.8053.65054.stgit@dusk.lan>
* Paul Walmsley <paul@pwsan.com> [120807 03:35]:
> --- a/arch/arm/mach-omap1/lcd_dma.c
> +++ b/arch/arm/mach-omap1/lcd_dma.c
> @@ -94,7 +94,6 @@ void omap_set_lcd_dma_b1_rotation(int rotate)
> if (cpu_is_omap15xx()) {
> printk(KERN_ERR "DMA rotation is not supported in 1510 mode\n");
> BUG();
> - return;
> }
> lcd_dma.rotate = rotate;
> }
> @@ -154,7 +153,6 @@ static void set_b1_regs(void)
> break;
> default:
> BUG();
> - return;
> }
>
> vxres = lcd_dma.vxres ? lcd_dma.vxres : lcd_dma.xres;
> @@ -234,7 +232,6 @@ static void set_b1_regs(void)
> break;
> default:
> BUG();
> - return; /* Suppress warning about uninitialized vars */
> }
>
> if (cpu_is_omap15xx()) {
I think these will cause new randconfig warnings without CONFIG_BUG set.
Tony
next prev parent reply other threads:[~2012-08-07 10:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 10:34 [PATCH 0/2] ARM: OMAP: smatch warning cleanup and string unwrapping Paul Walmsley
2012-08-07 10:34 ` Paul Walmsley
2012-08-07 10:34 ` [PATCH 1/2] ARM: OMAP: clean up some smatch warnings, fix some printk(KERN_ERR Paul Walmsley
2012-08-07 10:34 ` Paul Walmsley
2012-08-07 10:40 ` Tony Lindgren [this message]
2012-08-07 10:40 ` Tony Lindgren
2012-08-07 15:00 ` Paul Walmsley
2012-08-07 15:00 ` Paul Walmsley
2012-08-07 10:34 ` [PATCH 2/2] ARM: OMAP: unwrap strings Paul Walmsley
2012-08-07 10:34 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807104023.GV11011@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.