From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>,
arnd@arndb.de, gregkh@linuxfoundation.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] driver: misc: bmp085: remove "of_match_table" property.
Date: Tue, 7 Aug 2012 11:52:26 +0100 [thread overview]
Message-ID: <20120807105225.GT16861@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120807054342.GF8468@arwen.pp.htv.fi>
On Tue, Aug 07, 2012 at 08:43:44AM +0300, Felipe Balbi wrote:
> On Mon, Aug 06, 2012 at 04:42:14PM +0100, Mark Brown wrote:
> > It's good practice to have an explict compatible string even if the
> > default happens to work in order to avoid any name clashes.
> of_i2c.c makes no use whatsoever of the compatible string. See that it
> will build an i2c_boardinfo and register a new device. That compatible
If that's all that's done it seems like a bug frankly, certainly based
on previous discussions it ought to be. There are collisions out there,
they've just happened to not bite us yet
> string is just churn and has no use at all.
This is device tree we're talking about, there's a lot churn anyway.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] driver: misc: bmp085: remove "of_match_table" property.
Date: Tue, 7 Aug 2012 11:52:26 +0100 [thread overview]
Message-ID: <20120807105225.GT16861@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120807054342.GF8468@arwen.pp.htv.fi>
On Tue, Aug 07, 2012 at 08:43:44AM +0300, Felipe Balbi wrote:
> On Mon, Aug 06, 2012 at 04:42:14PM +0100, Mark Brown wrote:
> > It's good practice to have an explict compatible string even if the
> > default happens to work in order to avoid any name clashes.
> of_i2c.c makes no use whatsoever of the compatible string. See that it
> will build an i2c_boardinfo and register a new device. That compatible
If that's all that's done it seems like a bug frankly, certainly based
on previous discussions it ought to be. There are collisions out there,
they've just happened to not bite us yet
> string is just churn and has no use at all.
This is device tree we're talking about, there's a lot churn anyway.
next prev parent reply other threads:[~2012-08-07 10:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 9:28 [PATCH] driver: misc: bmp085: remove "of_match_table" property Sourav Poddar
2012-08-06 9:28 ` Sourav Poddar
2012-08-06 9:28 ` Sourav Poddar
2012-08-06 9:30 ` Felipe Balbi
2012-08-06 9:30 ` Felipe Balbi
[not found] ` <20120806093033.GH17551-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-08-06 15:42 ` Mark Brown
2012-08-06 15:42 ` Mark Brown
2012-08-06 15:42 ` Mark Brown
[not found] ` <20120806154214.GC29272-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-08-07 5:43 ` Felipe Balbi
2012-08-07 5:43 ` Felipe Balbi
2012-08-07 5:43 ` Felipe Balbi
2012-08-07 10:52 ` Mark Brown [this message]
2012-08-07 10:52 ` Mark Brown
2012-08-07 17:23 ` Warner Losh
2012-08-07 17:23 ` Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807105225.GT16861@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.