From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Leela Krishna Amudala <l.krishna@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org,
kgene.kim@samsung.com, ben-linux@fluff.org,
dri-devel@lists.freedesktop.org, m.szyprowski@samsung.com
Subject: Re: [PATCH V4 1/2] include/video: move fimd register headers from platform to include/video
Date: Tue, 07 Aug 2012 14:28:56 +0000 [thread overview]
Message-ID: <201208071428.56290.arnd@arndb.de> (raw)
In-Reply-To: <1344342872-7904-2-git-send-email-l.krishna@samsung.com>
On Tuesday 07 August 2012, Leela Krishna Amudala wrote:
>
> This patch moves the contents from regs-fb-v4.h and regs-fb.h to
> include/video/samsung_fimd.h. Also updates the header inclusion in
> machine files and driver files accordingly.
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
You are missing an explanation here about why the file is moved.
It does seem like a good idea but please say why you do this.
More importantly, I don't understany why you move regs-fb-v4.h
but not regs-fb.h, which is included by the former. Also, the
only identifiers used in arch/arm from either of the two headers
are
VIDCON0_VIDOUT_RGB
VIDCON0_PNRMODE_RGBV
VIDCON0_CLKSEL_LCD
VIDCON1_INV_HSYNC
VIDCON1_INV_VSYNC
VIDCON1_INV_VCLK
VIDCON1_INV_VDEN
and they are all in plat/regs-fb.h, so there is no need to
include the entire header file.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Leela Krishna Amudala <l.krishna@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org,
kgene.kim@samsung.com, ben-linux@fluff.org,
dri-devel@lists.freedesktop.org, m.szyprowski@samsung.com
Subject: Re: [PATCH V4 1/2] include/video: move fimd register headers from platform to include/video
Date: Tue, 7 Aug 2012 14:28:56 +0000 [thread overview]
Message-ID: <201208071428.56290.arnd@arndb.de> (raw)
In-Reply-To: <1344342872-7904-2-git-send-email-l.krishna@samsung.com>
On Tuesday 07 August 2012, Leela Krishna Amudala wrote:
>
> This patch moves the contents from regs-fb-v4.h and regs-fb.h to
> include/video/samsung_fimd.h. Also updates the header inclusion in
> machine files and driver files accordingly.
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
You are missing an explanation here about why the file is moved.
It does seem like a good idea but please say why you do this.
More importantly, I don't understany why you move regs-fb-v4.h
but not regs-fb.h, which is included by the former. Also, the
only identifiers used in arch/arm from either of the two headers
are
VIDCON0_VIDOUT_RGB
VIDCON0_PNRMODE_RGBV
VIDCON0_CLKSEL_LCD
VIDCON1_INV_HSYNC
VIDCON1_INV_VSYNC
VIDCON1_INV_VCLK
VIDCON1_INV_VDEN
and they are all in plat/regs-fb.h, so there is no need to
include the entire header file.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 1/2] include/video: move fimd register headers from platform to include/video
Date: Tue, 7 Aug 2012 14:28:56 +0000 [thread overview]
Message-ID: <201208071428.56290.arnd@arndb.de> (raw)
In-Reply-To: <1344342872-7904-2-git-send-email-l.krishna@samsung.com>
On Tuesday 07 August 2012, Leela Krishna Amudala wrote:
>
> This patch moves the contents from regs-fb-v4.h and regs-fb.h to
> include/video/samsung_fimd.h. Also updates the header inclusion in
> machine files and driver files accordingly.
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
You are missing an explanation here about why the file is moved.
It does seem like a good idea but please say why you do this.
More importantly, I don't understany why you move regs-fb-v4.h
but not regs-fb.h, which is included by the former. Also, the
only identifiers used in arch/arm from either of the two headers
are
VIDCON0_VIDOUT_RGB
VIDCON0_PNRMODE_RGBV
VIDCON0_CLKSEL_LCD
VIDCON1_INV_HSYNC
VIDCON1_INV_VSYNC
VIDCON1_INV_VCLK
VIDCON1_INV_VDEN
and they are all in plat/regs-fb.h, so there is no need to
include the entire header file.
Arnd
next prev parent reply other threads:[~2012-08-07 14:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 12:34 [PATCH V4 0/2] arm: samsung: Move FIMD headers to include/video/ Leela Krishna Amudala
2012-08-07 12:46 ` Leela Krishna Amudala
2012-08-07 12:34 ` Leela Krishna Amudala
2012-08-07 12:34 ` [PATCH V4 1/2] include/video: move fimd register headers from platform to include/video Leela Krishna Amudala
2012-08-07 12:46 ` Leela Krishna Amudala
2012-08-07 12:34 ` Leela Krishna Amudala
2012-08-07 14:28 ` Arnd Bergmann [this message]
2012-08-07 14:28 ` Arnd Bergmann
2012-08-07 14:28 ` Arnd Bergmann
2012-08-07 15:25 ` Arnd Bergmann
2012-08-07 15:25 ` Arnd Bergmann
2012-08-07 15:25 ` Arnd Bergmann
2012-08-07 12:34 ` [PATCH V4 2/2] include/video: Add register offsets for FIMD version 8 Leela Krishna Amudala
2012-08-07 12:46 ` Leela Krishna Amudala
2012-08-07 12:34 ` Leela Krishna Amudala
2012-08-07 14:33 ` [PATCH V4 0/2] arm: samsung: Move FIMD headers to include/video/ Russell King - ARM Linux
2012-08-07 14:33 ` Russell King - ARM Linux
2012-08-07 14:33 ` Russell King - ARM Linux
2012-08-07 15:05 ` Sylwester Nawrocki
2012-08-07 15:05 ` Sylwester Nawrocki
2012-08-07 15:05 ` Sylwester Nawrocki
2012-08-08 6:20 ` Kukjin Kim
2012-08-08 6:20 ` Kukjin Kim
2012-08-08 6:20 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208071428.56290.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kgene.kim@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.