From: Tony Lindgren <tony@atomide.com>
To: Konstantin Baydarov <kbaidarov@dev.rtsoft.ru>
Cc: amit.kucheria@linaro.org, kishon@ti.com, balbi@ti.com,
linux-pm@lists.linux-foundation.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/7] mfd: omap: control: core system control driver
Date: Wed, 8 Aug 2012 06:48:50 -0700 [thread overview]
Message-ID: <20120808134849.GC11011@atomide.com> (raw)
In-Reply-To: <4FEB4B46.9020904@dev.rtsoft.ru>
* Konstantin Baydarov <kbaidarov@dev.rtsoft.ru> [120627 11:09]:
> +
> +/* TODO: Add helpers for 16bit and byte access */
> +#ifdef CONFIG_MFD_OMAP_CONTROL
> +u32 omap_control_status_read(u16 offset);
> +#else
> +static inline u32 omap_control_status_read(u16 offset)
> +{
> + return 0;
> +}
> +#endif
This should be an exported function instead. And it should
not need the offset as a parameter as the SCM core should know
where to find it's control_status register.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/7] mfd: omap: control: core system control driver
Date: Wed, 8 Aug 2012 06:48:50 -0700 [thread overview]
Message-ID: <20120808134849.GC11011@atomide.com> (raw)
In-Reply-To: <4FEB4B46.9020904@dev.rtsoft.ru>
* Konstantin Baydarov <kbaidarov@dev.rtsoft.ru> [120627 11:09]:
> +
> +/* TODO: Add helpers for 16bit and byte access */
> +#ifdef CONFIG_MFD_OMAP_CONTROL
> +u32 omap_control_status_read(u16 offset);
> +#else
> +static inline u32 omap_control_status_read(u16 offset)
> +{
> + return 0;
> +}
> +#endif
This should be an exported function instead. And it should
not need the offset as a parameter as the SCM core should know
where to find it's control_status register.
Regards,
Tony
next prev parent reply other threads:[~2012-08-08 13:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 18:04 [PATCH v3 2/7] mfd: omap: control: core system control driver Konstantin Baydarov
2012-06-27 18:04 ` Konstantin Baydarov
2012-06-28 4:50 ` Eduardo Valentin
2012-06-28 4:50 ` Eduardo Valentin
2012-06-28 9:37 ` Konstantin Baydarov
2012-06-28 9:37 ` Konstantin Baydarov
2012-06-28 9:49 ` Valentin, Eduardo
2012-06-28 9:49 ` Valentin, Eduardo
2012-06-28 10:12 ` Konstantin Baydarov
2012-06-28 10:12 ` Konstantin Baydarov
2012-06-28 10:26 ` Konstantin Baydarov
2012-06-28 10:26 ` Konstantin Baydarov
2012-06-28 10:51 ` Valentin, Eduardo
2012-06-28 10:51 ` Valentin, Eduardo
2012-06-28 10:55 ` Valentin, Eduardo
2012-06-28 10:55 ` Valentin, Eduardo
2012-07-03 11:00 ` Valentin, Eduardo
2012-07-03 11:00 ` Valentin, Eduardo
2012-08-08 13:48 ` Tony Lindgren [this message]
2012-08-08 13:48 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808134849.GC11011@atomide.com \
--to=tony@atomide.com \
--cc=amit.kucheria@linaro.org \
--cc=balbi@ti.com \
--cc=kbaidarov@dev.rtsoft.ru \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.