All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jan Luebbe <jlu@pengutronix.de>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Vaibhav Hiremath <hvaibhav@ti.com>
Subject: Re: [PATCH] omap: Fix multi.h when only ARCH_OMAP3 and SOC_AM33XX are selected
Date: Wed, 8 Aug 2012 07:23:10 -0700	[thread overview]
Message-ID: <20120808142309.GH11011@atomide.com> (raw)
In-Reply-To: <1344356985-21801-1-git-send-email-jlu@pengutronix.de>

* Jan Luebbe <jlu@pengutronix.de> [120807 09:30]:
> When only ARCH_OMAP3 (or -2,-4,...) and SOC_AM33XX are selected, multi.h
> doesn't set MULTI_OMAP2. In this case, cpu.h will simply define
> cpu_is_omap24xx() as 1.
> 
> This causes problems for example for omap_hwmod.c:omap_hwmod_init which
> checks for cpu_is_omap24xx() first, using the wrong soc_ops for AM33xx.
> 
> Fix this by defining MULTI_OMAP2 when using SOC_AM33XX together with
> something else.

Thanks applying into fixes.

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap: Fix multi.h when only ARCH_OMAP3 and SOC_AM33XX are selected
Date: Wed, 8 Aug 2012 07:23:10 -0700	[thread overview]
Message-ID: <20120808142309.GH11011@atomide.com> (raw)
In-Reply-To: <1344356985-21801-1-git-send-email-jlu@pengutronix.de>

* Jan Luebbe <jlu@pengutronix.de> [120807 09:30]:
> When only ARCH_OMAP3 (or -2,-4,...) and SOC_AM33XX are selected, multi.h
> doesn't set MULTI_OMAP2. In this case, cpu.h will simply define
> cpu_is_omap24xx() as 1.
> 
> This causes problems for example for omap_hwmod.c:omap_hwmod_init which
> checks for cpu_is_omap24xx() first, using the wrong soc_ops for AM33xx.
> 
> Fix this by defining MULTI_OMAP2 when using SOC_AM33XX together with
> something else.

Thanks applying into fixes.

Tony

  reply	other threads:[~2012-08-08 14:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07 16:29 [PATCH] omap: Fix multi.h when only ARCH_OMAP3 and SOC_AM33XX are selected Jan Luebbe
2012-08-07 16:29 ` Jan Luebbe
2012-08-08 14:23 ` Tony Lindgren [this message]
2012-08-08 14:23   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120808142309.GH11011@atomide.com \
    --to=tony@atomide.com \
    --cc=hvaibhav@ti.com \
    --cc=jlu@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.