From: Denys Dmytriyenko <denys@ti.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: "meta-ti@yoctoproject.org" <meta-ti@yoctoproject.org>,
"Cooper Jr., Franklin" <fcooper@ti.com>
Subject: Re: [branch: master][PATCHES] Porting netbase interfaces file from oe-classic
Date: Wed, 8 Aug 2012 15:42:14 -0400 [thread overview]
Message-ID: <20120808194211.GE7572@edge> (raw)
In-Reply-To: <307F2CD6-B16B-4EC7-A670-06361B199D00@dominion.thruhere.net>
On Thu, Aug 02, 2012 at 05:07:36PM +0200, Koen Kooi wrote:
>
> Op 2 aug. 2012, om 16:53 heeft "Maupin, Chase" <chase.maupin@ti.com> het volgende geschreven:
>
> >> -----Original Message-----
> >> From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> >> bounces@yoctoproject.org] On Behalf Of Koen Kooi
> >> Sent: Wednesday, August 01, 2012 10:59 PM
> >> To: Cooper Jr., Franklin
> >> Cc: meta-ti@yoctoproject.org
> >> Subject: Re: [meta-ti] [branch: master][PATCHES] Porting netbase
> >> interfaces file from oe-classic
> >>
> >> Please send patches inline to make review easier.
> >>
> >> Patch 1:
> >>
> >>> * Add PR_append
> >>
> >> Don't do that, that's what PRINC is for
> >>
> >>> * Pull in the base interface file from oe-core
> >>
> >> Completely unneeded
> >
> > I actually prefer that the first commit move in the base file he
> > is modifying and then have the second commit make his changes.
> > It is much easier to understand what change he was making to the
> > base file and why he needing to overlay it.
>
> My point is that you're now *globally* modifying basefiles for *all*
> machines, including non-TI ones as soon as you have meta-ti in the layer
> stack, which is unacceptable. If you really want a catch-all interfaces
> file, put it in meta-arago.
FYI, after discussing this internally, we agreed to not modify basefiles
globally, but rather provide SOC-specific version where possible, or even
machine-specific, when needed. In this particular case, we'll have a
ti33x-specific interfaces file, which will be overwritten by
beaglebone-specific one. PRINC should also be used in meta-ti bbappends.
Franklin, will you be resending the updated patch?
--
Denys
prev parent reply other threads:[~2012-08-08 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 19:07 [branch: master][PATCHES] Porting netbase interfaces file from oe-classic Cooper Jr., Franklin
2012-08-01 21:51 ` [branch: master][PATCHES] Porting netbase interfaces file from oe-classic v2 Cooper Jr., Franklin
2012-08-02 3:59 ` [branch: master][PATCHES] Porting netbase interfaces file from oe-classic Koen Kooi
2012-08-02 14:53 ` Maupin, Chase
2012-08-02 15:07 ` Koen Kooi
2012-08-08 19:42 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808194211.GE7572@edge \
--to=denys@ti.com \
--cc=fcooper@ti.com \
--cc=koen@dominion.thruhere.net \
--cc=meta-ti@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.