[branch: master][PATCHES] Porting netbase interfaces file from oe-classic

[branch: master][PATCHES] Porting netbase interfaces file from oe-classic

[Cooper Jr., Franklin]

[-- Attachment #1.1: Type: text/plain, Size: 1069 bytes --]

Attached patches are for porting the netbase interface file used in arago/oe-classic to meta-ti.

The difference between my interfaces file and the one in beagleboard directory seems very minor. Would it be ok to combine the changes from both files into a single file? The auto usb0 looks like it might be an issue if we combined the two files. Would it make sense to append that line to the interface file during do_install_append step only for the beagleboard platform and consolidate the rest of the differences?

diff beagleboard/interfaces interfaces
13a14,17
> iface tiwlan0 inet dhcp
>    wireless_mode managed
>    wireless_essid any
>
18a23,24
>         pre-up /bin/grep -v -e "ip=[0-9]\+\.[0-9]\+\.[0-9]\+\.[0-9]\+" /proc/cmdline > /dev/null
>
21,22c27,28
< # Ethernet/RNDIS gadget (g_ether) or LAN9514 on BeagleBoard xM
< auto usb0
---
> # Ethernet/RNDIS gadget (g_ether)
> # ... or on host side, usbnet and random hwaddr


Regards,
Franklin Cooper Jr.
Texas Instruments
Application Engineer
fcooper@ti.com<mailto:fcooper@ti.com>


[-- Attachment #1.2: Type: text/html, Size: 5052 bytes --]

[-- Attachment #2: 0001-netbase-Add-base-interface-file.patch --]
[-- Type: application/octet-stream, Size: 2013 bytes --]

From 98554cbcd95228430a33f7bfa7d0cfc73ebb93e3 Mon Sep 17 00:00:00 2001
From: Franklin S Cooper Jr <fcooper@ti.com>
Date: Wed, 1 Aug 2012 13:46:53 -0500
Subject: [PATCH 1/2] netbase: Add base interface file

* Add PR_append
* Pull in the base interface file from oe-core
* Update to use the new syntax for extending the file search path

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 recipes-core/netbase/netbase-5.0/interfaces |   31 +++++++++++++++++++++++++++
 recipes-core/netbase/netbase_5.0.bbappend   |    5 ++-
 2 files changed, 34 insertions(+), 2 deletions(-)
 create mode 100644 recipes-core/netbase/netbase-5.0/interfaces

diff --git a/recipes-core/netbase/netbase-5.0/interfaces b/recipes-core/netbase/netbase-5.0/interfaces
new file mode 100644
index 0000000..0acf4cf
--- /dev/null
+++ b/recipes-core/netbase/netbase-5.0/interfaces
@@ -0,0 +1,31 @@
+# /etc/network/interfaces -- configuration file for ifup(8), ifdown(8)
+ 
+# The loopback interface
+auto lo
+iface lo inet loopback
+
+# Wireless interfaces
+iface wlan0 inet dhcp
+	wireless_mode managed
+	wireless_essid any
+	wpa-driver wext
+	wpa-conf /etc/wpa_supplicant.conf
+
+iface atml0 inet dhcp
+
+# Wired or wireless interfaces
+auto eth0
+iface eth0 inet dhcp
+iface eth1 inet dhcp
+
+# Ethernet/RNDIS gadget (g_ether)
+# ... or on host side, usbnet and random hwaddr
+iface usb0 inet static
+	address 192.168.7.2
+	netmask 255.255.255.0
+	network 192.168.7.0
+	gateway 192.168.7.1
+
+# Bluetooth networking
+iface bnep0 inet dhcp
+
diff --git a/recipes-core/netbase/netbase_5.0.bbappend b/recipes-core/netbase/netbase_5.0.bbappend
index 4b8d0e6..e059b21 100644
--- a/recipes-core/netbase/netbase_5.0.bbappend
+++ b/recipes-core/netbase/netbase_5.0.bbappend
@@ -1,3 +1,4 @@
-THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
-FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
+# look for files in this layer first
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}"
 
+PR_append = "-ti0"
-- 
1.7.0.4


[-- Attachment #3: 0002-netbase-Update-interface-file.patch --]
[-- Type: application/octet-stream, Size: 1357 bytes --]

From 0300ee0f38ec2167366c391bd063230df3d408c8 Mon Sep 17 00:00:00 2001
From: Franklin S Cooper Jr <fcooper@ti.com>
Date: Wed, 1 Aug 2012 13:48:18 -0500
Subject: [PATCH 2/2] netbase: Update interface file

* Update interface file based on changes made to the interface file
  in arago

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 recipes-core/netbase/netbase-5.0/interfaces |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/recipes-core/netbase/netbase-5.0/interfaces b/recipes-core/netbase/netbase-5.0/interfaces
index 0acf4cf..15bc31c 100644
--- a/recipes-core/netbase/netbase-5.0/interfaces
+++ b/recipes-core/netbase/netbase-5.0/interfaces
@@ -11,20 +11,22 @@ iface wlan0 inet dhcp
 	wpa-driver wext
 	wpa-conf /etc/wpa_supplicant.conf
 
+iface tiwlan0 inet dhcp
+	wireless_mode managed
+	wireless_essid any
+
 iface atml0 inet dhcp
 
 # Wired or wireless interfaces
 auto eth0
 iface eth0 inet dhcp
+        pre-up /bin/grep -v -e "ip=[0-9]\+\.[0-9]\+\.[0-9]\+\.[0-9]\+" /proc/cmdline > /dev/null
+
 iface eth1 inet dhcp
 
 # Ethernet/RNDIS gadget (g_ether)
 # ... or on host side, usbnet and random hwaddr
-iface usb0 inet static
-	address 192.168.7.2
-	netmask 255.255.255.0
-	network 192.168.7.0
-	gateway 192.168.7.1
+iface usb0 inet dhcp
 
 # Bluetooth networking
 iface bnep0 inet dhcp
-- 
1.7.0.4

Re: [branch: master][PATCHES] Porting netbase interfaces file from oe-classic v2

[Cooper Jr., Franklin]

[-- Attachment #1.1: Type: text/plain, Size: 1388 bytes --]

Please use these patches instead of the previous set of patches sent. I had to make a minor adjustment.

From: Cooper Jr., Franklin
Sent: Wednesday, August 01, 2012 2:07 PM
To: meta-ti@yoctoproject.org
Cc: Cooper Jr., Franklin
Subject: [branch: master][PATCHES] Porting netbase interfaces file from oe-classic

Attached patches are for porting the netbase interface file used in arago/oe-classic to meta-ti.

The difference between my interfaces file and the one in beagleboard directory seems very minor. Would it be ok to combine the changes from both files into a single file? The auto usb0 looks like it might be an issue if we combined the two files. Would it make sense to append that line to the interface file during do_install_append step only for the beagleboard platform and consolidate the rest of the differences?

diff beagleboard/interfaces interfaces
13a14,17
> iface tiwlan0 inet dhcp
>    wireless_mode managed
>    wireless_essid any
>
18a23,24
>         pre-up /bin/grep -v -e "ip=[0-9]\+\.[0-9]\+\.[0-9]\+\.[0-9]\+" /proc/cmdline > /dev/null
>
21,22c27,28
< # Ethernet/RNDIS gadget (g_ether) or LAN9514 on BeagleBoard xM
< auto usb0
---
> # Ethernet/RNDIS gadget (g_ether)
> # ... or on host side, usbnet and random hwaddr


Regards,
Franklin Cooper Jr.
Texas Instruments
Application Engineer
fcooper@ti.com<mailto:fcooper@ti.com>


[-- Attachment #1.2: Type: text/html, Size: 6133 bytes --]

[-- Attachment #2: 0001-netbase-Add-base-interface-file.patch --]
[-- Type: application/octet-stream, Size: 2014 bytes --]

From 4511d637714618cfaac016a9dc5c17b17d13221e Mon Sep 17 00:00:00 2001
From: Franklin S Cooper Jr <fcooper@ti.com>
Date: Wed, 1 Aug 2012 13:46:53 -0500
Subject: [PATCH 1/2] netbase: Add base interface file

* Add PR_append
* Pull in the base interface file from oe-core
* Update to use the new syntax for extending the file search path

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 recipes-core/netbase/netbase-5.0/interfaces |   31 +++++++++++++++++++++++++++
 recipes-core/netbase/netbase_5.0.bbappend   |    5 ++-
 2 files changed, 34 insertions(+), 2 deletions(-)
 create mode 100644 recipes-core/netbase/netbase-5.0/interfaces

diff --git a/recipes-core/netbase/netbase-5.0/interfaces b/recipes-core/netbase/netbase-5.0/interfaces
new file mode 100644
index 0000000..0acf4cf
--- /dev/null
+++ b/recipes-core/netbase/netbase-5.0/interfaces
@@ -0,0 +1,31 @@
+# /etc/network/interfaces -- configuration file for ifup(8), ifdown(8)
+ 
+# The loopback interface
+auto lo
+iface lo inet loopback
+
+# Wireless interfaces
+iface wlan0 inet dhcp
+	wireless_mode managed
+	wireless_essid any
+	wpa-driver wext
+	wpa-conf /etc/wpa_supplicant.conf
+
+iface atml0 inet dhcp
+
+# Wired or wireless interfaces
+auto eth0
+iface eth0 inet dhcp
+iface eth1 inet dhcp
+
+# Ethernet/RNDIS gadget (g_ether)
+# ... or on host side, usbnet and random hwaddr
+iface usb0 inet static
+	address 192.168.7.2
+	netmask 255.255.255.0
+	network 192.168.7.0
+	gateway 192.168.7.1
+
+# Bluetooth networking
+iface bnep0 inet dhcp
+
diff --git a/recipes-core/netbase/netbase_5.0.bbappend b/recipes-core/netbase/netbase_5.0.bbappend
index 4b8d0e6..5c45ad5 100644
--- a/recipes-core/netbase/netbase_5.0.bbappend
+++ b/recipes-core/netbase/netbase_5.0.bbappend
@@ -1,3 +1,4 @@
-THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
-FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
+# look for files in this layer first
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
+PR_append = "-ti0"
-- 
1.7.0.4


[-- Attachment #3: 0002-netbase-Update-interface-file.patch --]
[-- Type: application/octet-stream, Size: 1357 bytes --]

From 81640a6aa83d5431547da314ea8298f6fa2cab91 Mon Sep 17 00:00:00 2001
From: Franklin S Cooper Jr <fcooper@ti.com>
Date: Wed, 1 Aug 2012 13:48:18 -0500
Subject: [PATCH 2/2] netbase: Update interface file

* Update interface file based on changes made to the interface file
  in arago

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 recipes-core/netbase/netbase-5.0/interfaces |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/recipes-core/netbase/netbase-5.0/interfaces b/recipes-core/netbase/netbase-5.0/interfaces
index 0acf4cf..15bc31c 100644
--- a/recipes-core/netbase/netbase-5.0/interfaces
+++ b/recipes-core/netbase/netbase-5.0/interfaces
@@ -11,20 +11,22 @@ iface wlan0 inet dhcp
 	wpa-driver wext
 	wpa-conf /etc/wpa_supplicant.conf
 
+iface tiwlan0 inet dhcp
+	wireless_mode managed
+	wireless_essid any
+
 iface atml0 inet dhcp
 
 # Wired or wireless interfaces
 auto eth0
 iface eth0 inet dhcp
+        pre-up /bin/grep -v -e "ip=[0-9]\+\.[0-9]\+\.[0-9]\+\.[0-9]\+" /proc/cmdline > /dev/null
+
 iface eth1 inet dhcp
 
 # Ethernet/RNDIS gadget (g_ether)
 # ... or on host side, usbnet and random hwaddr
-iface usb0 inet static
-	address 192.168.7.2
-	netmask 255.255.255.0
-	network 192.168.7.0
-	gateway 192.168.7.1
+iface usb0 inet dhcp
 
 # Bluetooth networking
 iface bnep0 inet dhcp
-- 
1.7.0.4

Re: [branch: master][PATCHES] Porting netbase interfaces file from oe-classic

[Koen Kooi]

Please send patches inline to make review easier.

Patch 1:

> * Add PR_append

Don't do that, that's what PRINC is for

> * Pull in the base interface file from oe-core

Completely unneeded

> * Update to use the new syntax for extending the file search path

Patch 2:

> Update interface file based on changes made to the interface file
  in arago

THe interfaces file is supposed to be machine specific, so a "one file to rule them all" is completely unacceptable in meta-ti. If you want to go such a route, do it in meta-arago. Even so, I strongly recommend against that.

Op 1 aug. 2012, om 21:07 heeft "Cooper Jr., Franklin" <fcooper@ti.com> het volgende geschreven:

> Attached patches are for porting the netbase interface file used in arago/oe-classic to meta-ti.
>  
> The difference between my interfaces file and the one in beagleboard directory seems very minor. Would it be ok to combine the changes from both files into a single file? The auto usb0 looks like it might be an issue if we combined the two files. Would it make sense to append that line to the interface file during do_install_append step only for the beagleboard platform and consolidate the rest of the differences?
>  
> diff beagleboard/interfaces interfaces
> 13a14,17
> > iface tiwlan0 inet dhcp
> >    wireless_mode managed
> >    wireless_essid any
> >
> 18a23,24
> >         pre-up /bin/grep -v -e "ip=[0-9]\+\.[0-9]\+\.[0-9]\+\.[0-9]\+" /proc/cmdline > /dev/null
> >
> 21,22c27,28
> < # Ethernet/RNDIS gadget (g_ether) or LAN9514 on BeagleBoard xM
> < auto usb0
> ---
> > # Ethernet/RNDIS gadget (g_ether)
> > # ... or on host side, usbnet and random hwaddr
>  
>  
> Regards,
> Franklin Cooper Jr.
> Texas Instruments
> Application Engineer
> fcooper@ti.com
>  
> <0001-netbase-Add-base-interface-file.patch><0002-netbase-Update-interface-file.patch>_______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti

Re: [branch: master][PATCHES] Porting netbase interfaces file from oe-classic

[Maupin, Chase]

> -----Original Message-----
> From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> bounces@yoctoproject.org] On Behalf Of Koen Kooi
> Sent: Wednesday, August 01, 2012 10:59 PM
> To: Cooper Jr., Franklin
> Cc: meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [branch: master][PATCHES] Porting netbase
> interfaces file from oe-classic
> 
> Please send patches inline to make review easier.
> 
> Patch 1:
> 
> > * Add PR_append
> 
> Don't do that, that's what PRINC is for
> 
> > * Pull in the base interface file from oe-core
> 
> Completely unneeded

I actually prefer that the first commit move in the base file he
is modifying and then have the second commit make his changes.
It is much easier to understand what change he was making to the
base file and why he needing to overlay it.

> 
> > * Update to use the new syntax for extending the file search
> path
> 
> Patch 2:
> 
> > Update interface file based on changes made to the interface
> file
>   in arago
> 
> THe interfaces file is supposed to be machine specific, so a "one
> file to rule them all" is completely unacceptable in meta-ti. If
> you want to go such a route, do it in meta-arago. Even so, I
> strongly recommend against that.
> 
> Op 1 aug. 2012, om 21:07 heeft "Cooper Jr., Franklin"
> <fcooper@ti.com> het volgende geschreven:
> 
> > Attached patches are for porting the netbase interface file
> used in arago/oe-classic to meta-ti.
> >
> > The difference between my interfaces file and the one in
> beagleboard directory seems very minor. Would it be ok to combine
> the changes from both files into a single file? The auto usb0
> looks like it might be an issue if we combined the two files.
> Would it make sense to append that line to the interface file
> during do_install_append step only for the beagleboard platform
> and consolidate the rest of the differences?
> >
> > diff beagleboard/interfaces interfaces
> > 13a14,17
> > > iface tiwlan0 inet dhcp
> > >    wireless_mode managed
> > >    wireless_essid any
> > >
> > 18a23,24
> > >         pre-up /bin/grep -v -e "ip=[0-9]\+\.[0-9]\+\.[0-
> 9]\+\.[0-9]\+" /proc/cmdline > /dev/null
> > >
> > 21,22c27,28
> > < # Ethernet/RNDIS gadget (g_ether) or LAN9514 on BeagleBoard
> xM
> > < auto usb0
> > ---
> > > # Ethernet/RNDIS gadget (g_ether)
> > > # ... or on host side, usbnet and random hwaddr
> >
> >
> > Regards,
> > Franklin Cooper Jr.
> > Texas Instruments
> > Application Engineer
> > fcooper@ti.com
> >
> > <0001-netbase-Add-base-interface-file.patch><0002-netbase-
> Update-interface-
> file.patch>_______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
> 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti

Re: [branch: master][PATCHES] Porting netbase interfaces file from oe-classic

[Koen Kooi]

Op 2 aug. 2012, om 16:53 heeft "Maupin, Chase" <chase.maupin@ti.com> het volgende geschreven:

>> -----Original Message-----
>> From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
>> bounces@yoctoproject.org] On Behalf Of Koen Kooi
>> Sent: Wednesday, August 01, 2012 10:59 PM
>> To: Cooper Jr., Franklin
>> Cc: meta-ti@yoctoproject.org
>> Subject: Re: [meta-ti] [branch: master][PATCHES] Porting netbase
>> interfaces file from oe-classic
>> 
>> Please send patches inline to make review easier.
>> 
>> Patch 1:
>> 
>>> * Add PR_append
>> 
>> Don't do that, that's what PRINC is for
>> 
>>> * Pull in the base interface file from oe-core
>> 
>> Completely unneeded
> 
> I actually prefer that the first commit move in the base file he
> is modifying and then have the second commit make his changes.
> It is much easier to understand what change he was making to the
> base file and why he needing to overlay it.

My point is that you're now *globally* modifying basefiles for *all* machines, including non-TI ones as soon as you have meta-ti in the layer stack, which is unacceptable. If you really want a catch-all interfaces file, put it in meta-arago.

Re: [branch: master][PATCHES] Porting netbase interfaces file from oe-classic

[Denys Dmytriyenko]

On Thu, Aug 02, 2012 at 05:07:36PM +0200, Koen Kooi wrote:
> 
> Op 2 aug. 2012, om 16:53 heeft "Maupin, Chase" <chase.maupin@ti.com> het volgende geschreven:
> 
> >> -----Original Message-----
> >> From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> >> bounces@yoctoproject.org] On Behalf Of Koen Kooi
> >> Sent: Wednesday, August 01, 2012 10:59 PM
> >> To: Cooper Jr., Franklin
> >> Cc: meta-ti@yoctoproject.org
> >> Subject: Re: [meta-ti] [branch: master][PATCHES] Porting netbase
> >> interfaces file from oe-classic
> >> 
> >> Please send patches inline to make review easier.
> >> 
> >> Patch 1:
> >> 
> >>> * Add PR_append
> >> 
> >> Don't do that, that's what PRINC is for
> >> 
> >>> * Pull in the base interface file from oe-core
> >> 
> >> Completely unneeded
> > 
> > I actually prefer that the first commit move in the base file he
> > is modifying and then have the second commit make his changes.
> > It is much easier to understand what change he was making to the
> > base file and why he needing to overlay it.
> 
> My point is that you're now *globally* modifying basefiles for *all* 
> machines, including non-TI ones as soon as you have meta-ti in the layer 
> stack, which is unacceptable. If you really want a catch-all interfaces 
> file, put it in meta-arago.

FYI, after discussing this internally, we agreed to not modify basefiles 
globally, but rather provide SOC-specific version where possible, or even 
machine-specific, when needed. In this particular case, we'll have a 
ti33x-specific interfaces file, which will be overwritten by 
beaglebone-specific one. PRINC should also be used in meta-ti bbappends.

Franklin, will you be resending the updated patch?

-- 
Denys