From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
brcm80211-dev-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
frankyl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: How to get the irq flags from the dts file
Date: Thu, 9 Aug 2012 11:48:42 +0000 [thread overview]
Message-ID: <201208091148.42748.arnd@arndb.de> (raw)
In-Reply-To: <1344509006.2295.148.camel@tegra-chromium-2>
On Thursday 09 August 2012, Wei Ni wrote:
> In the wlan driver, it will use platform_get_resource() to get the
> res->irq, res->flags, the irq number is right, but the flags will be
> IORESOURCE_IRQ, not the 0x04 (IRQF_TRIGGER_HIGH).
> The wlan driver wish this flags include the IRQF_TRGGER_* information,
> and it will use this flags to configure other hw settings. If it is
> wrong, the wlan can't work.
>
> I checked drivers/of/irq.c, in function of_irq_to_resource(), it will
> set r->flags = IORESOURCE_IRQ directly, not read the flags from the dtb
> file. And I didn't find any of_xx api to get this flags.
>
> How can I get this flags, does anyone has suggestion?
The driver should not need to know about thie flag. It gets read
by irq_create_of_mapping when calling teh xlate function and
gets set using irq_set_irq_type from there too.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Wei Ni <wni@nvidia.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
frankyl@broadcom.com, brcm80211-dev-list@broadcom.com,
devicetree-discuss@lists.ozlabs.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: How to get the irq flags from the dts file
Date: Thu, 9 Aug 2012 11:48:42 +0000 [thread overview]
Message-ID: <201208091148.42748.arnd@arndb.de> (raw)
In-Reply-To: <1344509006.2295.148.camel@tegra-chromium-2>
On Thursday 09 August 2012, Wei Ni wrote:
> In the wlan driver, it will use platform_get_resource() to get the
> res->irq, res->flags, the irq number is right, but the flags will be
> IORESOURCE_IRQ, not the 0x04 (IRQF_TRIGGER_HIGH).
> The wlan driver wish this flags include the IRQF_TRGGER_* information,
> and it will use this flags to configure other hw settings. If it is
> wrong, the wlan can't work.
>
> I checked drivers/of/irq.c, in function of_irq_to_resource(), it will
> set r->flags = IORESOURCE_IRQ directly, not read the flags from the dtb
> file. And I didn't find any of_xx api to get this flags.
>
> How can I get this flags, does anyone has suggestion?
The driver should not need to know about thie flag. It gets read
by irq_create_of_mapping when calling teh xlate function and
gets set using irq_set_irq_type from there too.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: How to get the irq flags from the dts file
Date: Thu, 9 Aug 2012 11:48:42 +0000 [thread overview]
Message-ID: <201208091148.42748.arnd@arndb.de> (raw)
In-Reply-To: <1344509006.2295.148.camel@tegra-chromium-2>
On Thursday 09 August 2012, Wei Ni wrote:
> In the wlan driver, it will use platform_get_resource() to get the
> res->irq, res->flags, the irq number is right, but the flags will be
> IORESOURCE_IRQ, not the 0x04 (IRQF_TRIGGER_HIGH).
> The wlan driver wish this flags include the IRQF_TRGGER_* information,
> and it will use this flags to configure other hw settings. If it is
> wrong, the wlan can't work.
>
> I checked drivers/of/irq.c, in function of_irq_to_resource(), it will
> set r->flags = IORESOURCE_IRQ directly, not read the flags from the dtb
> file. And I didn't find any of_xx api to get this flags.
>
> How can I get this flags, does anyone has suggestion?
The driver should not need to know about thie flag. It gets read
by irq_create_of_mapping when calling teh xlate function and
gets set using irq_set_irq_type from there too.
Arnd
next prev parent reply other threads:[~2012-08-09 11:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 10:43 How to get the irq flags from the dts file Wei Ni
2012-08-09 10:43 ` Wei Ni
2012-08-09 10:43 ` Wei Ni
2012-08-09 11:48 ` Arnd Bergmann [this message]
2012-08-09 11:48 ` Arnd Bergmann
2012-08-09 11:48 ` Arnd Bergmann
[not found] ` <201208091148.42748.arnd-r2nGTMty4D4@public.gmane.org>
2012-08-09 12:05 ` Mark Brown
2012-08-09 12:05 ` Mark Brown
2012-08-09 12:05 ` Mark Brown
[not found] ` <20120809120530.GC8474-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-08-10 9:11 ` Wei Ni
2012-08-10 9:11 ` Wei Ni
2012-08-10 9:11 ` Wei Ni
2012-08-09 12:09 ` Arend van Spriel
2012-08-09 12:09 ` Arend van Spriel
2012-08-09 12:09 ` Arend van Spriel
[not found] ` <5023A88F.8040402-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2012-08-10 9:14 ` Wei Ni
2012-08-10 9:14 ` Wei Ni
2012-08-10 9:14 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208091148.42748.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=brcm80211-dev-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=frankyl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.