* [patch] [media] qt1010: signedness bug in qt1010_init_meas1()
@ 2012-08-10 9:25 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-08-10 9:25 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Antti Palosaari, linux-media, kernel-janitors
qt1010_init_meas2() returns zero on success and negative error codes on
failure so the return type should be int instead of u8.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/common/tuners/qt1010.c b/drivers/media/common/tuners/qt1010.c
index 2d79b1f..bdc39e1 100644
--- a/drivers/media/common/tuners/qt1010.c
+++ b/drivers/media/common/tuners/qt1010.c
@@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv,
return qt1010_writereg(priv, 0x1e, 0x00);
}
-static u8 qt1010_init_meas2(struct qt1010_priv *priv,
+static int qt1010_init_meas2(struct qt1010_priv *priv,
u8 reg_init_val, u8 *retval)
{
u8 i, val;
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] [media] qt1010: signedness bug in qt1010_init_meas1()
@ 2012-08-10 9:25 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-08-10 9:25 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Antti Palosaari, linux-media, kernel-janitors
qt1010_init_meas2() returns zero on success and negative error codes on
failure so the return type should be int instead of u8.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/common/tuners/qt1010.c b/drivers/media/common/tuners/qt1010.c
index 2d79b1f..bdc39e1 100644
--- a/drivers/media/common/tuners/qt1010.c
+++ b/drivers/media/common/tuners/qt1010.c
@@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv,
return qt1010_writereg(priv, 0x1e, 0x00);
}
-static u8 qt1010_init_meas2(struct qt1010_priv *priv,
+static int qt1010_init_meas2(struct qt1010_priv *priv,
u8 reg_init_val, u8 *retval)
{
u8 i, val;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] [media] qt1010: signedness bug in qt1010_init_meas1()
2012-08-10 9:25 ` Dan Carpenter
@ 2012-08-10 10:26 ` Antti Palosaari
-1 siblings, 0 replies; 4+ messages in thread
From: Antti Palosaari @ 2012-08-10 10:26 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
On 08/10/2012 12:25 PM, Dan Carpenter wrote:
> qt1010_init_meas2() returns zero on success and negative error codes on
> failure so the return type should be int instead of u8.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Antti Palosaari <crope@iki.fi>
>
> diff --git a/drivers/media/common/tuners/qt1010.c b/drivers/media/common/tuners/qt1010.c
> index 2d79b1f..bdc39e1 100644
> --- a/drivers/media/common/tuners/qt1010.c
> +++ b/drivers/media/common/tuners/qt1010.c
> @@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv,
> return qt1010_writereg(priv, 0x1e, 0x00);
> }
>
> -static u8 qt1010_init_meas2(struct qt1010_priv *priv,
> +static int qt1010_init_meas2(struct qt1010_priv *priv,
> u8 reg_init_val, u8 *retval)
> {
> u8 i, val;
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] [media] qt1010: signedness bug in qt1010_init_meas1()
@ 2012-08-10 10:26 ` Antti Palosaari
0 siblings, 0 replies; 4+ messages in thread
From: Antti Palosaari @ 2012-08-10 10:26 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
On 08/10/2012 12:25 PM, Dan Carpenter wrote:
> qt1010_init_meas2() returns zero on success and negative error codes on
> failure so the return type should be int instead of u8.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Antti Palosaari <crope@iki.fi>
>
> diff --git a/drivers/media/common/tuners/qt1010.c b/drivers/media/common/tuners/qt1010.c
> index 2d79b1f..bdc39e1 100644
> --- a/drivers/media/common/tuners/qt1010.c
> +++ b/drivers/media/common/tuners/qt1010.c
> @@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv,
> return qt1010_writereg(priv, 0x1e, 0x00);
> }
>
> -static u8 qt1010_init_meas2(struct qt1010_priv *priv,
> +static int qt1010_init_meas2(struct qt1010_priv *priv,
> u8 reg_init_val, u8 *retval)
> {
> u8 i, val;
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-10 10:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-10 9:25 [patch] [media] qt1010: signedness bug in qt1010_init_meas1() Dan Carpenter
2012-08-10 9:25 ` Dan Carpenter
2012-08-10 10:26 ` Antti Palosaari
2012-08-10 10:26 ` Antti Palosaari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.