[PATCH] MIPS: init module specific mips_hi16_list to NULL

[PATCH] MIPS: init module specific mips_hi16_list to NULL

[Tony Wu]

MIPS: init module specific mips_hi16_list to NULL

mips_hi16_list was moved from global to mod_arch_specific. While
global, it was bss initialized automatically, when moved to
mod_arch_specific, we have to do the zero initialization.

Signed-off-by: Tony Wu <tung7970@gmail.com>
---
 arch/mips/kernel/module.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/mips/kernel/module.c b/arch/mips/kernel/module.c
index 8b29976..8e1fb80 100644
--- a/arch/mips/kernel/module.c
+++ b/arch/mips/kernel/module.c
@@ -276,6 +276,7 @@ int apply_relocate(Elf_Shdr *sechdrs, const char *strtab,
 	pr_debug("Applying relocate section %u to %u\n", relsec,
 	       sechdrs[relsec].sh_info);
 
+	me->arch.r_mips_hi16_list = NULL;
 	for (i = 0; i < sechdrs[relsec].sh_size / sizeof(*rel); i++) {
 		/* This is where to make the change */
 		location = (void *)sechdrs[sechdrs[relsec].sh_info].sh_addr
-- 
1.7.4.4

Re: [PATCH] MIPS: init module specific mips_hi16_list to NULL

[John Crispin]

On 10/08/12 12:33, Tony Wu wrote:
> MIPS: init module specific mips_hi16_list to NULL
> 
> mips_hi16_list was moved from global to mod_arch_specific. While
> global, it was bss initialized automatically, when moved to
> mod_arch_specific, we have to do the zero initialization.
> 
> Signed-off-by: Tony Wu <tung7970@gmail.com>


Hi Tony,

can you reference the offending commit that caused the regression inside
the patches description please ...

John