From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Liam Girdwood <lrg@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators
Date: Fri, 10 Aug 2012 13:29:03 +0100 [thread overview]
Message-ID: <20120810122903.GJ24328@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAF+7xWmmuf0bSROpvd+2RW-XFV=_nf6Zu3KC9-hW2rWDwVwncg@mail.gmail.com>
On Fri, Aug 10, 2012 at 08:27:32PM +0800, Axel Lin wrote:
> 2012/8/10 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> > We should be failing to register these regulators in the first place, or
> > at least complaining extremely loudly about them.
> Oh. My original intention is to prevent using list_voltage() to read
> voltage regulators for the case "n_voltages > 1" in case of both get_voltage
> and get_voltage_sel are not implemented.
Yes, I see the intention - what I'm saying is that a regulator like that
makes no sense in the first place.
next prev parent reply other threads:[~2012-08-10 12:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 1:32 [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators Axel Lin
2012-08-10 1:33 ` [PATCH 2/6] regulator: ab3100: Remove get_voltage implementation for regulator_ops_fixed Axel Lin
2012-08-13 12:31 ` Mark Brown
2012-08-10 1:34 ` [PATCH 3/6] regulator: ab8500: Remove get_voltage implementation for ab8500_regulator_fixed_ops Axel Lin
2012-08-10 1:35 ` [PATCH 4/6] regulator: isl6271a: Remove get_voltage implementation for isl_fixed_ops Axel Lin
2012-08-10 1:37 ` [PATCH 5/6] regulator: twl: Remove get_voltage implementation for single voltage regulators Axel Lin
2012-08-10 1:38 ` [PATCH 6/6] regulator: mc13xxx: " Axel Lin
2012-08-10 10:05 ` [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read " Mark Brown
2012-08-10 12:27 ` Axel Lin
2012-08-10 12:29 ` Mark Brown [this message]
2012-08-11 2:22 ` Axel Lin
2012-08-13 12:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120810122903.GJ24328@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.