From: Marek Vasut <marex@denx.de>
To: Huang Shijie <shijie8@gmail.com>
Cc: fabio.estevam@freescale.com, dedekind1@gmail.com,
stable@vger.kernel.org, linux-mtd@lists.infradead.org,
shawn.guo@linaro.org, dwmw2@infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] mtd: gpmi: add NAND write verify support
Date: Sat, 11 Aug 2012 14:47:17 +0200 [thread overview]
Message-ID: <201208111447.18076.marex@denx.de> (raw)
In-Reply-To: <CAMiH66GbOYDpo-RDUct2nCixaf+9vhmT8Ouz+YPx95Z1+g2B1Q@mail.gmail.com>
Dear Huang Shijie,
> On Sat, Aug 11, 2012 at 3:13 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Huang Shijie,
> >
> > Please re-add credit to Fabio. Also, Fabio fixed the subject to be more
>
> sorry. Should I add "Reported by : Fabio ...." to the patch?
Yes, at least.
> I really appriaciate Fabio's work, but I do not think Fabio's patch is
> more accurate.
> The nand chips can be 2K page, 4K page and 8K page. But most of the
> time, the nand chip is 4K page.
> If we fix the verify_buf to 8K size as Fabio's patch does. It will
> waste much memory.
> This is my concern now. :)
That's all right, but the rest of your patch is Fabio's work, correct me if I'm
wrong. Just give the guy some credit, he found the flaw and diag'd it.
> My patch maybe not good. So If Fabio also sends out a new patch which
> allocates the verify_buf with the mtd->writesize size.
> I will ack it.
Either way is OK.
[...]
> > Best regards,
> > Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] mtd: gpmi: add NAND write verify support
Date: Sat, 11 Aug 2012 14:47:17 +0200 [thread overview]
Message-ID: <201208111447.18076.marex@denx.de> (raw)
In-Reply-To: <CAMiH66GbOYDpo-RDUct2nCixaf+9vhmT8Ouz+YPx95Z1+g2B1Q@mail.gmail.com>
Dear Huang Shijie,
> On Sat, Aug 11, 2012 at 3:13 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Huang Shijie,
> >
> > Please re-add credit to Fabio. Also, Fabio fixed the subject to be more
>
> sorry. Should I add "Reported by : Fabio ...." to the patch?
Yes, at least.
> I really appriaciate Fabio's work, but I do not think Fabio's patch is
> more accurate.
> The nand chips can be 2K page, 4K page and 8K page. But most of the
> time, the nand chip is 4K page.
> If we fix the verify_buf to 8K size as Fabio's patch does. It will
> waste much memory.
> This is my concern now. :)
That's all right, but the rest of your patch is Fabio's work, correct me if I'm
wrong. Just give the guy some credit, he found the flaw and diag'd it.
> My patch maybe not good. So If Fabio also sends out a new patch which
> allocates the verify_buf with the mtd->writesize size.
> I will ack it.
Either way is OK.
[...]
> > Best regards,
> > Marek Vasut
next prev parent reply other threads:[~2012-08-11 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-11 15:50 [PATCH v3] mtd: gpmi: add NAND write verify support Huang Shijie
2012-08-11 15:50 ` Huang Shijie
2012-08-11 7:13 ` Marek Vasut
2012-08-11 7:13 ` Marek Vasut
2012-08-11 9:25 ` Huang Shijie
2012-08-11 9:25 ` Huang Shijie
2012-08-11 12:47 ` Marek Vasut [this message]
2012-08-11 12:47 ` Marek Vasut
2012-08-11 13:56 ` Huang Shijie
2012-08-11 13:56 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208111447.18076.marex@denx.de \
--to=marex@denx.de \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shawn.guo@linaro.org \
--cc=shijie8@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.