From: cavokz@gmail.com (Domenico Andreoli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] CS89x0 : Use ioread16/iowrite16 on all platforms
Date: Sun, 12 Aug 2012 13:24:33 +0200 [thread overview]
Message-ID: <20120812112433.GA31699@glitch> (raw)
In-Reply-To: <20120517.190346.175685939436302276.davem@davemloft.net>
On Thu, May 17, 2012 at 07:03:46PM -0400, David Miller wrote:
> From: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
> Date: Thu, 17 May 2012 19:11:42 +0200
>
> > The use of the inw/outw functions by the cs89x0 platform driver
> > results in NULL pointer references on ARM platforms and
> > platforms that do not provide ISA-style programmed I/O accessors.
> >
> > Using inw/outw also accesses the wrong address space on platforms
> > that have a PCI I/O space that is not identity-mapped into the
> > physical address space.
> >
> > Signed-off-by: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
>
> I could nit-pick more on this patch, but it's such a significant
> improvement I'm just going to apply this V3 as-is to net-next.
Is this going into v3.6 or v3.7?
cheers,
Domenico
WARNING: multiple messages have this Message-ID (diff)
From: Domenico Andreoli <cavokz@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: jaccon.bastiaansen@gmail.com, arnd@arndb.de,
netdev@vger.kernel.org, s.hauer@pengutronix.de,
romieu@fr.zoreil.com, joe@perches.com, gfm@funxed.com,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3] CS89x0 : Use ioread16/iowrite16 on all platforms
Date: Sun, 12 Aug 2012 13:24:33 +0200 [thread overview]
Message-ID: <20120812112433.GA31699@glitch> (raw)
In-Reply-To: <20120517.190346.175685939436302276.davem@davemloft.net>
On Thu, May 17, 2012 at 07:03:46PM -0400, David Miller wrote:
> From: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
> Date: Thu, 17 May 2012 19:11:42 +0200
>
> > The use of the inw/outw functions by the cs89x0 platform driver
> > results in NULL pointer references on ARM platforms and
> > platforms that do not provide ISA-style programmed I/O accessors.
> >
> > Using inw/outw also accesses the wrong address space on platforms
> > that have a PCI I/O space that is not identity-mapped into the
> > physical address space.
> >
> > Signed-off-by: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
>
> I could nit-pick more on this patch, but it's such a significant
> improvement I'm just going to apply this V3 as-is to net-next.
Is this going into v3.6 or v3.7?
cheers,
Domenico
next prev parent reply other threads:[~2012-08-12 11:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 17:11 [PATCH V3] CS89x0 : Use ioread16/iowrite16 on all platforms Jaccon Bastiaansen
2012-05-17 17:11 ` Jaccon Bastiaansen
2012-05-17 23:03 ` David Miller
2012-05-17 23:03 ` David Miller
2012-08-12 11:24 ` Domenico Andreoli [this message]
2012-08-12 11:24 ` Domenico Andreoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120812112433.GA31699@glitch \
--to=cavokz@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.