From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Borislav Petkov <bp@alien8.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Jan Beulich <JBeulich@suse.com>, Andi Kleen <ak@linux.intel.com>,
Andy Lutomirski <luto@amacapital.net>,
Robert Richter <robert.richter@amd.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>, Alex Shi <alex.shu@intel.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
x86@kernel.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mips@linux-mips.org, Tim Chen <tim.c.chen@linux.intel.com>,
linuxppc-dev@lists.ozlabs.org,
Andrea Arcangeli <aarcange@redhat.com>,
Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2 4/6] x86: Add clear_page_nocache
Date: Mon, 13 Aug 2012 22:07:43 +0300 [thread overview]
Message-ID: <20120813190743.GA10584@shutemov.name> (raw)
In-Reply-To: <20120813170402.GB15530@x1.osrc.amd.com>
On Mon, Aug 13, 2012 at 07:04:02PM +0200, Borislav Petkov wrote:
> On Mon, Aug 13, 2012 at 02:43:34PM +0300, Kirill A. Shutemov wrote:
> > $ cat test.c
> > #include <stdio.h>
> > #include <sys/mman.h>
> >
> > #define SIZE 1024*1024*1024
> >
> > void clear_page_nocache_sse2(void *page) __attribute__((regparm(1)));
> >
> > int main(int argc, char** argv)
> > {
> > char *p;
> > unsigned long i, j;
> >
> > p = mmap(NULL, SIZE, PROT_WRITE|PROT_READ,
> > MAP_PRIVATE|MAP_ANONYMOUS|MAP_POPULATE, -1, 0);
> > for(j = 0; j < 100; j++) {
> > for(i = 0; i < SIZE; i += 4096) {
> > clear_page_nocache_sse2(p + i);
> > }
> > }
> >
> > return 0;
> > }
> > $ cat clear_page_nocache_unroll32.S
> > .globl clear_page_nocache_sse2
> > .align 4,0x90
> > clear_page_nocache_sse2:
> > .cfi_startproc
> > mov %eax,%edx
> > xorl %eax,%eax
> > movl $4096/32,%ecx
> > .p2align 4
> > .Lloop_sse2:
> > decl %ecx
> > #define PUT(x) movnti %eax,x*4(%edx)
> > PUT(0)
> > PUT(1)
> > PUT(2)
> > PUT(3)
> > PUT(4)
> > PUT(5)
> > PUT(6)
> > PUT(7)
> > #undef PUT
> > lea 32(%edx),%edx
> > jnz .Lloop_sse2
> > nop
> > ret
> > .cfi_endproc
> > .type clear_page_nocache_sse2, @function
> > .size clear_page_nocache_sse2, .-clear_page_nocache_sse2
> > $ cat clear_page_nocache_unroll64.S
> > .globl clear_page_nocache_sse2
> > .align 4,0x90
> > clear_page_nocache_sse2:
> > .cfi_startproc
> > mov %eax,%edx
>
> This must still be the 32-bit version becaue it segfaults here.
Yes, it's test for 32-bit version.
--
Kirill A. Shutemov
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Borislav Petkov <bp@alien8.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Jan Beulich <JBeulich@suse.com>, Andi Kleen <ak@linux.intel.com>,
Andy Lutomirski <luto@amacapital.net>,
Robert Richter <robert.richter@amd.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>, Alex Shi <alex.shu@intel.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
x86@kernel.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mips@linux-mips.org, Tim Chen <tim.c.chen@linux.intel.com>,
linuxppc-dev@lists.ozlabs.org,
Andrea Arcangeli <aarcange@redhat.com>,
Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2 4/6] x86: Add clear_page_nocache
Date: Mon, 13 Aug 2012 19:07:43 +0000 [thread overview]
Message-ID: <20120813190743.GA10584@shutemov.name> (raw)
In-Reply-To: <20120813170402.GB15530@x1.osrc.amd.com>
On Mon, Aug 13, 2012 at 07:04:02PM +0200, Borislav Petkov wrote:
> On Mon, Aug 13, 2012 at 02:43:34PM +0300, Kirill A. Shutemov wrote:
> > $ cat test.c
> > #include <stdio.h>
> > #include <sys/mman.h>
> >
> > #define SIZE 1024*1024*1024
> >
> > void clear_page_nocache_sse2(void *page) __attribute__((regparm(1)));
> >
> > int main(int argc, char** argv)
> > {
> > char *p;
> > unsigned long i, j;
> >
> > p = mmap(NULL, SIZE, PROT_WRITE|PROT_READ,
> > MAP_PRIVATE|MAP_ANONYMOUS|MAP_POPULATE, -1, 0);
> > for(j = 0; j < 100; j++) {
> > for(i = 0; i < SIZE; i += 4096) {
> > clear_page_nocache_sse2(p + i);
> > }
> > }
> >
> > return 0;
> > }
> > $ cat clear_page_nocache_unroll32.S
> > .globl clear_page_nocache_sse2
> > .align 4,0x90
> > clear_page_nocache_sse2:
> > .cfi_startproc
> > mov %eax,%edx
> > xorl %eax,%eax
> > movl $4096/32,%ecx
> > .p2align 4
> > .Lloop_sse2:
> > decl %ecx
> > #define PUT(x) movnti %eax,x*4(%edx)
> > PUT(0)
> > PUT(1)
> > PUT(2)
> > PUT(3)
> > PUT(4)
> > PUT(5)
> > PUT(6)
> > PUT(7)
> > #undef PUT
> > lea 32(%edx),%edx
> > jnz .Lloop_sse2
> > nop
> > ret
> > .cfi_endproc
> > .type clear_page_nocache_sse2, @function
> > .size clear_page_nocache_sse2, .-clear_page_nocache_sse2
> > $ cat clear_page_nocache_unroll64.S
> > .globl clear_page_nocache_sse2
> > .align 4,0x90
> > clear_page_nocache_sse2:
> > .cfi_startproc
> > mov %eax,%edx
>
> This must still be the 32-bit version becaue it segfaults here.
Yes, it's test for 32-bit version.
--
Kirill A. Shutemov
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Borislav Petkov <bp@alien8.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Jan Beulich <JBeulich@suse.com>, Andi Kleen <ak@linux.intel.com>,
Andy Lutomirski <luto@amacapital.net>,
Robert Richter <robert.richter@amd.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>, Alex Shi <alex.shu@intel.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
x86@kernel.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mips@linux-mips.org, Tim Chen <tim.c.chen@linux.intel.com>,
linuxppc-dev@lists.ozlabs.org,
Andrea Arcangeli <aarcange@redhat.com>,
Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2 4/6] x86: Add clear_page_nocache
Date: Mon, 13 Aug 2012 22:07:43 +0300 [thread overview]
Message-ID: <20120813190743.GA10584@shutemov.name> (raw)
In-Reply-To: <20120813170402.GB15530@x1.osrc.amd.com>
On Mon, Aug 13, 2012 at 07:04:02PM +0200, Borislav Petkov wrote:
> On Mon, Aug 13, 2012 at 02:43:34PM +0300, Kirill A. Shutemov wrote:
> > $ cat test.c
> > #include <stdio.h>
> > #include <sys/mman.h>
> >
> > #define SIZE 1024*1024*1024
> >
> > void clear_page_nocache_sse2(void *page) __attribute__((regparm(1)));
> >
> > int main(int argc, char** argv)
> > {
> > char *p;
> > unsigned long i, j;
> >
> > p = mmap(NULL, SIZE, PROT_WRITE|PROT_READ,
> > MAP_PRIVATE|MAP_ANONYMOUS|MAP_POPULATE, -1, 0);
> > for(j = 0; j < 100; j++) {
> > for(i = 0; i < SIZE; i += 4096) {
> > clear_page_nocache_sse2(p + i);
> > }
> > }
> >
> > return 0;
> > }
> > $ cat clear_page_nocache_unroll32.S
> > .globl clear_page_nocache_sse2
> > .align 4,0x90
> > clear_page_nocache_sse2:
> > .cfi_startproc
> > mov %eax,%edx
> > xorl %eax,%eax
> > movl $4096/32,%ecx
> > .p2align 4
> > .Lloop_sse2:
> > decl %ecx
> > #define PUT(x) movnti %eax,x*4(%edx)
> > PUT(0)
> > PUT(1)
> > PUT(2)
> > PUT(3)
> > PUT(4)
> > PUT(5)
> > PUT(6)
> > PUT(7)
> > #undef PUT
> > lea 32(%edx),%edx
> > jnz .Lloop_sse2
> > nop
> > ret
> > .cfi_endproc
> > .type clear_page_nocache_sse2, @function
> > .size clear_page_nocache_sse2, .-clear_page_nocache_sse2
> > $ cat clear_page_nocache_unroll64.S
> > .globl clear_page_nocache_sse2
> > .align 4,0x90
> > clear_page_nocache_sse2:
> > .cfi_startproc
> > mov %eax,%edx
>
> This must still be the 32-bit version becaue it segfaults here.
Yes, it's test for 32-bit version.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-13 19:07 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 15:02 [PATCH v2 0/6] Avoid cache trashing on clearing huge/gigantic page Kirill A. Shutemov
2012-08-09 15:02 ` Kirill A. Shutemov
2012-08-09 15:02 ` Kirill A. Shutemov
2012-08-09 15:02 ` Kirill A. Shutemov
2012-08-09 15:02 ` [PATCH v2 1/6] THP: Use real address for NUMA policy Kirill A. Shutemov
2012-08-09 15:02 ` Kirill A. Shutemov
2012-08-09 15:02 ` Kirill A. Shutemov
2012-08-09 15:02 ` Kirill A. Shutemov
2012-08-09 15:02 ` [PATCH v2 2/6] mm: make clear_huge_page tolerate non aligned address Kirill A. Shutemov
2012-08-09 15:02 ` Kirill A. Shutemov
2012-08-09 15:02 ` Kirill A. Shutemov
2012-08-09 15:02 ` Kirill A. Shutemov
2012-08-09 15:03 ` [PATCH v2 3/6] THP: Pass real, not rounded, address to clear_huge_page Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:03 ` [PATCH v2 4/6] x86: Add clear_page_nocache Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:22 ` Jan Beulich
2012-08-09 15:22 ` Jan Beulich
2012-08-09 15:22 ` Jan Beulich
2012-08-09 15:22 ` Jan Beulich
2012-08-09 15:22 ` Jan Beulich
2012-08-09 15:26 ` Andi Kleen
2012-08-09 15:26 ` Andi Kleen
2012-08-13 11:43 ` Kirill A. Shutemov
2012-08-13 11:43 ` Kirill A. Shutemov
2012-08-13 11:43 ` Kirill A. Shutemov
2012-08-13 12:02 ` Jan Beulich
2012-08-13 12:02 ` Jan Beulich
2012-08-13 12:02 ` Jan Beulich
2012-08-13 12:02 ` Jan Beulich
2012-08-13 12:02 ` Jan Beulich
2012-08-13 16:27 ` Andi Kleen
2012-08-13 16:27 ` Andi Kleen
2012-08-13 16:27 ` Andi Kleen
2012-08-13 16:27 ` Andi Kleen
2012-08-13 17:04 ` Borislav Petkov
2012-08-13 17:04 ` Borislav Petkov
2012-08-13 17:04 ` Borislav Petkov
2012-08-13 17:04 ` Borislav Petkov
2012-08-13 19:07 ` Kirill A. Shutemov [this message]
2012-08-13 19:07 ` Kirill A. Shutemov
2012-08-13 19:07 ` Kirill A. Shutemov
2012-08-09 15:23 ` H. Peter Anvin
2012-08-09 15:23 ` H. Peter Anvin
2012-08-09 15:23 ` H. Peter Anvin
2012-08-09 15:23 ` H. Peter Anvin
2012-08-09 15:03 ` [PATCH v2 5/6] mm: make clear_huge_page cache clear only around the fault address Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:03 ` [PATCH v2 6/6] x86: switch the 64bit uncached page clear to SSE/AVX v2 Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:03 ` Kirill A. Shutemov
2012-08-09 15:28 ` Jan Beulich
2012-08-09 15:28 ` Jan Beulich
2012-08-09 15:28 ` Jan Beulich
2012-08-09 15:28 ` Jan Beulich
2012-08-09 15:28 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120813190743.GA10584@shutemov.name \
--to=kirill@shutemov.name \
--cc=JBeulich@suse.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shu@intel.com \
--cc=bp@alien8.de \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@amacapital.net \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=robert.richter@amd.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.