All of lore.kernel.org
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Tomoya MORINAGA <tomoya.rohm@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Axel Lin <axel.lin@gmail.com>
Subject: Re: [PATCH RFT 1/2] gpio: gpio-ml-ioh: Use spinlock for register access protection
Date: Tue, 14 Aug 2012 09:25:52 +0800	[thread overview]
Message-ID: <20120814092552.6e06305d@feng-i7> (raw)
In-Reply-To: <CACRpkdaLUCe8_cuYh_pq7HUKkWhaSXS6xEU=ZwbpoUcy9nCz4w@mail.gmail.com>

On Mon, 13 Aug 2012 14:01:31 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Sun, Jul 29, 2012 at 4:54 AM, Axel Lin <axel.lin@gmail.com> wrote:
> 
> > gpio_chip.can_sleep is 0, but current code uses mutex in ioh_gpio_set,
> > ioh_gpio_get and ioh_gpio_direction_input functions.
> > Thus those functions are not callable from interrupt context.
> > This patch converts mutex into spinlock.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> 
> So IOH guys what are you saying about this?

I'm not the IOH guy, but just happened to work on it for some time :) Anyway,
the 2 patches both look good to me.

Thanks,
Feng


  reply	other threads:[~2012-08-14  1:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-29  2:54 [PATCH RFT 1/2] gpio: gpio-ml-ioh: Use spinlock for register access protection Axel Lin
2012-07-29  2:55 ` [PATCH RFT 2/2] gpio: gpio-pch: " Axel Lin
2012-08-13 12:02   ` Linus Walleij
2012-08-14 22:20   ` Linus Walleij
2012-08-13 12:01 ` [PATCH RFT 1/2] gpio: gpio-ml-ioh: " Linus Walleij
2012-08-14  1:25   ` Feng Tang [this message]
2012-08-14 22:18 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120814092552.6e06305d@feng-i7 \
    --to=feng.tang@intel.com \
    --cc=axel.lin@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomoya.rohm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.