From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Richard Ems <richard.ems@cape-horn-eng.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: nfs_lookup_revalidate BUG ?
Date: Tue, 14 Aug 2012 19:35:12 +0100 [thread overview]
Message-ID: <20120814183512.GI23464@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4FA345DA4F4AE44899BD2B03EEEC2FA93A4848@SACEXCMBX04-PRD.hq.netapp.com>
On Tue, Aug 14, 2012 at 06:04:08PM +0000, Myklebust, Trond wrote:
> > Is this a known BUG ?
> > Which other information or test can I do to contribute searching/resolving this issue?
>
> I'm not 100% certain, but it looks to me as if the call to dget_parent()
> in nfs_lookup_revalidate is returning NULL.
>
> Could you please apply the following patch, and see if that triggers the
> WARN_ON instead of the above Oops?
Unlikely as hell. dget_parent() has only one return in it, and it's
BUG_ON(!ret->d_count);
ret->d_count++;
spin_unlock(&ret->d_lock);
return ret;
so it's extremely unlikely that it would managed to return NULL. Not
without oopsing...
next prev parent reply other threads:[~2012-08-14 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 10:00 nfs_lookup_revalidate BUG ? Richard Ems
2012-08-14 18:04 ` Myklebust, Trond
2012-08-14 18:35 ` Al Viro [this message]
2012-08-14 18:48 ` Myklebust, Trond
2012-08-14 19:11 ` Jeff Layton
2012-08-15 11:57 ` Richard Ems
2012-08-15 13:20 ` Myklebust, Trond
2012-08-15 13:22 ` Richard Ems
2012-08-15 13:38 ` Myklebust, Trond
2012-08-15 13:40 ` Richard Ems
2012-08-15 13:55 ` Myklebust, Trond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814183512.GI23464@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=richard.ems@cape-horn-eng.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.