From: Richard Ems <richard.ems@cape-horn-eng.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Jeff Layton <jlayton@redhat.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: nfs_lookup_revalidate BUG ?
Date: Wed, 15 Aug 2012 15:22:40 +0200 [thread overview]
Message-ID: <502BA2A0.6000208@cape-horn-eng.com> (raw)
In-Reply-To: <4FA345DA4F4AE44899BD2B03EEEC2FA93AB5CB@SACEXCMBX04-PRD.hq.netapp.com>
On 08/15/2012 03:20 PM, Myklebust, Trond wrote:
>> (gdb) list *(nfs_lookup_revalidate+0x2d)
>> 0x59cd is in nfs_lookup_revalidate (/usr/src/debug/kernel-default-3.5.1/linux-3.5/fs/nfs/dir.c:1129).
>> 1124 struct dentry *parent;
>> 1125 struct nfs_fh *fhandle = NULL;
>> 1126 struct nfs_fattr *fattr = NULL;
>> 1127 int error;
>> 1128
>> 1129 if (nd->flags & LOOKUP_RCU)
>
> Bummer... We check if 'nd' is NULL everywhere except here...
>
> OK. Changing the above line to
>
> if (nd && (nd->flags & LOOKUP_RCU))
>
> will fix the problem.
Ok, great !
Do you think this fix will go into 3.5.2 ?
Thanks again,
Richard
--
Richard Ems mail: Richard.Ems@Cape-Horn-Eng.com
Cape Horn Engineering S.L.
C/ Dr. J.J. Dómine 1, 5º piso
46011 Valencia
Tel : +34 96 3242923 / Fax 924
http://www.cape-horn-eng.com
next prev parent reply other threads:[~2012-08-15 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 10:00 nfs_lookup_revalidate BUG ? Richard Ems
2012-08-14 18:04 ` Myklebust, Trond
2012-08-14 18:35 ` Al Viro
2012-08-14 18:48 ` Myklebust, Trond
2012-08-14 19:11 ` Jeff Layton
2012-08-15 11:57 ` Richard Ems
2012-08-15 13:20 ` Myklebust, Trond
2012-08-15 13:22 ` Richard Ems [this message]
2012-08-15 13:38 ` Myklebust, Trond
2012-08-15 13:40 ` Richard Ems
2012-08-15 13:55 ` Myklebust, Trond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502BA2A0.6000208@cape-horn-eng.com \
--to=richard.ems@cape-horn-eng.com \
--cc=Trond.Myklebust@netapp.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.