Re: [PATCH v2 1/2] drivers/mfd: Add realtek pcie card reader driver

[Arnd Bergmann <arnd@arndb.de>]

On Tuesday 14 August 2012, wei_wang@realsil.com.cn wrote:
> +
> +void rtsx_pci_start_run(struct rtsx_pcr *pcr)
> +{
> +       /* If pci device removed, don't queue idle work any more */
> +       if (pcr->remove_pci)
> +               return;
> +
> +       if (pcr->state != PDEV_STAT_RUN) {
> +               pcr->state = PDEV_STAT_RUN;
> +               pcr->ops->enable_auto_blink(pcr);
> +       }
> +
> +       mod_timer(&pcr->idle_timer, jiffies + msecs_to_jiffies(200));
> +}
> +EXPORT_SYMBOL_GPL(rtsx_pci_start_run);

One more comment on the mod_timer/queue_work combination: I just saw that
Tejun Heo posted a series to introduce a new mod_delayed_work() helper.

Once that goes in, it would be best to start using it here.

	Arnd