[PATCH] MIPS: ath79: don't hardcode the unavailability of the DSP ASE

[PATCH] MIPS: ath79: don't hardcode the unavailability of the DSP ASE

[Gabor Juhos]

The ath79 platform code allows to run a single kernel image
on various SoCs which are based on the 24Kc and 74Kc cores.
The current code explicitely disables the DSP ASE, but that
is available in the 74Kc core.

Remove the override in order to let the kernel to detect the
availability of the DSP ASE at runtime.

Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

---
This is a replacement of the 'MIPS: ath79: don't override CPU ASE features' 
patch: https://patchwork.linux-mips.org/patch/4169/

I don't think that the issue is critical enough to include that in 
the stable trees.

Gabor

 arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h |    1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h b/arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h
index 4476fa0..6ddae92 100644
--- a/arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h
+++ b/arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h
@@ -42,7 +42,6 @@
 #define cpu_has_mips64r1	0
 #define cpu_has_mips64r2	0
 
-#define cpu_has_dsp		0
 #define cpu_has_mipsmt		0
 
 #define cpu_has_64bits		0
-- 
1.7.10

Re: [PATCH] MIPS: ath79: don't hardcode the unavailability of the DSP ASE

[Ralf Baechle]

On Tue, Aug 14, 2012 at 09:12:21PM +0200, Gabor Juhos wrote:

> The ath79 platform code allows to run a single kernel image
> on various SoCs which are based on the 24Kc and 74Kc cores.
> The current code explicitely disables the DSP ASE, but that
> is available in the 74Kc core.
> 
> Remove the override in order to let the kernel to detect the
> availability of the DSP ASE at runtime.
> 
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
> 
> ---
> This is a replacement of the 'MIPS: ath79: don't override CPU ASE features' 
> patch: https://patchwork.linux-mips.org/patch/4169/
> 
> I don't think that the issue is critical enough to include that in 
> the stable trees.

But it's also trivial.  Anyway, the effect of this "bug" is that the DSP
ASE is not available and apparently this has not yet shown up on anybody's
radar.

Anyway, applied!  Thanks!

  Ralf

Re: [PATCH] MIPS: ath79: don't hardcode the unavailability of the DSP ASE

[Helmut Schaa]

Hi Ralf,

On Wed, Aug 15, 2012 at 12:48 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Tue, Aug 14, 2012 at 09:12:21PM +0200, Gabor Juhos wrote:
>
>> The ath79 platform code allows to run a single kernel image
>> on various SoCs which are based on the 24Kc and 74Kc cores.
>> The current code explicitely disables the DSP ASE, but that
>> is available in the 74Kc core.
>>
>> Remove the override in order to let the kernel to detect the
>> availability of the DSP ASE at runtime.
>>
>> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
>>
>> ---
>> This is a replacement of the 'MIPS: ath79: don't override CPU ASE features'
>> patch: https://patchwork.linux-mips.org/patch/4169/
>>
>> I don't think that the issue is critical enough to include that in
>> the stable trees.
>
> But it's also trivial.  Anyway, the effect of this "bug" is that the DSP
> ASE is not available and apparently this has not yet shown up on anybody's
> radar.
>
> Anyway, applied!  Thanks!

This change somehow didn't make it into the offical kernel releases due to
"MIPS: Hardwire detection of DSP ASE Rev 2 for systems, as required."
which basically reverted this change again.

Was this intentional?

Just noticed while booting 3.10 on a AR9344 SoC ...

Thanks,
Helmut