All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Michael Cree <mcree@orcon.net.nz>,
	linux-alpha@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>, Tony Luck <tony.luck@gmail.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	John David Anglin <dave.anglin@bell.net>,
	Mel Gorman <mgorman@suse.de>,
	kernel-janitors@vger.kernel.org,
	Kyle McMartin <kyle@parisc-linux.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Parisc List <linux-parisc@vger.kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH] [ALPHA] Redefine ATOMIC_INIT and ATOMIC64_INIT to drop the casts
Date: Wed, 15 Aug 2012 22:03:28 +0000	[thread overview]
Message-ID: <20120815150328.e1fb3676.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120812021405.GB8442@localhost>

On Sun, 12 Aug 2012 10:14:05 +0800
Fengguang Wu <fengguang.wu@intel.com> wrote:

> From: Mel Gorman <mgorman@suse.de>
> 
> The following build error occurred during an alpha build:
> 
> net/core/sock.c:274:36: error: initializer element is not constant
> 
> Dave Anglin says:
> > Here is the line in sock.i:
> >
> > struct static_key memalloc_socks = ((struct static_key) { .enabled > > ((atomic_t) { (0) }) });
> 
> The above line contains two compound literals.  It also uses a designated
> initializer to initialize the field enabled.  A compound literal is not a
> constant expression.
> 
> The location of the above statement isn't fully clear, but if a compound
> literal occurs outside the body of a function, the initializer list must
> consist of constant expressions.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

I'll remvoe the Cc:stable from this one - the regression is post-3.5.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Michael Cree <mcree@orcon.net.nz>,
	linux-alpha@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>, Tony Luck <tony.luck@gmail.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	John David Anglin <dave.anglin@bell.net>,
	Mel Gorman <mgorman@suse.de>,
	kernel-janitors@vger.kernel.org,
	Kyle McMartin <kyle@parisc-linux.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Parisc List <linux-parisc@vger.kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH] [ALPHA] Redefine ATOMIC_INIT and ATOMIC64_INIT to drop the casts
Date: Wed, 15 Aug 2012 15:03:28 -0700	[thread overview]
Message-ID: <20120815150328.e1fb3676.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120812021405.GB8442@localhost>

On Sun, 12 Aug 2012 10:14:05 +0800
Fengguang Wu <fengguang.wu@intel.com> wrote:

> From: Mel Gorman <mgorman@suse.de>
> 
> The following build error occurred during an alpha build:
> 
> net/core/sock.c:274:36: error: initializer element is not constant
> 
> Dave Anglin says:
> > Here is the line in sock.i:
> >
> > struct static_key memalloc_socks = ((struct static_key) { .enabled =
> > ((atomic_t) { (0) }) });
> 
> The above line contains two compound literals.  It also uses a designated
> initializer to initialize the field enabled.  A compound literal is not a
> constant expression.
> 
> The location of the above statement isn't fully clear, but if a compound
> literal occurs outside the body of a function, the initializer list must
> consist of constant expressions.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

I'll remvoe the Cc:stable from this one - the regression is post-3.5.

  reply	other threads:[~2012-08-15 22:03 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-22 16:30 [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant Fengguang Wu
2012-07-22 16:30 ` Fengguang Wu
2012-07-23 11:16 ` Mel Gorman
2012-07-23 11:16   ` Mel Gorman
2012-07-23 11:20   ` James Bottomley
2012-07-23 11:20     ` James Bottomley
2012-07-23 11:42     ` Mel Gorman
2012-07-23 11:42       ` Mel Gorman
2012-07-23 12:29       ` Fengguang Wu
2012-07-23 12:29         ` Fengguang Wu
2012-07-23 15:13         ` John David Anglin
2012-07-23 15:13           ` John David Anglin
2012-07-24  7:48           ` Fengguang Wu
2012-07-24  7:48             ` Fengguang Wu
2012-07-24 21:08             ` John David Anglin
2012-07-24 21:08               ` John David Anglin
2012-07-25  5:10               ` James Bottomley
2012-07-25  5:10                 ` James Bottomley
2012-07-26 17:06                 ` Tony Luck
2012-07-26 17:06                   ` Tony Luck
2012-08-02 15:02                   ` Fengguang Wu
2012-08-02 15:02                     ` Fengguang Wu
2012-08-12  1:33                     ` Michael Cree
2012-08-12  1:33                       ` Michael Cree
2012-08-12  2:10                       ` Fengguang Wu
2012-08-12  2:10                         ` Fengguang Wu
2012-08-12  2:42                         ` Michael Cree
2012-08-12  2:42                           ` Michael Cree
2012-08-12 13:00                           ` John David Anglin
2012-08-12 13:00                             ` John David Anglin
2012-08-12  2:14                       ` [PATCH] [ALPHA] Redefine ATOMIC_INIT and ATOMIC64_INIT to drop the casts Fengguang Wu
2012-08-12  2:14                         ` Fengguang Wu
2012-08-15 22:03                         ` Andrew Morton [this message]
2012-08-15 22:03                           ` Andrew Morton
2012-07-25  8:27               ` [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant Mel Gorman
2012-07-25  8:27                 ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120815150328.e1fb3676.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=dave.anglin@bell.net \
    --cc=davem@davemloft.net \
    --cc=fengguang.wu@intel.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kyle@parisc-linux.org \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=mcree@orcon.net.nz \
    --cc=mgorman@suse.de \
    --cc=rth@twiddle.net \
    --cc=tony.luck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.