From: Arnd Bergmann <arnd@arndb.de>
To: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
Cc: Roland Stigge <stigge@antcom.de>,
srinivas.bakki@nxp.com, artem.bityutskiy@linux.intel.com,
linux-kernel@vger.kernel.org, kevin.wells@nxp.com,
linux-mtd@lists.infradead.org, aletes.xgr@gmail.com,
dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dma: amba-pl08x: Export pl08x_filter_id
Date: Thu, 16 Aug 2012 09:06:21 +0000 [thread overview]
Message-ID: <201208160906.21950.arnd@arndb.de> (raw)
In-Reply-To: <20120816090041.GK18957@n2100.arm.linux.org.uk>
On Thursday 16 August 2012, Russell King - ARM Linux wrote:
> On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
> > This patch fixes the following when compiling a driver module that uses
> > amba-pl08x:
> >
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> >
> > (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
>
> It is currently intended that this be passed from platform code into
> drivers via platform data, so that drivers can decide which DMA engine
> they wish to make use of.
>
> See how all the AMBA drivers work in this regard (because they need to
> support more than just a single DMA engine implementation.)
Ah, you're right, I forgot about that. I'll take back my Ack then.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: amba-pl08x: Export pl08x_filter_id
Date: Thu, 16 Aug 2012 09:06:21 +0000 [thread overview]
Message-ID: <201208160906.21950.arnd@arndb.de> (raw)
In-Reply-To: <20120816090041.GK18957@n2100.arm.linux.org.uk>
On Thursday 16 August 2012, Russell King - ARM Linux wrote:
> On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
> > This patch fixes the following when compiling a driver module that uses
> > amba-pl08x:
> >
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> >
> > (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
>
> It is currently intended that this be passed from platform code into
> drivers via platform data, so that drivers can decide which DMA engine
> they wish to make use of.
>
> See how all the AMBA drivers work in this regard (because they need to
> support more than just a single DMA engine implementation.)
Ah, you're right, I forgot about that. I'll take back my Ack then.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
Cc: Roland Stigge <stigge@antcom.de>,
artem.bityutskiy@linux.intel.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kevin.wells@nxp.com,
srinivas.bakki@nxp.com, aletes.xgr@gmail.com,
dwmw2@infradead.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] dma: amba-pl08x: Export pl08x_filter_id
Date: Thu, 16 Aug 2012 09:06:21 +0000 [thread overview]
Message-ID: <201208160906.21950.arnd@arndb.de> (raw)
In-Reply-To: <20120816090041.GK18957@n2100.arm.linux.org.uk>
On Thursday 16 August 2012, Russell King - ARM Linux wrote:
> On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
> > This patch fixes the following when compiling a driver module that uses
> > amba-pl08x:
> >
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> >
> > (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
>
> It is currently intended that this be passed from platform code into
> drivers via platform data, so that drivers can decide which DMA engine
> they wish to make use of.
>
> See how all the AMBA drivers work in this regard (because they need to
> support more than just a single DMA engine implementation.)
Ah, you're right, I forgot about that. I'll take back my Ack then.
Arnd
next prev parent reply other threads:[~2012-08-16 9:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 8:56 [PATCH] dma: amba-pl08x: Export pl08x_filter_id Roland Stigge
2012-08-16 8:56 ` Roland Stigge
2012-08-16 8:59 ` Arnd Bergmann
2012-08-16 8:59 ` Arnd Bergmann
2012-08-16 8:59 ` Arnd Bergmann
2012-08-16 9:00 ` Russell King - ARM Linux
2012-08-16 9:00 ` Russell King - ARM Linux
2012-08-16 9:00 ` Russell King - ARM Linux
2012-08-16 9:06 ` Arnd Bergmann [this message]
2012-08-16 9:06 ` Arnd Bergmann
2012-08-16 9:06 ` Arnd Bergmann
2012-08-16 13:13 ` Roland Stigge
2012-08-16 13:13 ` Roland Stigge
2012-08-16 13:13 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208160906.21950.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=aletes.xgr@gmail.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=srinivas.bakki@nxp.com \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.