From: Andrew Eikum <aeikum@codeweavers.com>
To: alsa-devel <alsa-devel@alsa-project.org>, Takashi Iwai <tiwai@suse.de>
Subject: [alsa-plugins PATCH] pulse: Support 24-bit formats
Date: Fri, 17 Aug 2012 15:41:07 -0500 [thread overview]
Message-ID: <20120817204107.GV2424@foghorn.codeweavers.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
These formats were introduced in PulseAudio 0.9.15. There aren't any
new formats supported since then, so this also brings the PulseAudio
plugin in sync with current PulseAudio.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
---
There was a problem once before with a patch I submitted. This is
using format-patch and imap-send, so hopefully it goes through better
than it did before :)
pulse/pcm_pulse.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
[-- Attachment #2: 0001-pulse-Support-24-bit-formats.patch --]
[-- Type: text/x-patch, Size: 834 bytes --]
diff --git a/pulse/pcm_pulse.c b/pulse/pcm_pulse.c
index e0fbd4c..24fd4da 100644
--- a/pulse/pcm_pulse.c
+++ b/pulse/pcm_pulse.c
@@ -820,6 +820,26 @@ static int pulse_hw_params(snd_pcm_ioplug_t * io,
pcm->ss.format = PA_SAMPLE_S32BE;
break;
#endif
+#ifdef PA_SAMPLE_S24LE
+ case SND_PCM_FORMAT_S24_3LE:
+ pcm->ss.format = PA_SAMPLE_S24LE;
+ break;
+#endif
+#ifdef PA_SAMPLE_S24BE
+ case SND_PCM_FORMAT_S24_3BE:
+ pcm->ss.format = PA_SAMPLE_S24BE;
+ break;
+#endif
+#ifdef PA_SAMPLE_S24_32LE
+ case SND_PCM_FORMAT_S24_LE:
+ pcm->ss.format = PA_SAMPLE_S24_32LE;
+ break;
+#endif
+#ifdef PA_SAMPLE_S24_32BE
+ case SND_PCM_FORMAT_S24_BE:
+ pcm->ss.format = PA_SAMPLE_S24_32BE;
+ break;
+#endif
default:
SNDERR("PulseAudio: Unsupported format %s\n",
snd_pcm_format_name(io->format));
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next reply other threads:[~2012-08-17 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 20:41 Andrew Eikum [this message]
2012-08-20 9:30 ` [alsa-plugins PATCH] pulse: Support 24-bit formats Takashi Iwai
2012-08-20 12:42 ` Andrew Eikum
2012-08-20 12:56 ` Takashi Iwai
2012-08-20 13:04 ` Andrew Eikum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120817204107.GV2424@foghorn.codeweavers.com \
--to=aeikum@codeweavers.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.