Re: [alsa-plugins PATCH] pulse: Support 24-bit formats

[Andrew Eikum <aeikum@codeweavers.com>]

On Mon, Aug 20, 2012 at 02:56:33PM +0200, Takashi Iwai wrote:
> At Mon, 20 Aug 2012 07:42:05 -0500,
> Andrew Eikum wrote:
> > 
> > On Mon, Aug 20, 2012 at 11:30:45AM +0200, Takashi Iwai wrote:
> > > At Fri, 17 Aug 2012 15:41:07 -0500,
> > > Andrew Eikum wrote:
> > > > These formats were introduced in PulseAudio 0.9.15. There aren't any
> > > > new formats supported since then, so this also brings the PulseAudio
> > > > plugin in sync with current PulseAudio.
> > > > 
> > > > Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
> > > > ---
> > > > 
> > > > There was a problem once before with a patch I submitted. This is
> > > > using format-patch and imap-send, so hopefully it goes through better
> > > > than it did before :)
> > > 
> > > Well, unfortunately it's not a preferred form of the patch.
> > > The patch commit log must be embedded in the patch itself.  That is,
> > > the text above including your sign-off must be in the git commit log,
> > > then generate the patch via git-format-patch or git show --pretty=email.
> > > 
> > > In anyway, I applied your patch manually now.
> > > Please try the right way at the next time.
> > > 
> > 
> > I guess I'm used to how the Git project and the Wine maintainer do it.
> > They import the entire mbox file with 'git am'. This works properly
> > for the mail I sent, including putting the message and S-o-b line into
> > the commit log and ignoring the bit between the --- and the patch.
> 
> git-am isn't designed for a separate patch with attachment.  It's for
> an embedded patch.  It might work with attachment casually but it's
> not the intended workflow.
> 

Ah, I didn't know that. Thanks for the info.

Andrew