All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Hebbar, Gururaja" <gururaja.hebbar@ti.com>
Cc: alsa-devel@alsa-project.org, sudhakar.raj@ti.com,
	tony@atomide.com, nsekhar@ti.com,
	davinci-linux-open-source@linux.davincidsp.com,
	peter.ujfalusi@ti.com, lrg@ti.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] ASoC: Davinci: machine: Add device tree binding
Date: Fri, 17 Aug 2012 23:43:28 +0100	[thread overview]
Message-ID: <20120817224327.GK18871@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1344948125-5649-5-git-send-email-gururaja.hebbar@ti.com>


[-- Attachment #1.1: Type: text/plain, Size: 505 bytes --]

On Tue, Aug 14, 2012 at 06:12:04PM +0530, Hebbar, Gururaja wrote:

> +- ti,codec-clock : The Codec Clock from the board

I think this is the clock rate?  Please specify it more specifically.

> +"<CODEC DAI Name>",	"<true if evm_aic3x_init is required, else false>",
> +"<evm ops required, evm_ops or evm_spdif_ops>";

Please be more specific as to what these actually do - consider the user
who is reading the bindings with a view to implementing them for their
board, or writing drivers for another OS.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ASoC: Davinci: machine: Add device tree binding
Date: Fri, 17 Aug 2012 23:43:28 +0100	[thread overview]
Message-ID: <20120817224327.GK18871@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1344948125-5649-5-git-send-email-gururaja.hebbar@ti.com>

On Tue, Aug 14, 2012 at 06:12:04PM +0530, Hebbar, Gururaja wrote:

> +- ti,codec-clock : The Codec Clock from the board

I think this is the clock rate?  Please specify it more specifically.

> +"<CODEC DAI Name>",	"<true if evm_aic3x_init is required, else false>",
> +"<evm ops required, evm_ops or evm_spdif_ops>";

Please be more specific as to what these actually do - consider the user
who is reading the bindings with a view to implementing them for their
board, or writing drivers for another OS.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120817/ebff4c85/attachment.sig>

  reply	other threads:[~2012-08-17 22:13 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 12:42 [PATCH 0/5] ARM/ASoC: Davinci: Add Device Tree Support Hebbar, Gururaja
2012-08-14 12:42 ` Hebbar, Gururaja
2012-08-14 12:42 ` [PATCH 1/5] ASoC/ARM: Davinci: McASP: split asp header into platform and audio specific Hebbar, Gururaja
2012-08-14 12:42   ` Hebbar, Gururaja
     [not found]   ` <1344948125-5649-2-git-send-email-gururaja.hebbar-l0cyMroinI0@public.gmane.org>
2012-08-17 18:13     ` Sekhar Nori
2012-08-17 18:13       ` Sekhar Nori
2012-08-22  7:06       ` Hebbar, Gururaja
2012-08-22  7:06         ` Hebbar, Gururaja
2012-08-17 22:33   ` Mark Brown
2012-08-17 22:33     ` Mark Brown
2012-08-22 13:11     ` Hebbar, Gururaja
2012-08-22 13:11       ` Hebbar, Gururaja
2012-08-14 12:42 ` [PATCH 2/5] ASoC: Davinci: McASP: add device tree support for McASP Hebbar, Gururaja
2012-08-14 12:42   ` Hebbar, Gururaja
2012-08-17 22:41   ` Mark Brown
2012-08-17 22:41     ` Mark Brown
2012-08-23  7:56     ` Hebbar, Gururaja
2012-08-23  7:56       ` Hebbar, Gururaja
2012-08-14 12:42 ` [PATCH 3/5] ASoC: Davinci: pcm: Add device tree bindings Hebbar, Gururaja
2012-08-14 12:42   ` Hebbar, Gururaja
2012-08-17 22:31   ` Mark Brown
2012-08-17 22:31     ` Mark Brown
2012-08-22 13:50     ` Hebbar, Gururaja
2012-08-22 13:50       ` Hebbar, Gururaja
2012-08-22 15:58       ` Mark Brown
2012-08-22 15:58         ` Mark Brown
2012-08-23  5:13         ` Hebbar, Gururaja
2012-08-23  5:13           ` Hebbar, Gururaja
2012-08-14 12:42 ` [PATCH 4/5] ASoC: Davinci: machine: Add device tree binding Hebbar, Gururaja
2012-08-14 12:42   ` Hebbar, Gururaja
2012-08-17 22:43   ` Mark Brown [this message]
2012-08-17 22:43     ` Mark Brown
2012-08-22 11:35     ` Hebbar, Gururaja
2012-08-22 11:35       ` Hebbar, Gururaja
2012-08-14 12:42 ` [PATCH 5/5] ASoC: tlv320aic3x: Add device tree bindings Hebbar, Gururaja
2012-08-14 12:42   ` Hebbar, Gururaja
2012-08-17 22:45   ` Mark Brown
2012-08-17 22:45     ` Mark Brown
2012-08-22  9:26     ` Hebbar, Gururaja
2012-08-22  9:26       ` Hebbar, Gururaja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120817224327.GK18871@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=gururaja.hebbar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lrg@ti.com \
    --cc=nsekhar@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=sudhakar.raj@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.