From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] do not implement get_user_input() in DISABLE_NCURSES builds
Date: Mon, 20 Aug 2012 22:39:43 +0300 [thread overview]
Message-ID: <20120820193942.GE3137@swordfish> (raw)
In-Reply-To: 50327F4D.1010605@linux.intel.com
[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]
On (08/20/12 11:17), Chris Ferron wrote:
> On 08/20/2012 08:34 AM, Arjan van de Ven wrote:
> >On 8/20/2012 8:31 AM, Chris Ferron wrote:
> >>On 08/20/2012 08:21 AM, Arjan van de Ven wrote:
> >>>On 8/20/2012 8:18 AM, Chris Ferron wrote:
> >>>>The only reason we allowed DISABLE_NCURSES in the first place, was to support android. If we don't want to support android out of the box, we can start removing the crude
> >>>>and android can patch PowerTOP within their distro if they wanted.
> >>>..or for an android build one adds ncurses to the local android.. like libpci and libnl are anyway
> >>>
> >>Yep, another perfectly reasonable option. So lets make ncurses a hard requirement and remove the ifdef's.
> >it's already a runtime option anyway (with --html and co)
> >
> >worst case, if someone really cannot stand this, they can contribute a mini "stub" ncurses that we then
> >compile in for those people who can't cope. But that really should be a separate stub (similar to how we
> >do the pevent lib), not a ton of ifdefs in code.
> >
> Sergey good patch but it sounds like the ifdefs for ncurses and
> others should go. I have fixed this, hopefully this also helps you
> out.
>
Good job! I'm happy that you washed away these ifdefs.
-ss
next reply other threads:[~2012-08-20 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 19:39 Sergey Senozhatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-20 18:17 [Powertop] [PATCH] do not implement get_user_input() in DISABLE_NCURSES builds Chris Ferron
2012-08-20 15:34 Arjan van de Ven
2012-08-20 15:31 Chris Ferron
2012-08-20 15:31 Sergey Senozhatsky
2012-08-20 15:21 Arjan van de Ven
2012-08-20 15:18 Chris Ferron
2012-08-20 9:49 Sergey Senozhatsky
2012-08-20 0:40 Arjan van de Ven
2012-08-19 21:57 Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820193942.GE3137@swordfish \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.