From: Chris Ferron <chris.e.ferron at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] do not implement get_user_input() in DISABLE_NCURSES builds
Date: Mon, 20 Aug 2012 08:18:59 -0700 [thread overview]
Message-ID: <50325563.6040605@linux.intel.com> (raw)
In-Reply-To: 20120820094917.GB3137@swordfish
[-- Attachment #1: Type: text/plain, Size: 1706 bytes --]
On 08/20/2012 02:49 AM, Sergey Senozhatsky wrote:
> On (08/19/12 17:40), Arjan van de Ven wrote:
>> On 8/19/2012 2:57 PM, Sergey Senozhatsky wrote:
>>> do not implement get_user_input() in DISABLE_NCURSES builds
>> no offence.. but this ifdef madness needs to stop.
>>
>> right now, powertop uses ncurses.
>>
>> either we want to make it optional, but then this stuff needs to get a lot more modular,
>> or we just declare that you need ncurses.
>> I'm very much leaning towards the later fwiw...
>>
> I agree, and actually I don't like this patch (ifdef stuff also affects patches I'm currently
> working on). it's rather hard to tell how many people will be affected by #2 decision, but we
> can tell the number for #1 case.
>
> DISABLE_NCURSES is not that nasty in overall, since it just disables some application features,
> comparing to, for example, DISABLE_TRYCATCH, which disables standard language features for very
> much non-obvious reason for someone with no embedded background.
>
> that said, it'll be nice if we forbid DISABLE_NCURSES, but we'll still have ifdefs in
> code because of decisions different people made (like no ncurses in some distros or incomplete/buggy
> programming language support).
>
>
> -ss
The only reason we allowed DISABLE_NCURSES in the first place, was to
support android. If we don't want to support android out of the box, we
can start removing the crude and android can patch PowerTOP within their
distro if they wanted.
All other ifdef's need to be scrutinized.
-C
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
next reply other threads:[~2012-08-20 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 15:18 Chris Ferron [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-20 19:39 [Powertop] [PATCH] do not implement get_user_input() in DISABLE_NCURSES builds Sergey Senozhatsky
2012-08-20 18:17 Chris Ferron
2012-08-20 15:34 Arjan van de Ven
2012-08-20 15:31 Chris Ferron
2012-08-20 15:31 Sergey Senozhatsky
2012-08-20 15:21 Arjan van de Ven
2012-08-20 9:49 Sergey Senozhatsky
2012-08-20 0:40 Arjan van de Ven
2012-08-19 21:57 Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50325563.6040605@linux.intel.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.