From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for
Date: Wed, 22 Aug 2012 06:44:17 +0000 [thread overview]
Message-ID: <201208220644.18059.arnd@arndb.de> (raw)
In-Reply-To: <1345617278.7491.4.camel@gitbox>
On Wednesday 22 August 2012, Tony Prisk wrote:
> The original patch was very simple, but I revisited it to fix other
> issues and forgot to add the relevant comments.
>
> Port size is changed to fix a problem - WM8505 actually had 6 uart's
> defined in platform data but the vt8500_ports variable was only 4.
>
> I have added devicetree port id support as well.
If you do multiple things in one driver, you should normally send multiple
patches as well, each with a description why that change is done.
It may seem silly at first to send out a one-line patch next to a 100-line
patch for the same file, but those cases are actually the ones where it's
most important.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>,
Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
Alessandro Zummo
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Linus Walleij
<linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
Florian Tobias Schandinat
<FlorianSchandinat-Mmb7MZpHnFY@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
vt8500-wm8505-linux-kernel-/JYPxA39Uh6Zox4op4iWzw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Mike Turquette <mturquette-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for
Date: Wed, 22 Aug 2012 06:44:17 +0000 [thread overview]
Message-ID: <201208220644.18059.arnd@arndb.de> (raw)
In-Reply-To: <1345617278.7491.4.camel@gitbox>
On Wednesday 22 August 2012, Tony Prisk wrote:
> The original patch was very simple, but I revisited it to fix other
> issues and forgot to add the relevant comments.
>
> Port size is changed to fix a problem - WM8505 actually had 6 uart's
> defined in platform data but the vt8500_ports variable was only 4.
>
> I have added devicetree port id support as well.
If you do multiple things in one driver, you should normally send multiple
patches as well, each with a description why that change is done.
It may seem silly at first to send out a one-line patch next to a 100-line
patch for the same file, but those cases are actually the ones where it's
most important.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 3/9] serial: vt8500: Add devicetree support for
Date: Wed, 22 Aug 2012 06:44:17 +0000 [thread overview]
Message-ID: <201208220644.18059.arnd@arndb.de> (raw)
In-Reply-To: <1345617278.7491.4.camel@gitbox>
On Wednesday 22 August 2012, Tony Prisk wrote:
> The original patch was very simple, but I revisited it to fix other
> issues and forgot to add the relevant comments.
>
> Port size is changed to fix a problem - WM8505 actually had 6 uart's
> defined in platform data but the vt8500_ports variable was only 4.
>
> I have added devicetree port id support as well.
If you do multiple things in one driver, you should normally send multiple
patches as well, each with a description why that change is done.
It may seem silly at first to send out a one-line patch next to a 100-line
patch for the same file, but those cases are actually the ones where it's
most important.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Tony Prisk <linux@prisktech.co.nz>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-fbdev@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Linus Walleij <linus.walleij@stericsson.com>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devicetree-discuss@lists.ozlabs.org, linux-usb@vger.kernel.org,
vt8500-wm8505-linux-kernel@googlegroup.com,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Landley <rob@landley.net>,
linux-serial@vger.kernel.org, rtc-linux@googlegroups.com,
Stephen Warren <swarren@nvidia.com>,
Alan Cox <alan@linux.intel.com>,
Mike Turquette <mturquette@ti.com>
Subject: Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for
Date: Wed, 22 Aug 2012 06:44:17 +0000 [thread overview]
Message-ID: <201208220644.18059.arnd@arndb.de> (raw)
In-Reply-To: <1345617278.7491.4.camel@gitbox>
On Wednesday 22 August 2012, Tony Prisk wrote:
> The original patch was very simple, but I revisited it to fix other
> issues and forgot to add the relevant comments.
>
> Port size is changed to fix a problem - WM8505 actually had 6 uart's
> defined in platform data but the vt8500_ports variable was only 4.
>
> I have added devicetree port id support as well.
If you do multiple things in one driver, you should normally send multiple
patches as well, each with a description why that change is done.
It may seem silly at first to send out a one-line patch next to a 100-line
patch for the same file, but those cases are actually the ones where it's
most important.
Arnd
next prev parent reply other threads:[~2012-08-22 6:44 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 20:47 [PATCHv3 0/9] *** ARM: Update arch-vt8500 to Devicetree *** Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` [PATCHv3 1/9] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` [PATCHv3 2/9] rtc: vt8500: Add devicetree support for vt8500-rtc Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` [PATCHv3 3/9] serial: vt8500: Add devicetree support for vt8500-serial Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 22:12 ` Alan Cox
2012-08-21 22:12 ` Alan Cox
2012-08-21 22:12 ` Alan Cox
2012-08-21 22:12 ` Alan Cox
2012-08-22 6:34 ` [PATCHv3 3/9] serial: vt8500: Add devicetree support for Tony Prisk
2012-08-22 6:34 ` Tony Prisk
2012-08-22 6:34 ` Tony Prisk
2012-08-22 6:34 ` Tony Prisk
2012-08-22 6:44 ` Arnd Bergmann [this message]
2012-08-22 6:44 ` Arnd Bergmann
2012-08-22 6:44 ` Arnd Bergmann
2012-08-22 6:44 ` Arnd Bergmann
2012-08-23 21:29 ` Rob Landley
2012-08-23 21:29 ` Rob Landley
2012-08-23 21:29 ` Rob Landley
2012-08-21 20:47 ` [PATCHv3 4/9] usb: vt8500: Add devicetree support for vt8500-ehci and -uhci Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` [PATCHv3 5/9] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` [PATCHv3 6/9] arm: vt8500: Update arch-vt8500 to devicetree support Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` [PATCHv3 7/9] arm: vt8500: doc: Add device tree bindings for arch-vt8500 devices Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-22 21:07 ` Stephen Warren
2012-08-22 21:07 ` Stephen Warren
2012-08-22 21:07 ` Stephen Warren
2012-08-22 21:07 ` Stephen Warren
2012-08-22 21:32 ` Tony Prisk
2012-08-22 21:32 ` Tony Prisk
2012-08-22 21:32 ` Tony Prisk
2012-08-21 20:47 ` [PATCHv3 8/9] arm: vt8500: gpio: Devicetree support for arch-vt8500 Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-22 9:21 ` [rtc-linux] " Linus Walleij
2012-08-22 9:21 ` Linus Walleij
2012-08-22 9:21 ` Linus Walleij
2012-08-22 13:33 ` Tony Prisk
2012-08-22 13:33 ` Tony Prisk
2012-08-22 13:33 ` Tony Prisk
2012-08-22 13:33 ` Tony Prisk
2012-08-21 20:47 ` [PATCHv3 9/9] arm: vt8500: clk: Add Common Clock Framework support Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
2012-08-21 20:47 ` Tony Prisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208220644.18059.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.