All of lore.kernel.org
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Alexander Stein
	<alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Jean Delvare (PC drivers,
	core)" <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
	"Ben Dooks (embedded platforms)"
	<ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	Tomoya MORINAGA
	<tomoya.rohm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: i2c-eg20t: regression since i2c_add_numbered_adapter change
Date: Wed, 22 Aug 2012 15:29:18 +0800	[thread overview]
Message-ID: <20120822152918.3e59616e@feng-i7> (raw)
In-Reply-To: <4401854.hVfHzgeqjT@ws-stein>

On Wed, 22 Aug 2012 08:30:35 +0200
Alexander Stein <alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org> wrote:

> Hello,
> 
> I just noticed the 3.4 linux kernel fails to sucessfully probe the i2c-eg20t 
> driver. I returns with EBUSY error. It worked on the 3.0 kernel. To my view it 
> is caused the commit 07e8a51ff68353e01d795cceafbac9f54c49132b ( i2c-eg20t: use 
> i2c_add_numbered_adapter to get a fixed bus number).
> The reason it actually fails is that the i2c-isch driver is registered 
> beforehand which gets bus number 0. But this one is the bus number the eg20t 
> driver wants to register.

Make sense.

> A possibility is that if i2c_add_numbered_adapter failed with EBUSY just use 
> i2c_add_adapter to get at least the driver working, but with a non-fixed bus 
> number. Opinions?

Or can we give it a fixed offset, like let the i2c_eg20t controller bus number
start with 4? I don't expect there will be more than 4 other i2c controllers 
on EG20T compatible platforms.

Thanks,
Feng

WARNING: multiple messages have this Message-ID (diff)
From: Feng Tang <feng.tang@intel.com>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Jean Delvare (PC drivers, core)" <khali@linux-fr.org>,
	"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
	Tomoya MORINAGA <tomoya.rohm@gmail.com>
Subject: Re: i2c-eg20t: regression since i2c_add_numbered_adapter change
Date: Wed, 22 Aug 2012 15:29:18 +0800	[thread overview]
Message-ID: <20120822152918.3e59616e@feng-i7> (raw)
In-Reply-To: <4401854.hVfHzgeqjT@ws-stein>

On Wed, 22 Aug 2012 08:30:35 +0200
Alexander Stein <alexander.stein@systec-electronic.com> wrote:

> Hello,
> 
> I just noticed the 3.4 linux kernel fails to sucessfully probe the i2c-eg20t 
> driver. I returns with EBUSY error. It worked on the 3.0 kernel. To my view it 
> is caused the commit 07e8a51ff68353e01d795cceafbac9f54c49132b ( i2c-eg20t: use 
> i2c_add_numbered_adapter to get a fixed bus number).
> The reason it actually fails is that the i2c-isch driver is registered 
> beforehand which gets bus number 0. But this one is the bus number the eg20t 
> driver wants to register.

Make sense.

> A possibility is that if i2c_add_numbered_adapter failed with EBUSY just use 
> i2c_add_adapter to get at least the driver working, but with a non-fixed bus 
> number. Opinions?

Or can we give it a fixed offset, like let the i2c_eg20t controller bus number
start with 4? I don't expect there will be more than 4 other i2c controllers 
on EG20T compatible platforms.

Thanks,
Feng

  reply	other threads:[~2012-08-22  7:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22  6:30 i2c-eg20t: regression since i2c_add_numbered_adapter change Alexander Stein
2012-08-22  6:30 ` Alexander Stein
2012-08-22  7:29 ` Feng Tang [this message]
2012-08-22  7:29   ` Feng Tang
2012-08-22  7:57   ` Alexander Stein
2012-08-22  8:04     ` Feng Tang
2012-08-22  8:04       ` Feng Tang
2012-08-22  9:17       ` Alexander Stein
2012-08-22  9:17         ` Alexander Stein
2012-08-23  8:28         ` Feng Tang
2012-08-23  8:28           ` Feng Tang
2012-08-29 18:40           ` Jean Delvare
2012-08-29 18:40             ` Jean Delvare
     [not found]             ` <20120829204031.648a73e1-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-08-30  7:49               ` Alexander Stein
2012-08-30  7:49                 ` Alexander Stein
2012-08-30  9:19                 ` Feng Tang
2012-08-30  9:19                   ` Feng Tang
2012-08-30 11:08                   ` Alexander Stein
2012-08-30 11:08                     ` Alexander Stein
2012-08-31  2:16                     ` Feng Tang
2012-08-31  2:16                       ` Feng Tang
2012-09-08 13:18                 ` Jean Delvare
2012-08-30  9:10               ` Feng Tang
2012-08-30  9:10                 ` Feng Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120822152918.3e59616e@feng-i7 \
    --to=feng.tang-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tomoya.rohm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.