From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ARM: omap: allow building omap44xx without SMP
Date: Wed, 22 Aug 2012 17:22:06 +0000 [thread overview]
Message-ID: <201208221722.06775.arnd@arndb.de> (raw)
In-Reply-To: <CAMQu2gw0x6saWrK-M3teu49tJDGvS8RhGrVSh6JTs5DEy+22pA@mail.gmail.com>
On Wednesday 22 August 2012, Shilimkar, Santosh wrote:
> Was just thinking whether we should just take care of it at
> core cpuidle level itself. Will below be enough to kill the build
> error what you mentioned in the change log ?
>
> diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
> index 2c9bf26..df34534 100644
> --- a/drivers/cpuidle/coupled.c
> +++ b/drivers/cpuidle/coupled.c
> @@ -314,7 +314,9 @@ static void cpuidle_coupled_poke(int cpu)
> struct call_single_data *csd = &per_cpu(cpuidle_coupled_poke_cb, cpu);
>
> if (!cpumask_test_and_set_cpu(cpu, &cpuidle_coupled_poked_mask))
> +#ifdef CONFIG_SMP
> __smp_call_function_single(cpu, csd, 0);
> +#endif
> }
>
That would work, but isn't the entire concept of the cpuidle-coupled driver
dependent on SMP? If this driver makes no sense on UP, I think we should
not attempt to build it.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: linux-arm-kernel@lists.infradead.org,
Russell King <rmk+kernel@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, Kevin Hilman <khilman@ti.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/6] ARM: omap: allow building omap44xx without SMP
Date: Wed, 22 Aug 2012 17:22:06 +0000 [thread overview]
Message-ID: <201208221722.06775.arnd@arndb.de> (raw)
In-Reply-To: <CAMQu2gw0x6saWrK-M3teu49tJDGvS8RhGrVSh6JTs5DEy+22pA@mail.gmail.com>
On Wednesday 22 August 2012, Shilimkar, Santosh wrote:
> Was just thinking whether we should just take care of it at
> core cpuidle level itself. Will below be enough to kill the build
> error what you mentioned in the change log ?
>
> diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
> index 2c9bf26..df34534 100644
> --- a/drivers/cpuidle/coupled.c
> +++ b/drivers/cpuidle/coupled.c
> @@ -314,7 +314,9 @@ static void cpuidle_coupled_poke(int cpu)
> struct call_single_data *csd = &per_cpu(cpuidle_coupled_poke_cb, cpu);
>
> if (!cpumask_test_and_set_cpu(cpu, &cpuidle_coupled_poked_mask))
> +#ifdef CONFIG_SMP
> __smp_call_function_single(cpu, csd, 0);
> +#endif
> }
>
That would work, but isn't the entire concept of the cpuidle-coupled driver
dependent on SMP? If this driver makes no sense on UP, I think we should
not attempt to build it.
Arnd
next prev parent reply other threads:[~2012-08-22 17:22 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 15:13 [PATCH 0/6] ARM: randconfig bugs Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-22 15:13 ` [PATCH 1/6] ARM: ux500: don't select LEDS_GPIO for snowball Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-23 14:26 ` Arnd Bergmann
2012-08-23 14:26 ` Arnd Bergmann
2012-08-27 23:40 ` Linus Walleij
2012-08-27 23:40 ` Linus Walleij
2012-08-22 15:13 ` [PATCH 2/6] ARM: omap: allow building omap44xx without SMP Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-22 15:36 ` Shilimkar, Santosh
2012-08-22 15:36 ` Shilimkar, Santosh
2012-08-22 17:22 ` Arnd Bergmann [this message]
2012-08-22 17:22 ` Arnd Bergmann
2012-08-23 7:05 ` Shilimkar, Santosh
2012-08-23 7:05 ` Shilimkar, Santosh
2012-08-23 12:12 ` Arnd Bergmann
2012-08-23 12:12 ` Arnd Bergmann
2012-08-23 13:00 ` Shilimkar, Santosh
2012-08-23 13:00 ` Shilimkar, Santosh
2012-08-23 13:32 ` Arnd Bergmann
2012-08-23 13:32 ` Arnd Bergmann
2012-08-22 15:13 ` [PATCH 3/6] ARM: imx: build pm-imx5 code only when PM is enabled Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-23 2:07 ` Shawn Guo
2012-08-23 2:07 ` Shawn Guo
2012-08-22 15:13 ` [PATCH 4/6] ARM: imx: fix ksz9021rn_phy_fixup Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-23 2:10 ` Shawn Guo
2012-08-23 2:10 ` Shawn Guo
2012-08-22 15:13 ` [PATCH 5/6] ARM: imx: select CPU_FREQ_TABLE when needed Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-23 2:13 ` Shawn Guo
2012-08-23 2:13 ` Shawn Guo
2012-08-22 15:13 ` [PATCH 6/6] ARM: imx: select ARM_CPU_SUSPEND when necessary Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-23 2:41 ` Shawn Guo
2012-08-23 2:41 ` Shawn Guo
2012-08-23 14:20 ` Arnd Bergmann
2012-08-23 14:20 ` Arnd Bergmann
2012-08-23 14:55 ` Shawn Guo
2012-08-23 14:55 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208221722.06775.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.