All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
@ 2012-08-13 20:33 Franklin S Cooper Jr
  2012-08-22 18:06 ` Cooper Jr., Franklin
  0 siblings, 1 reply; 6+ messages in thread
From: Franklin S Cooper Jr @ 2012-08-13 20:33 UTC (permalink / raw)
  To: meta-arago; +Cc: Franklin S Cooper Jr

* Add the change to the variable LIC_FILES_CHKSUM to insure that only
  the lines that contains license information are used for the checksum
* Update to the latest version of psplash.
* The above changes are already found in the psplash recipe located in oe-core
  master

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 .../recipes-core/psplash/psplash_git.bbappend      |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
 create mode 100644 meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend

diff --git a/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
new file mode 100644
index 0000000..0ddbd6a
--- /dev/null
+++ b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
@@ -0,0 +1,4 @@
+LIC_FILES_CHKSUM = "file://psplash.h;beginline=1;endline=16;md5=840fb2356b10a85bed78dd09dc7745c6"
+
+SRCREV = "de9979aefbc56af59b4d236a4b63dd19dcdcfb53"
+PRINC := "${@int(PRINC) + 1}"
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
  2012-08-13 20:33 [PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable Franklin S Cooper Jr
@ 2012-08-22 18:06 ` Cooper Jr., Franklin
  2012-08-22 18:14   ` Denys Dmytriyenko
  0 siblings, 1 reply; 6+ messages in thread
From: Cooper Jr., Franklin @ 2012-08-22 18:06 UTC (permalink / raw)
  To: Cooper Jr., Franklin, meta-arago@arago-project.org; +Cc: Cooper Jr., Franklin

Ignore this patch. A new patch will be sent out that addresses the concern of patch [meta-arago] [PATCH] meta-arago-upstream: Create new upstream layer

-----Original Message-----
From: Cooper Jr., Franklin 
Sent: Monday, August 13, 2012 3:33 PM
To: meta-arago@arago-project.org
Cc: Cooper Jr., Franklin
Subject: [meta-arago][PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable

* Add the change to the variable LIC_FILES_CHKSUM to insure that only
  the lines that contains license information are used for the checksum
* Update to the latest version of psplash.
* The above changes are already found in the psplash recipe located in oe-core
  master

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 .../recipes-core/psplash/psplash_git.bbappend      |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
 create mode 100644 meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend

diff --git a/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
new file mode 100644
index 0000000..0ddbd6a
--- /dev/null
+++ b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
@@ -0,0 +1,4 @@
+LIC_FILES_CHKSUM = "file://psplash.h;beginline=1;endline=16;md5=840fb2356b10a85bed78dd09dc7745c6"
+
+SRCREV = "de9979aefbc56af59b4d236a4b63dd19dcdcfb53"
+PRINC := "${@int(PRINC) + 1}"
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
  2012-08-22 18:06 ` Cooper Jr., Franklin
@ 2012-08-22 18:14   ` Denys Dmytriyenko
  2012-08-22 18:17     ` Cooper Jr., Franklin
  0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2012-08-22 18:14 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org

On Wed, Aug 22, 2012 at 06:06:43PM +0000, Cooper Jr., Franklin wrote:
> Ignore this patch. A new patch will be sent out that addresses the concern 
> of patch [meta-arago] [PATCH] meta-arago-upstream: Create new upstream layer

Right, are you going to use a separate "next" branch or just drop it in 
"master" for now, as we discussed?

-- 
Denys


> -----Original Message-----
> From: Cooper Jr., Franklin 
> Sent: Monday, August 13, 2012 3:33 PM
> To: meta-arago@arago-project.org
> Cc: Cooper Jr., Franklin
> Subject: [meta-arago][PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
> 
> * Add the change to the variable LIC_FILES_CHKSUM to insure that only
>   the lines that contains license information are used for the checksum
> * Update to the latest version of psplash.
> * The above changes are already found in the psplash recipe located in oe-core
>   master
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>  .../recipes-core/psplash/psplash_git.bbappend      |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>  create mode 100644 meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
> 
> diff --git a/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
> new file mode 100644
> index 0000000..0ddbd6a
> --- /dev/null
> +++ b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
> @@ -0,0 +1,4 @@
> +LIC_FILES_CHKSUM = "file://psplash.h;beginline=1;endline=16;md5=840fb2356b10a85bed78dd09dc7745c6"
> +
> +SRCREV = "de9979aefbc56af59b4d236a4b63dd19dcdcfb53"
> +PRINC := "${@int(PRINC) + 1}"
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
  2012-08-22 18:14   ` Denys Dmytriyenko
@ 2012-08-22 18:17     ` Cooper Jr., Franklin
  2012-08-22 19:29       ` Denys Dmytriyenko
  0 siblings, 1 reply; 6+ messages in thread
From: Cooper Jr., Franklin @ 2012-08-22 18:17 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org, Cooper Jr., Franklin

Dropping it into master. I add comments to the recipe and to the commit history explaining that these changes were already made in oe-core master. I don't quite understand Chase's comment in the other thread
" Could we perhaps us the PV value in the recipe of 0.1+git${SRCPV} in the bbappend to force the append to that specific version and therefore break on an upgrade?" But I am sure what ever changes he wants we can add later.

-----Original Message-----
From: Dmytriyenko, Denys 
Sent: Wednesday, August 22, 2012 1:14 PM
To: Cooper Jr., Franklin
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable

On Wed, Aug 22, 2012 at 06:06:43PM +0000, Cooper Jr., Franklin wrote:
> Ignore this patch. A new patch will be sent out that addresses the concern 
> of patch [meta-arago] [PATCH] meta-arago-upstream: Create new upstream layer

Right, are you going to use a separate "next" branch or just drop it in 
"master" for now, as we discussed?

-- 
Denys


> -----Original Message-----
> From: Cooper Jr., Franklin 
> Sent: Monday, August 13, 2012 3:33 PM
> To: meta-arago@arago-project.org
> Cc: Cooper Jr., Franklin
> Subject: [meta-arago][PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
> 
> * Add the change to the variable LIC_FILES_CHKSUM to insure that only
>   the lines that contains license information are used for the checksum
> * Update to the latest version of psplash.
> * The above changes are already found in the psplash recipe located in oe-core
>   master
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>  .../recipes-core/psplash/psplash_git.bbappend      |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>  create mode 100644 meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
> 
> diff --git a/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
> new file mode 100644
> index 0000000..0ddbd6a
> --- /dev/null
> +++ b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
> @@ -0,0 +1,4 @@
> +LIC_FILES_CHKSUM = "file://psplash.h;beginline=1;endline=16;md5=840fb2356b10a85bed78dd09dc7745c6"
> +
> +SRCREV = "de9979aefbc56af59b4d236a4b63dd19dcdcfb53"
> +PRINC := "${@int(PRINC) + 1}"
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
  2012-08-22 18:17     ` Cooper Jr., Franklin
@ 2012-08-22 19:29       ` Denys Dmytriyenko
  2012-08-22 22:32         ` Cooper Jr., Franklin
  0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2012-08-22 19:29 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org

On Wed, Aug 22, 2012 at 02:17:10PM -0400, Cooper Jr., Franklin wrote:
> Dropping it into master. I add comments to the recipe and to the commit 
> history explaining that these changes were already made in oe-core master. I 
> don't quite understand Chase's comment in the other thread
> " Could we perhaps us the PV value in the recipe of 0.1+git${SRCPV} in the 
> bbappend to force the append to that specific version and therefore break on 
> an upgrade?" But I am sure what ever changes he wants we can add later.

What he meant was that psplash_git.bbappend is too generic and will try to 
apply a year later, even though underlying psplash.bb recipe could have 
evolved a lot. We can try creating a more specific bbappend with the version 
in the name - psplash_${PV}.bbappend. Then when PV changes, our bbappend will 
no longer apply with a big message that the underlying recipe has changed and 
require our attention.

-- 
Denys


> -----Original Message-----
> From: Dmytriyenko, Denys 
> Sent: Wednesday, August 22, 2012 1:14 PM
> To: Cooper Jr., Franklin
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
> 
> On Wed, Aug 22, 2012 at 06:06:43PM +0000, Cooper Jr., Franklin wrote:
> > Ignore this patch. A new patch will be sent out that addresses the concern 
> > of patch [meta-arago] [PATCH] meta-arago-upstream: Create new upstream layer
> 
> Right, are you going to use a separate "next" branch or just drop it in 
> "master" for now, as we discussed?
> 
> -- 
> Denys
> 
> 
> > -----Original Message-----
> > From: Cooper Jr., Franklin 
> > Sent: Monday, August 13, 2012 3:33 PM
> > To: meta-arago@arago-project.org
> > Cc: Cooper Jr., Franklin
> > Subject: [meta-arago][PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
> > 
> > * Add the change to the variable LIC_FILES_CHKSUM to insure that only
> >   the lines that contains license information are used for the checksum
> > * Update to the latest version of psplash.
> > * The above changes are already found in the psplash recipe located in oe-core
> >   master
> > 
> > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> > ---
> >  .../recipes-core/psplash/psplash_git.bbappend      |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> >  create mode 100644 meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
> > 
> > diff --git a/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
> > new file mode 100644
> > index 0000000..0ddbd6a
> > --- /dev/null
> > +++ b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
> > @@ -0,0 +1,4 @@
> > +LIC_FILES_CHKSUM = "file://psplash.h;beginline=1;endline=16;md5=840fb2356b10a85bed78dd09dc7745c6"
> > +
> > +SRCREV = "de9979aefbc56af59b4d236a4b63dd19dcdcfb53"
> > +PRINC := "${@int(PRINC) + 1}"
> > -- 
> > 1.7.0.4
> > 
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
  2012-08-22 19:29       ` Denys Dmytriyenko
@ 2012-08-22 22:32         ` Cooper Jr., Franklin
  0 siblings, 0 replies; 6+ messages in thread
From: Cooper Jr., Franklin @ 2012-08-22 22:32 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org

I tried your suggestion and couldn't get it to work. I tried other approaches and couldnt get it to work. Can u point to another bbappend that is named based on the PN_PV when the recipe that it is appending doesn't follow that naming convention ie psplash_git.bb? I just need an example to understand what I am doing incorrectly.

On Aug 22, 2012, at 2:29 PM, "Dmytriyenko, Denys" <denys@ti.com> wrote:

> On Wed, Aug 22, 2012 at 02:17:10PM -0400, Cooper Jr., Franklin wrote:
>> Dropping it into master. I add comments to the recipe and to the commit 
>> history explaining that these changes were already made in oe-core master. I 
>> don't quite understand Chase's comment in the other thread
>> " Could we perhaps us the PV value in the recipe of 0.1+git${SRCPV} in the 
>> bbappend to force the append to that specific version and therefore break on 
>> an upgrade?" But I am sure what ever changes he wants we can add later.
> 
> What he meant was that psplash_git.bbappend is too generic and will try to 
> apply a year later, even though underlying psplash.bb recipe could have 
> evolved a lot. We can try creating a more specific bbappend with the version 
> in the name - psplash_${PV}.bbappend. Then when PV changes, our bbappend will 
> no longer apply with a big message that the underlying recipe has changed and 
> require our attention.
> 
> -- 
> Denys
> 
> 
>> -----Original Message-----
>> From: Dmytriyenko, Denys 
>> Sent: Wednesday, August 22, 2012 1:14 PM
>> To: Cooper Jr., Franklin
>> Cc: meta-arago@arago-project.org
>> Subject: Re: [meta-arago] [PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
>> 
>> On Wed, Aug 22, 2012 at 06:06:43PM +0000, Cooper Jr., Franklin wrote:
>>> Ignore this patch. A new patch will be sent out that addresses the concern 
>>> of patch [meta-arago] [PATCH] meta-arago-upstream: Create new upstream layer
>> 
>> Right, are you going to use a separate "next" branch or just drop it in 
>> "master" for now, as we discussed?
>> 
>> -- 
>> Denys
>> 
>> 
>>> -----Original Message-----
>>> From: Cooper Jr., Franklin 
>>> Sent: Monday, August 13, 2012 3:33 PM
>>> To: meta-arago@arago-project.org
>>> Cc: Cooper Jr., Franklin
>>> Subject: [meta-arago][PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable
>>> 
>>> * Add the change to the variable LIC_FILES_CHKSUM to insure that only
>>>  the lines that contains license information are used for the checksum
>>> * Update to the latest version of psplash.
>>> * The above changes are already found in the psplash recipe located in oe-core
>>>  master
>>> 
>>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>>> ---
>>> .../recipes-core/psplash/psplash_git.bbappend |    4 ++++
>>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>> create mode 100644 meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
>>> 
>>> diff --git a/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
>>> new file mode 100644
>>> index 0000000..0ddbd6a
>>> --- /dev/null
>>> +++ b/meta-arago-upstream/recipes-core/psplash/psplash_git.bbappend
>>> @@ -0,0 +1,4 @@
>>> +LIC_FILES_CHKSUM = "file://psplash.h;beginline=1;endline=16;md5=840fb2356b10a85bed78dd09dc7745c6"
>>> +
>>> +SRCREV = "de9979aefbc56af59b4d236a4b63dd19dcdcfb53"
>>> +PRINC := "${@int(PRINC) + 1}"
>>> -- 
>>> 1.7.0.4
>>> 
>>> _______________________________________________
>>> meta-arago mailing list
>>> meta-arago@arago-project.org
>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-08-22 22:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-13 20:33 [PATCH] psplash: Update to latest version of psplash. Tweak LIC_FILES_CHKSUM variable Franklin S Cooper Jr
2012-08-22 18:06 ` Cooper Jr., Franklin
2012-08-22 18:14   ` Denys Dmytriyenko
2012-08-22 18:17     ` Cooper Jr., Franklin
2012-08-22 19:29       ` Denys Dmytriyenko
2012-08-22 22:32         ` Cooper Jr., Franklin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.