* [PATCH] misc: use module_spi_driver
@ 2012-08-23 8:53 Devendra Naga
2012-08-23 10:35 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Devendra Naga @ 2012-08-23 8:53 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman, linux-kernel; +Cc: Devendra Naga
The _init and _exit functions can be replaced with the module_spi_driver
macro, which actually implements
static int __init drv_init(void)
{
spi_register_driver(&driv_op);
return 0;
}
module_init(drv_init);
static void __exit drv_exit(void)
{
spi_unregister_driver(&driv_op);
}
module_exit(drv_exit);
Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
---
drivers/misc/bmp085-spi.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/misc/bmp085-spi.c b/drivers/misc/bmp085-spi.c
index 78aaff9..5e982af 100644
--- a/drivers/misc/bmp085-spi.c
+++ b/drivers/misc/bmp085-spi.c
@@ -73,19 +73,8 @@ static struct spi_driver bmp085_spi_driver = {
.remove = __devexit_p(bmp085_spi_remove)
};
-static int __init bmp085_spi_init(void)
-{
- return spi_register_driver(&bmp085_spi_driver);
-}
-
-static void __exit bmp085_spi_exit(void)
-{
- spi_unregister_driver(&bmp085_spi_driver);
-}
+module_spi_driver(bmp085_spi_driver);
MODULE_AUTHOR("Eric Andersson <eric.andersson@unixphere.com>");
MODULE_DESCRIPTION("BMP085 SPI bus driver");
MODULE_LICENSE("GPL");
-
-module_init(bmp085_spi_init);
-module_exit(bmp085_spi_exit);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] misc: use module_spi_driver
2012-08-23 8:53 [PATCH] misc: use module_spi_driver Devendra Naga
@ 2012-08-23 10:35 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2012-08-23 10:35 UTC (permalink / raw)
To: Devendra Naga; +Cc: Greg Kroah-Hartman, linux-kernel
On Thursday 23 August 2012, Devendra Naga wrote:
> The _init and _exit functions can be replaced with the module_spi_driver
> macro, which actually implements
>
> static int __init drv_init(void)
> {
> spi_register_driver(&driv_op);
> return 0;
> }
>
> module_init(drv_init);
>
> static void __exit drv_exit(void)
> {
> spi_unregister_driver(&driv_op);
> }
>
> module_exit(drv_exit);
>
> Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-23 10:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-23 8:53 [PATCH] misc: use module_spi_driver Devendra Naga
2012-08-23 10:35 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.