* [PATCH V2] xfstests: Replace lstat64 with cat in test 120
[not found] <20120823174357.065135717@sgi.com>
@ 2012-08-23 17:43 ` rjohnston
0 siblings, 0 replies; only message in thread
From: rjohnston @ 2012-08-23 17:43 UTC (permalink / raw)
To: xfs
[-- Attachment #1: replace_lstat64_with_cat.patch --]
[-- Type: text/plain, Size: 1666 bytes --]
Test 120 only copies src/lstat64 to $SCRATCH_MNT without verifying it is a
standalone binary. If xfstests is compiled with a version of libtools that
creates the wrapper as described above, then only the wrapper is copied to
$SCRATCH_MNT and the wrapper will fail to find $SCRATCH_MNT/.libs/lstat64.
~/xfstests # diff 120.out 120.out.bad
/mnt/scratch/lstat64: error: `/mnt/scratch/.libs/lstat64' does not exist
This script is just a wrapper for lstat64.
See the libtool documentation for more information.
This patch copies /bin/cat (which is readily availible on unix systems) to
$SCRATCH_MNT instead of src/lstat64.
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
Reviewed-by: Alex Elder <elder@inktank.com>
---
120 | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Index: b/120
===================================================================
--- a/120
+++ b/120
@@ -68,12 +68,12 @@ fi
#executable file
echo "*** copying file ***"
-cp src/lstat64 $SCRATCH_MNT
-src/lstat64 $SCRATCH_MNT/lstat64 >$tmp.out
+cp /bin/cat $SCRATCH_MNT
+src/lstat64 $SCRATCH_MNT/cat >$tmp.out
sleep 5
echo "*** executing file ***"
-$SCRATCH_MNT/lstat64 $SCRATCH_MNT/lstat64 >/dev/null
-_compare_access_times $SCRATCH_MNT/lstat64 "executing file"
+$SCRATCH_MNT/cat $SCRATCH_MNT/cat >/dev/null
+_compare_access_times $SCRATCH_MNT/cat "executing file"
#reading file
echo "*** creating file ***"
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-08-23 17:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120823174357.065135717@sgi.com>
2012-08-23 17:43 ` [PATCH V2] xfstests: Replace lstat64 with cat in test 120 rjohnston
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.