All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Kent Overstreet <koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH v6 00/13] Block cleanups
Date: Thu, 23 Aug 2012 14:00:41 -0400	[thread overview]
Message-ID: <20120823180041.GK12232@redhat.com> (raw)
In-Reply-To: <1345655050-28199-1-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>

On Wed, Aug 22, 2012 at 10:03:57AM -0700, Kent Overstreet wrote:

[..]
> Kent Overstreet (13):
>   block: Generalized bio pool freeing
>   dm: Use bioset's front_pad for dm_rq_clone_bio_info
>   block: Add bio_reset()
>   pktcdvd: Switch to bio_kmalloc()
>   block: Kill bi_destructor
>   block: Consolidate bio_alloc_bioset(), bio_kmalloc()

This patch series says "Block Cleanups" in the subject. I think that
it can be divided in two parts. First part seems to be cleanup where
we get rid of ->bi_destructor and merge kmalloc() and allocation 
from bio_set.

Second part seems to be more of enhancing bio splitting functionality
and not necessarily a cleanup. So may be breaking this series in two
parts makes sense. First part is cleanup and second part is enhanced
bio splitting capabilities of block layer.

Thanks
Vivek
 
>   block: Avoid deadlocks with bio allocation by stacking drivers
>   block: Add an explicit bio flag for bios that own their bvec
>   block: Rename bio_split() -> bio_pair_split()
>   block: Introduce new bio_split()
>   block: Rework bio_pair_split()
>   block: Add bio_clone_bioset(), bio_clone_kmalloc()
>   block: Only clone bio vecs that are in use
> 
>  Documentation/block/biodoc.txt      |   5 -
>  block/blk-core.c                    |  10 +-
>  drivers/block/drbd/drbd_main.c      |  13 +-
>  drivers/block/drbd/drbd_req.c       |  18 +-
>  drivers/block/osdblk.c              |   3 +-
>  drivers/block/pktcdvd.c             |  73 ++-----
>  drivers/block/rbd.c                 |   8 +-
>  drivers/md/dm-crypt.c               |   9 -
>  drivers/md/dm-io.c                  |  11 -
>  drivers/md/dm.c                     |  68 ++----
>  drivers/md/linear.c                 |   6 +-
>  drivers/md/md.c                     |  44 +---
>  drivers/md/raid0.c                  |   8 +-
>  drivers/md/raid10.c                 |  23 +-
>  drivers/target/target_core_iblock.c |   9 -
>  fs/bio-integrity.c                  |  45 ----
>  fs/bio.c                            | 419 +++++++++++++++++++++++-------------
>  fs/exofs/ore.c                      |   5 +-
>  include/linux/bio.h                 | 155 +++++++------
>  include/linux/blk_types.h           |  16 +-
>  20 files changed, 434 insertions(+), 514 deletions(-)
> 
> -- 
> 1.7.12

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Kent Overstreet <koverstreet@google.com>
Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
	dm-devel@redhat.com, tj@kernel.org, mpatocka@redhat.com,
	bharrosh@panasas.com
Subject: Re: [PATCH v6 00/13] Block cleanups
Date: Thu, 23 Aug 2012 14:00:41 -0400	[thread overview]
Message-ID: <20120823180041.GK12232@redhat.com> (raw)
In-Reply-To: <1345655050-28199-1-git-send-email-koverstreet@google.com>

On Wed, Aug 22, 2012 at 10:03:57AM -0700, Kent Overstreet wrote:

[..]
> Kent Overstreet (13):
>   block: Generalized bio pool freeing
>   dm: Use bioset's front_pad for dm_rq_clone_bio_info
>   block: Add bio_reset()
>   pktcdvd: Switch to bio_kmalloc()
>   block: Kill bi_destructor
>   block: Consolidate bio_alloc_bioset(), bio_kmalloc()

This patch series says "Block Cleanups" in the subject. I think that
it can be divided in two parts. First part seems to be cleanup where
we get rid of ->bi_destructor and merge kmalloc() and allocation 
from bio_set.

Second part seems to be more of enhancing bio splitting functionality
and not necessarily a cleanup. So may be breaking this series in two
parts makes sense. First part is cleanup and second part is enhanced
bio splitting capabilities of block layer.

Thanks
Vivek
 
>   block: Avoid deadlocks with bio allocation by stacking drivers
>   block: Add an explicit bio flag for bios that own their bvec
>   block: Rename bio_split() -> bio_pair_split()
>   block: Introduce new bio_split()
>   block: Rework bio_pair_split()
>   block: Add bio_clone_bioset(), bio_clone_kmalloc()
>   block: Only clone bio vecs that are in use
> 
>  Documentation/block/biodoc.txt      |   5 -
>  block/blk-core.c                    |  10 +-
>  drivers/block/drbd/drbd_main.c      |  13 +-
>  drivers/block/drbd/drbd_req.c       |  18 +-
>  drivers/block/osdblk.c              |   3 +-
>  drivers/block/pktcdvd.c             |  73 ++-----
>  drivers/block/rbd.c                 |   8 +-
>  drivers/md/dm-crypt.c               |   9 -
>  drivers/md/dm-io.c                  |  11 -
>  drivers/md/dm.c                     |  68 ++----
>  drivers/md/linear.c                 |   6 +-
>  drivers/md/md.c                     |  44 +---
>  drivers/md/raid0.c                  |   8 +-
>  drivers/md/raid10.c                 |  23 +-
>  drivers/target/target_core_iblock.c |   9 -
>  fs/bio-integrity.c                  |  45 ----
>  fs/bio.c                            | 419 +++++++++++++++++++++++-------------
>  fs/exofs/ore.c                      |   5 +-
>  include/linux/bio.h                 | 155 +++++++------
>  include/linux/blk_types.h           |  16 +-
>  20 files changed, 434 insertions(+), 514 deletions(-)
> 
> -- 
> 1.7.12

  parent reply	other threads:[~2012-08-23 18:00 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 17:03 [PATCH v6 00/13] Block cleanups Kent Overstreet
2012-08-22 17:03 ` Kent Overstreet
2012-08-22 17:03 ` [PATCH v6 01/13] block: Generalized bio pool freeing Kent Overstreet
2012-08-22 17:03   ` Kent Overstreet
     [not found]   ` <1345655050-28199-2-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 21:27     ` Nicholas A. Bellinger
2012-08-22 21:27       ` Nicholas A. Bellinger
2012-08-22 17:03 ` [PATCH v6 02/13] dm: Use bioset's front_pad for dm_rq_clone_bio_info Kent Overstreet
     [not found]   ` <1345655050-28199-3-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 18:32     ` Tejun Heo
2012-08-22 18:32       ` Tejun Heo
2012-08-22 21:30     ` Vivek Goyal
2012-08-22 21:30       ` Vivek Goyal
     [not found]       ` <20120822213010.GA8020-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-08-24  7:14         ` Kent Overstreet
2012-08-24  7:14           ` Kent Overstreet
     [not found]           ` <20120824071448.GF11977-jC9Py7bek1znysI04z7BkA@public.gmane.org>
2012-08-24 18:40             ` Vivek Goyal
2012-08-24 18:40               ` Vivek Goyal
2012-08-22 17:04 ` [PATCH v6 03/13] block: Add bio_reset() Kent Overstreet
     [not found]   ` <1345655050-28199-4-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 18:34     ` Tejun Heo
2012-08-22 18:34       ` Tejun Heo
2012-08-22 19:51       ` Tejun Heo
2012-08-22 17:04 ` [PATCH v6 04/13] pktcdvd: Switch to bio_kmalloc() Kent Overstreet
2012-08-22 17:04   ` Kent Overstreet
     [not found]   ` <1345655050-28199-5-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 19:55     ` Tejun Heo
2012-08-22 19:55       ` Tejun Heo
     [not found]       ` <20120822195546.GG19212-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-28 23:19         ` Jiri Kosina
2012-08-28 23:19           ` Jiri Kosina
2012-08-29  4:35           ` Peter Osterlund
2012-09-03 16:15         ` Jiri Kosina
2012-09-03 16:15           ` Jiri Kosina
2012-08-22 17:04 ` [PATCH v6 05/13] block: Kill bi_destructor Kent Overstreet
2012-08-22 17:04   ` Kent Overstreet
     [not found]   ` <1345655050-28199-6-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 20:00     ` Tejun Heo
2012-08-22 20:00       ` Tejun Heo
     [not found]       ` <20120822200032.GH19212-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-24  5:09         ` Kent Overstreet
2012-08-24  5:09           ` Kent Overstreet
2012-08-22 17:04 ` [PATCH v6 06/13] block: Consolidate bio_alloc_bioset(), bio_kmalloc() Kent Overstreet
2012-08-22 17:04   ` Kent Overstreet
     [not found]   ` <1345655050-28199-7-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 20:17     ` Tejun Heo
2012-08-22 20:17       ` Tejun Heo
     [not found]       ` <20120822201730.GI19212-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-24  5:04         ` Kent Overstreet
2012-08-24  5:04           ` Kent Overstreet
     [not found]           ` <20120824050400.GA11977-jC9Py7bek1znysI04z7BkA@public.gmane.org>
2012-08-24 20:08             ` Tejun Heo
2012-08-24 20:08               ` Tejun Heo
2012-08-22 17:04 ` [PATCH v6 07/13] block: Avoid deadlocks with bio allocation by stacking drivers Kent Overstreet
2012-08-22 20:30   ` Tejun Heo
2012-08-22 20:30     ` Tejun Heo
2012-08-24  5:55     ` Kent Overstreet
     [not found]       ` <20120824055554.GC11977-jC9Py7bek1znysI04z7BkA@public.gmane.org>
2012-08-24 20:28         ` Tejun Heo
2012-08-24 20:28           ` Tejun Heo
2012-08-22 17:04 ` [PATCH v6 11/13] block: Rework bio_pair_split() Kent Overstreet
     [not found]   ` <1345655050-28199-12-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 21:04     ` Tejun Heo
2012-08-22 21:04       ` Tejun Heo
     [not found]       ` <20120822210410.GL19212-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-24  2:25         ` Martin K. Petersen
2012-08-24  2:25           ` Martin K. Petersen
     [not found]           ` <yq1y5l5hvpw.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2012-08-24 10:37             ` Kent Overstreet
2012-08-24 10:37               ` Kent Overstreet
2012-08-24 20:58             ` Tejun Heo
2012-08-24 20:58               ` Tejun Heo
2012-08-24 10:30       ` Kent Overstreet
2012-08-24 20:53         ` Tejun Heo
2012-08-22 17:04 ` [PATCH v6 13/13] block: Only clone bio vecs that are in use Kent Overstreet
     [not found]   ` <1345655050-28199-14-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 21:10     ` Tejun Heo
2012-08-22 21:10       ` Tejun Heo
     [not found]       ` <20120822211045.GN19212-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-24  7:05         ` Kent Overstreet
2012-08-24  7:05           ` Kent Overstreet
     [not found]           ` <20120824070508.GE11977-jC9Py7bek1znysI04z7BkA@public.gmane.org>
2012-08-24 20:42             ` Tejun Heo
2012-08-24 20:42               ` Tejun Heo
     [not found] ` <1345655050-28199-1-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 17:04   ` [PATCH v6 08/13] block: Add an explicit bio flag for bios that own their bvec Kent Overstreet
2012-08-22 17:04     ` Kent Overstreet
     [not found]     ` <1345655050-28199-9-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 17:43       ` Adrian Bunk
2012-08-22 17:43         ` Adrian Bunk
     [not found]         ` <20120822174351.GA27453-c9qLp6CXzmZPEsXTsnYjsA@public.gmane.org>
2012-08-22 19:22           ` Kent Overstreet
2012-08-22 19:22             ` Kent Overstreet
2012-08-22 20:00             ` Adrian Bunk
2012-08-22 20:00               ` Adrian Bunk
     [not found]               ` <20120822200038.GB27453-c9qLp6CXzmZPEsXTsnYjsA@public.gmane.org>
2012-08-28 17:23                 ` Kent Overstreet
2012-08-28 17:23                   ` Kent Overstreet
2012-08-22 17:04   ` [PATCH v6 09/13] block: Rename bio_split() -> bio_pair_split() Kent Overstreet
2012-08-22 17:04     ` Kent Overstreet
2012-08-22 17:04   ` [PATCH v6 10/13] block: Introduce new bio_split() Kent Overstreet
2012-08-22 17:04     ` Kent Overstreet
     [not found]     ` <1345655050-28199-11-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 20:46       ` Tejun Heo
2012-08-22 20:46         ` Tejun Heo
2012-08-22 17:04   ` [PATCH v6 12/13] block: Add bio_clone_bioset(), bio_clone_kmalloc() Kent Overstreet
2012-08-22 17:04     ` Kent Overstreet
     [not found]     ` <1345655050-28199-13-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-22 17:13       ` Jeff Garzik
2012-08-22 17:13         ` Jeff Garzik
2012-08-22 21:07       ` Tejun Heo
2012-08-22 21:07         ` Tejun Heo
     [not found]         ` <20120822210740.GM19212-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-24  6:24           ` Kent Overstreet
2012-08-24  6:24             ` Kent Overstreet
     [not found]             ` <20120824062418.GD11977-jC9Py7bek1znysI04z7BkA@public.gmane.org>
2012-08-24 20:36               ` Tejun Heo
2012-08-24 20:36                 ` Tejun Heo
2012-08-23 18:00   ` Vivek Goyal [this message]
2012-08-23 18:00     ` [PATCH v6 00/13] Block cleanups Vivek Goyal
     [not found]     ` <20120823180041.GK12232-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-08-24 12:46       ` Kent Overstreet
2012-08-24 12:46         ` Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120823180041.GK12232@redhat.com \
    --to=vgoyal-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org \
    --cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.