From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
peterz@infradead.org, lkml <linux-kernel@vger.kernel.org>,
oleg@redhat.com, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>, Ingo Molnar <mingo@elte.hu>,
ppcdev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v4 2/2] powerpc: Uprobes port to powerpc
Date: Fri, 24 Aug 2012 13:07:38 +0530 [thread overview]
Message-ID: <20120824073738.GD32031@in.ibm.com> (raw)
In-Reply-To: <1345792051.29170.25.camel@pasglop>
On Fri, Aug 24, 2012 at 05:07:31PM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2012-08-24 at 11:13 +1000, Michael Ellerman wrote:
> >
> > Yeah. A NULL regs here is a kernel bug, so I think it's actually
> > preferable to crash than silently return.
>
> Or best, if you think there's a remote chance that the bug might hit:
>
> if (WARN(!regs))
> return
Incorporated this and other suggestions from Michael in v5 I just
posted.
Ananth
WARNING: multiple messages have this Message-ID (diff)
From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Ellerman <michael@ellerman.id.au>,
ppcdev <linuxppc-dev@lists.ozlabs.org>,
lkml <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
peterz@infradead.org, oleg@redhat.com,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v4 2/2] powerpc: Uprobes port to powerpc
Date: Fri, 24 Aug 2012 13:07:38 +0530 [thread overview]
Message-ID: <20120824073738.GD32031@in.ibm.com> (raw)
In-Reply-To: <1345792051.29170.25.camel@pasglop>
On Fri, Aug 24, 2012 at 05:07:31PM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2012-08-24 at 11:13 +1000, Michael Ellerman wrote:
> >
> > Yeah. A NULL regs here is a kernel bug, so I think it's actually
> > preferable to crash than silently return.
>
> Or best, if you think there's a remote chance that the bug might hit:
>
> if (WARN(!regs))
> return
Incorporated this and other suggestions from Michael in v5 I just
posted.
Ananth
next prev parent reply other threads:[~2012-08-24 7:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 8:22 [PATCH 1/2] powerpc: Add trap_nr to thread_struct Ananth N Mavinakayanahalli
2012-08-22 8:22 ` Ananth N Mavinakayanahalli
2012-08-22 8:27 ` [PATCH v4 2/2] powerpc: Uprobes port to powerpc Ananth N Mavinakayanahalli
2012-08-22 8:27 ` Ananth N Mavinakayanahalli
2012-08-22 15:55 ` Oleg Nesterov
2012-08-22 15:55 ` Oleg Nesterov
2012-08-23 4:28 ` Michael Ellerman
2012-08-23 4:28 ` Michael Ellerman
2012-08-23 5:32 ` Srikar Dronamraju
2012-08-23 5:32 ` Srikar Dronamraju
2012-08-23 10:06 ` Benjamin Herrenschmidt
2012-08-23 10:06 ` Benjamin Herrenschmidt
2012-08-23 9:02 ` Oleg Nesterov
2012-08-23 9:02 ` Oleg Nesterov
2012-08-23 16:02 ` Srikar Dronamraju
2012-08-23 16:02 ` Srikar Dronamraju
2012-08-23 16:17 ` Srikar Dronamraju
2012-08-23 16:17 ` Srikar Dronamraju
2012-08-23 21:57 ` Benjamin Herrenschmidt
2012-08-23 21:57 ` Benjamin Herrenschmidt
2012-08-24 1:33 ` Michael Ellerman
2012-08-24 1:33 ` Michael Ellerman
2012-08-23 5:58 ` Ananth N Mavinakayanahalli
2012-08-23 5:58 ` Ananth N Mavinakayanahalli
2012-08-24 1:13 ` Michael Ellerman
2012-08-24 1:13 ` Michael Ellerman
2012-08-24 7:07 ` Benjamin Herrenschmidt
2012-08-24 7:07 ` Benjamin Herrenschmidt
2012-08-24 7:37 ` Ananth N Mavinakayanahalli [this message]
2012-08-24 7:37 ` Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120824073738.GD32031@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.