From: Aurelien Jarno <aurelien@aurel32.net>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering
Date: Fri, 24 Aug 2012 12:08:58 +0200 [thread overview]
Message-ID: <20120824100858.GF1687@hall.aurel32.net> (raw)
In-Reply-To: <CAJSP0QXoqaosPHoL1F8JNAvX2u0dOAjREu+S=mZmGkK1TDGBpw@mail.gmail.com>
On Fri, Aug 24, 2012 at 10:47:47AM +0100, Stefan Hajnoczi wrote:
> On Thu, Aug 23, 2012 at 4:39 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > The lan9118 emulation tries to compute the multicast index by calling
> > directly the crc32() function from zlib, but fails to get the correct
> > result.
> >
> > Use the common compute_mcast_idx() function instead, which gives the
> > correct result. This fixes IPv6 support.
> >
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> > hw/lan9118.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> There is another crc32() call in hw/lan9118.c:lan9118_receive(). Can
> that be replaced too and then #include <zlib.h> can be dropped?
>
I don't think so, at least not easily. This is a different call (the
length is variable), and most emulated NICs have a call to crc32(), but
in slightly different ways.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2012-08-24 10:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 15:39 [Qemu-devel] [PATCH ] lan9118: fix multicast filtering Aurelien Jarno
2012-08-24 9:47 ` Stefan Hajnoczi
2012-08-24 10:08 ` Aurelien Jarno [this message]
2012-08-24 10:13 ` Stefan Hajnoczi
2012-09-07 14:56 ` Aurelien Jarno
2012-09-07 15:04 ` Peter Maydell
2012-09-07 15:36 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120824100858.GF1687@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.