From: Richard Cochran <richardcochran@gmail.com>
To: "Vick, Matthew" <matthew.vick@intel.com>
Cc: "Keller, Jacob E" <jacob.e.keller@intel.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>
Subject: Re: [net-next 10/13] igb: Tidy up wrapping for CONFIG_IGB_PTP.
Date: Fri, 24 Aug 2012 12:10:53 +0200 [thread overview]
Message-ID: <20120824101053.GA6038@netboy.at.omicron.at> (raw)
In-Reply-To: <06DFBC1E25D8024DB214DC7F41A3CD34488DD35B@ORSMSX101.amr.corp.intel.com>
On Thu, Aug 23, 2012 at 06:40:25PM +0000, Vick, Matthew wrote:
>
> I tend to agree with Jake here--I like having the information. I'm fine removing them, but I'd like to do it for all CONFIG_IGB_PTP wrapping if we're going to do it. What do you think, Richard?
Come to think of it, I never liked the CONFIG_IGB_PTP very much in the
first place. These were added after the fact by Jeff Kirsher. He had
said off list that there was some issue with CONFIG_PTP_1588_CLOCK and
igb as a module, or something like that. At that time I said, just go
ahead and fix it up.
I think it would be better if the "time stamp all Rx packets" of the
82580 were always available, and that the PHC feature always be
compiled when CONFIG_PTP_1588_CLOCK is selected.
Maybe you could ask Jeff what the issue was, and then see if there is
a way to remove CONFIG_IGB_PTP altogether.
Thanks,
Richard
next prev parent reply other threads:[~2012-08-24 10:11 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 9:56 [net-next 00/13][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-08-23 9:56 ` [net-next 01/13] e1000e: use correct type for read of 32-bit register Jeff Kirsher
2012-08-23 9:56 ` [net-next 02/13] e1000e: cleanup strict checkpatch check Jeff Kirsher
2012-08-23 9:56 ` [net-next 03/13] e1000e: cleanup - remove inapplicable comment Jeff Kirsher
2012-08-23 9:56 ` [net-next 04/13] e1000e: cleanup checkpatch PREFER_PR_LEVEL warning Jeff Kirsher
2012-08-23 14:01 ` Joe Perches
2012-08-24 18:02 ` Joe Perches
2012-08-24 21:19 ` Jeff Kirsher
2012-08-24 22:43 ` Joe Perches
2012-08-23 9:56 ` [net-next 05/13] e1000e: cleanup - remove unnecessary variable Jeff Kirsher
2012-08-23 9:56 ` [net-next 06/13] e1000e: update driver version number Jeff Kirsher
2012-08-23 9:56 ` [net-next 07/13] e1000e: cleanup strict checkpatch MEMORY_BARRIER checks Jeff Kirsher
2012-08-23 9:56 ` [net-next 08/13] igb: Add loopback test support for i210 Jeff Kirsher
2012-08-23 9:56 ` [net-next 09/13] igb: reduce Rx header size Jeff Kirsher
2012-08-23 9:56 ` [net-next 10/13] igb: Tidy up wrapping for CONFIG_IGB_PTP Jeff Kirsher
2012-08-23 11:03 ` Richard Cochran
2012-08-23 16:09 ` Vick, Matthew
2012-08-23 17:29 ` Richard Cochran
2012-08-23 17:40 ` Vick, Matthew
2012-08-23 18:03 ` Richard Cochran
2012-08-23 18:03 ` Keller, Jacob E
2012-08-23 18:40 ` Vick, Matthew
2012-08-24 7:04 ` Richard Cochran
2012-08-24 10:10 ` Richard Cochran [this message]
2012-08-24 16:51 ` Ben Hutchings
2012-08-24 19:38 ` Keller, Jacob E
2012-08-25 6:20 ` Richard Cochran
2012-08-26 1:33 ` Keller, Jacob E
2012-08-26 13:01 ` Richard Cochran
2012-08-23 11:28 ` Richard Cochran
2012-08-23 16:27 ` Vick, Matthew
2012-08-23 9:56 ` [net-next 11/13] igb: Update PTP function names/variables and locations Jeff Kirsher
2012-08-23 11:16 ` Richard Cochran
2012-08-23 16:22 ` Vick, Matthew
2012-08-23 17:53 ` Richard Cochran
2012-08-23 18:00 ` Keller, Jacob E
2012-08-23 18:11 ` Richard Cochran
2012-08-23 18:44 ` Vick, Matthew
2012-08-24 6:55 ` Richard Cochran
2012-08-24 15:52 ` Vick, Matthew
2012-08-25 5:48 ` Richard Cochran
2012-08-27 15:23 ` Vick, Matthew
2012-08-27 16:44 ` Richard Cochran
2012-08-27 17:39 ` Vick, Matthew
2012-08-23 18:35 ` Vick, Matthew
2012-08-23 18:48 ` Keller, Jacob E
2012-08-23 18:58 ` Vick, Matthew
2012-08-24 3:02 ` Joe Perches
2012-08-24 6:32 ` Richard Cochran
2012-08-24 9:22 ` Joe Perches
2012-08-24 15:12 ` David Miller
2012-08-24 17:56 ` Joe Perches
2012-08-23 9:56 ` [net-next 12/13] igb: Correct PTP support query from ethtool Jeff Kirsher
2012-08-23 11:24 ` Richard Cochran
2012-08-23 16:38 ` Vick, Matthew
2012-08-23 9:56 ` [net-next 13/13] igb: Store the MAC address in the name in the PTP struct Jeff Kirsher
2012-08-23 10:45 ` Richard Cochran
2012-08-23 16:05 ` Vick, Matthew
2012-08-23 21:35 ` Ben Hutchings
2012-08-24 6:19 ` Richard Cochran
2012-09-06 23:04 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120824101053.GA6038@netboy.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=matthew.vick@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.