From: Aristeu Rozanski <aris-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Hillf Danton <dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Lennart Poettering
<lpoetter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v7 1/4] xattr: extract simple_xattr code from tmpfs
Date: Fri, 24 Aug 2012 09:14:35 -0400 [thread overview]
Message-ID: <20120824131435.GC18688@redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1208231609240.5904-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
On Thu, Aug 23, 2012 at 04:14:24PM -0700, Hugh Dickins wrote:
> I'm also happy to see that you're now using simple_xattr_alloc() in
> __simple_xattr_set() (but no need to respin to comment on that here).
>
> It looks very nice: much better for this code to live in fs/xattr.c
> than in mm/shmem.c.
Thanks for the review and feedback!
--
Aristeu
WARNING: multiple messages have this Message-ID (diff)
From: Aristeu Rozanski <aris@redhat.com>
To: Hugh Dickins <hughd@google.com>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Li Zefan <lizefan@huawei.com>, Tejun Heo <tj@kernel.org>,
Hillf Danton <dhillf@gmail.com>,
Lennart Poettering <lpoetter@redhat.com>
Subject: Re: [PATCH v7 1/4] xattr: extract simple_xattr code from tmpfs
Date: Fri, 24 Aug 2012 09:14:35 -0400 [thread overview]
Message-ID: <20120824131435.GC18688@redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1208231609240.5904@eggly.anvils>
On Thu, Aug 23, 2012 at 04:14:24PM -0700, Hugh Dickins wrote:
> I'm also happy to see that you're now using simple_xattr_alloc() in
> __simple_xattr_set() (but no need to respin to comment on that here).
>
> It looks very nice: much better for this code to live in fs/xattr.c
> than in mm/shmem.c.
Thanks for the review and feedback!
--
Aristeu
next prev parent reply other threads:[~2012-08-24 13:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 20:53 [PATCH v7 0/4] cgroup: add xattr support aris-H+wXaHxf7aLQT0dZR+AlfA
2012-08-23 20:53 ` aris
2012-08-23 20:53 ` [PATCH v7 1/4] xattr: extract simple_xattr code from tmpfs aris
[not found] ` <20120823205327.613311683-cd6kKtb6gxi3M6m420IelR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2012-08-23 23:14 ` Hugh Dickins
2012-08-23 23:14 ` Hugh Dickins
[not found] ` <alpine.LSU.2.00.1208231609240.5904-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2012-08-24 13:14 ` Aristeu Rozanski [this message]
2012-08-24 13:14 ` Aristeu Rozanski
2012-08-23 20:53 ` [PATCH v7 2/4] cgroup: revise how we re-populate root directory aris
2012-08-23 20:53 ` [PATCH v7 3/4] cgroup: add xattr support aris-H+wXaHxf7aLQT0dZR+AlfA
2012-08-23 20:53 ` aris
2012-08-23 20:53 ` [PATCH v7 4/4] cgroup: rename subsys_bits to subsys_mask aris-H+wXaHxf7aLQT0dZR+AlfA
2012-08-23 20:53 ` aris
[not found] ` <20120823205327.237533518-cd6kKtb6gxi3M6m420IelR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2012-08-24 22:58 ` [PATCH v7 0/4] cgroup: add xattr support Tejun Heo
2012-08-24 22:58 ` Tejun Heo
[not found] ` <20120824225839.GM21325-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-27 13:05 ` Aristeu Rozanski
2012-08-27 13:05 ` Aristeu Rozanski
[not found] ` <20120827130525.GI18688-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-08-28 16:15 ` Tejun Heo
2012-08-28 16:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120824131435.GC18688@redhat.com \
--to=aris-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=lpoetter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.