From: Tejun Heo <tj@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
paul.gortmaker@windriver.com, davem@davemloft.net,
rostedt@goodmis.org, mingo@elte.hu, ebiederm@xmission.com,
aarcange@redhat.com, ericvh@gmail.com, netdev@vger.kernel.org,
josh@joshtriplett.org, eric.dumazet@gmail.com,
mathieu.desnoyers@efficios.com, axboe@kernel.dk, agk@redhat.com,
dm-devel@redhat.com, neilb@suse.de, ccaulfie@redhat.com,
teigland@redhat.com, Trond.Myklebust@netapp.com,
bfields@fieldses.org, fweisbec@gmail.com, jesse@nicira.com,
venkat.x.venkatsubra@oracle.com, ejt@redhat.com,
snitzer@redhat.com, edumazet@google.com,
linux-nfs@vger.kernel.org, dev@openvswitch.org,
rds-devel@oss.oracle.com, lw@cn.fujitsu.com
Subject: Re: [PATCH v3 01/17] hashtable: introduce a small and naive hashtable
Date: Fri, 24 Aug 2012 16:07:40 -0700 [thread overview]
Message-ID: <20120824230740.GN21325@google.com> (raw)
In-Reply-To: <5038074D.300@gmail.com>
Hello,
On Sat, Aug 25, 2012 at 12:59:25AM +0200, Sasha Levin wrote:
> Thats the thing, the amount of things of things you can do with a given bucket
> is very limited. You can't add entries to any point besides the head (without
> walking the entire list).
Kinda my point. We already have all the hlist*() interface to deal
with such cases. Having something which is evidently the trivial
hlist hashtable and advertises as such in the interface can be
helpful. I think we need that more than we need anything fancy.
Heh, this is a debate about which one is less insignificant. I can
see your point. I'd really like to hear what others think on this.
Guys, do we want something which is evidently trivial hlist hashtable
which can use hlist_*() API directly or do we want something better
encapsulated?
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
paul.gortmaker@windriver.com, davem@davemloft.net,
rostedt@goodmis.org, mingo@elte.hu, ebiederm@xmission.com,
aarcange@redhat.com, ericvh@gmail.com, netdev@vger.kernel.org,
josh@joshtriplett.org, eric.dumazet@gmail.com,
mathieu.desnoyers@efficios.com, axboe@kernel.dk, agk@redhat.com,
dm-devel@redhat.com, neilb@suse.de, ccaulfie@redhat.com,
teigland@redhat.com, Trond.Myklebust@netapp.com,
bfields@fieldses.org, fweisbec@gmail.com, jesse@nicira.com,
venkat.x.venkatsubra@oracle.com, ejt@redhat.com,
snitzer@redhat.com, edumazet@google.com,
linux-nfs@vger.kernel.org, dev@openvswitch.org,
rds-devel@oss.oracle.com, lw@cn.fujitsu.com
Subject: Re: [PATCH v3 01/17] hashtable: introduce a small and naive hashtable
Date: Fri, 24 Aug 2012 16:07:40 -0700 [thread overview]
Message-ID: <20120824230740.GN21325@google.com> (raw)
In-Reply-To: <5038074D.300@gmail.com>
Hello,
On Sat, Aug 25, 2012 at 12:59:25AM +0200, Sasha Levin wrote:
> Thats the thing, the amount of things of things you can do with a given bucket
> is very limited. You can't add entries to any point besides the head (without
> walking the entire list).
Kinda my point. We already have all the hlist*() interface to deal
with such cases. Having something which is evidently the trivial
hlist hashtable and advertises as such in the interface can be
helpful. I think we need that more than we need anything fancy.
Heh, this is a debate about which one is less insignificant. I can
see your point. I'd really like to hear what others think on this.
Guys, do we want something which is evidently trivial hlist hashtable
which can use hlist_*() API directly or do we want something better
encapsulated?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-08-24 23:07 UTC|newest]
Thread overview: 182+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 2:26 [PATCH v3 00/17] generic hashtable implementation Sasha Levin
2012-08-22 2:26 ` Sasha Levin
2012-08-22 2:26 ` [PATCH v3 02/17] userns: use new " Sasha Levin
2012-08-22 2:26 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 06/17] tracepoint: " Sasha Levin
2012-08-22 2:27 ` Sasha Levin
[not found] ` <1345602432-27673-1-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-22 2:26 ` [PATCH v3 01/17] hashtable: introduce a small and naive hashtable Sasha Levin
2012-08-22 2:26 ` Sasha Levin
2012-08-22 2:26 ` Sasha Levin
[not found] ` <1345602432-27673-2-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-22 18:01 ` Tejun Heo
2012-08-22 18:01 ` Tejun Heo
2012-08-22 18:01 ` Tejun Heo
2012-08-22 23:54 ` Ryan Mallon
2012-08-22 23:54 ` Ryan Mallon
2012-08-23 0:24 ` Sasha Levin
2012-08-23 0:24 ` Sasha Levin
2012-08-23 20:04 ` Tejun Heo
2012-08-23 20:04 ` Tejun Heo
2012-08-24 19:47 ` Sasha Levin
2012-08-24 19:47 ` Sasha Levin
[not found] ` <5037DA47.9010306-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-24 19:59 ` Tejun Heo
2012-08-24 19:59 ` Tejun Heo
2012-08-24 19:59 ` Tejun Heo
[not found] ` <20120824195941.GC21325-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-24 20:11 ` Sasha Levin
2012-08-24 20:11 ` Sasha Levin
2012-08-24 20:11 ` Sasha Levin
[not found] ` <5037E00B.6090606-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-24 20:33 ` Tejun Heo
2012-08-24 20:33 ` Tejun Heo
2012-08-24 20:33 ` Tejun Heo
[not found] ` <20120824203332.GF21325-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-24 20:53 ` Sasha Levin
2012-08-24 20:53 ` Sasha Levin
2012-08-24 20:53 ` Sasha Levin
2012-08-24 21:23 ` Tejun Heo
2012-08-24 21:23 ` Tejun Heo
[not found] ` <20120824212348.GK21325-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-24 22:59 ` Sasha Levin
2012-08-24 22:59 ` Sasha Levin
2012-08-24 22:59 ` Sasha Levin
2012-08-24 23:07 ` Tejun Heo [this message]
2012-08-24 23:07 ` Tejun Heo
2012-08-25 4:24 ` Mathieu Desnoyers
2012-08-25 4:24 ` Mathieu Desnoyers
2012-08-28 9:56 ` Sasha Levin
2012-08-28 9:56 ` Sasha Levin
2012-08-28 9:56 ` Sasha Levin
2012-08-28 10:11 ` Mathieu Desnoyers
2012-08-28 10:11 ` Mathieu Desnoyers
2012-08-28 11:27 ` Sasha Levin
2012-08-28 11:27 ` Sasha Levin
2012-08-28 11:27 ` Sasha Levin
[not found] ` <503CAB1E.5010408-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-28 11:56 ` Mathieu Desnoyers
2012-08-28 11:56 ` Mathieu Desnoyers
2012-08-28 11:56 ` Mathieu Desnoyers
2012-08-28 23:00 ` Mathieu Desnoyers
2012-08-28 23:00 ` Mathieu Desnoyers
2012-08-28 23:00 ` Mathieu Desnoyers
2012-09-04 15:35 ` Steven Rostedt
2012-09-04 15:35 ` Steven Rostedt
2012-09-04 15:35 ` Steven Rostedt
[not found] ` <1346772948.27919.9.camel-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2012-09-04 16:30 ` Pedro Alves
2012-09-04 16:30 ` Pedro Alves
2012-09-04 16:30 ` Pedro Alves
2012-09-04 16:40 ` Pedro Alves
2012-09-04 16:40 ` Pedro Alves
2012-09-04 16:40 ` Pedro Alves
2012-09-04 16:40 ` Pedro Alves
[not found] ` <50462EE8.1090903-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-04 17:01 ` Mathieu Desnoyers
2012-09-04 17:01 ` Mathieu Desnoyers
2012-09-04 17:01 ` Mathieu Desnoyers
2012-09-06 13:53 ` Sasha Levin
2012-09-06 13:53 ` Sasha Levin
2012-09-06 14:19 ` Pedro Alves
2012-09-06 14:19 ` Pedro Alves
2012-09-06 14:19 ` Pedro Alves
[not found] ` <5048AAF6.5090101-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-06 14:33 ` Mathieu Desnoyers
2012-09-06 14:33 ` Mathieu Desnoyers
2012-09-06 14:33 ` Mathieu Desnoyers
2012-09-06 14:36 ` David Laight
2012-09-06 14:36 ` David Laight
2012-09-06 14:36 ` David Laight
2012-09-06 14:55 ` Josh Triplett
2012-09-06 14:55 ` Josh Triplett
2012-09-06 15:11 ` Steven Rostedt
2012-09-06 15:11 ` Steven Rostedt
2012-09-06 15:11 ` Steven Rostedt
2012-09-06 15:49 ` Sasha Levin
2012-09-06 15:49 ` Sasha Levin
2012-09-06 15:49 ` Sasha Levin
[not found] ` <5048C615.4070204-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-06 16:00 ` Steven Rostedt
2012-09-06 16:00 ` Steven Rostedt
2012-09-06 16:00 ` Steven Rostedt
[not found] ` <1346947206.1680.36.camel-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2012-09-06 16:21 ` Sasha Levin
2012-09-06 16:21 ` Sasha Levin
2012-09-06 16:21 ` Sasha Levin
[not found] ` <5048CDA2.10300-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-06 16:50 ` Mathieu Desnoyers
2012-09-06 16:50 ` Mathieu Desnoyers
2012-09-06 16:50 ` Mathieu Desnoyers
2012-09-06 17:01 ` Sasha Levin
2012-09-06 17:01 ` Sasha Levin
2012-09-06 17:01 ` Sasha Levin
[not found] ` <5048D6DE.8090805-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-06 17:02 ` Mathieu Desnoyers
2012-09-06 17:02 ` Mathieu Desnoyers
2012-09-06 17:02 ` Mathieu Desnoyers
2012-09-06 17:15 ` Steven Rostedt
2012-09-06 17:15 ` Steven Rostedt
2012-09-04 17:17 ` Steven Rostedt
2012-09-04 17:17 ` Steven Rostedt
2012-09-04 17:17 ` Steven Rostedt
2012-09-04 17:21 ` Pedro Alves
2012-09-04 17:21 ` Pedro Alves
2012-09-04 17:21 ` Pedro Alves
[not found] ` <50463883.8080706-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-04 20:59 ` Steven Rostedt
2012-09-04 20:59 ` Steven Rostedt
2012-09-04 20:59 ` Steven Rostedt
2012-09-04 21:51 ` Pedro Alves
2012-09-04 21:51 ` Pedro Alves
2012-09-04 21:51 ` Pedro Alves
[not found] ` <504677C8.3050801-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-04 22:41 ` Steven Rostedt
2012-09-04 22:41 ` Steven Rostedt
2012-09-04 22:41 ` Steven Rostedt
2012-09-04 22:58 ` Pedro Alves
2012-09-04 22:58 ` Pedro Alves
2012-09-04 22:58 ` Pedro Alves
[not found] ` <50468778.5000207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-04 23:27 ` Steven Rostedt
2012-09-04 23:27 ` Steven Rostedt
2012-09-04 23:27 ` Steven Rostedt
2012-09-04 16:32 ` Mathieu Desnoyers
2012-09-04 16:32 ` Mathieu Desnoyers
2012-09-04 16:32 ` Mathieu Desnoyers
2012-08-22 2:26 ` [PATCH v3 03/17] mm, ksm: use new hashtable implementation Sasha Levin
2012-08-22 2:26 ` [PATCH v3 03/17] mm,ksm: " Sasha Levin
2012-08-22 2:26 ` Sasha Levin
2012-08-22 2:26 ` [PATCH v3 04/17] workqueue: " Sasha Levin
2012-08-22 2:26 ` Sasha Levin
2012-08-22 2:26 ` Sasha Levin
[not found] ` <1345602432-27673-5-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-22 18:05 ` Tejun Heo
2012-08-22 18:05 ` Tejun Heo
2012-08-22 18:05 ` Tejun Heo
2012-08-22 2:27 ` [PATCH v3 05/17] mm/huge_memory: " Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 07/17] net, 9p: " Sasha Levin
2012-08-22 2:27 ` [PATCH v3 07/17] net,9p: " Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 08/17] block, elevator: " Sasha Levin
2012-08-22 2:27 ` [PATCH v3 08/17] block,elevator: " Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 09/17] SUNRPC/cache: " Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 10/17] dlm: " Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 13/17] lockd: " Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 11:47 ` J. Bruce Fields
2012-08-22 11:47 ` J. Bruce Fields
[not found] ` <20120822114752.GC20158-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-08-22 12:13 ` Sasha Levin
2012-08-22 12:13 ` Sasha Levin
2012-08-22 12:13 ` Sasha Levin
2012-08-22 13:12 ` J. Bruce Fields
2012-08-22 13:12 ` J. Bruce Fields
[not found] ` <5034CD02.2010103-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-22 13:22 ` Mathieu Desnoyers
2012-08-22 13:22 ` Mathieu Desnoyers
2012-08-22 13:22 ` Mathieu Desnoyers
2012-08-22 17:32 ` Sasha Levin
2012-08-22 17:32 ` Sasha Levin
2012-08-22 17:32 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 16/17] tracing output: " Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 17/17] SUNRPC: use new hashtable implementation in auth Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 11/17] net,l2tp: use new hashtable implementation Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 12/17] dm: " Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 14/17] net,rds: " Sasha Levin
2012-08-22 2:27 ` Sasha Levin
2012-08-22 2:27 ` [PATCH v3 15/17] openvswitch: " Sasha Levin
2012-08-22 2:27 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120824230740.GN21325@google.com \
--to=tj@kernel.org \
--cc=Trond.Myklebust@netapp.com \
--cc=aarcange@redhat.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bfields@fieldses.org \
--cc=ccaulfie@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dm-devel@redhat.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=ejt@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=ericvh@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jesse@nicira.com \
--cc=josh@joshtriplett.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lw@cn.fujitsu.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rds-devel@oss.oracle.com \
--cc=rostedt@goodmis.org \
--cc=snitzer@redhat.com \
--cc=teigland@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=venkat.x.venkatsubra@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.