All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Anton Altaparmakov <anton@tuxera.com>
Cc: kernel-janitors@vger.kernel.org,
	linux-ntfs-dev@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: fs/ntfs/super.c:2717:1-14: alloc with no test
Date: Sun, 26 Aug 2012 09:04:47 +0000	[thread overview]
Message-ID: <20120826090447.GA11098@localhost> (raw)


Hi Anton,

FYI, coccinelle warns about

fs/ntfs/super.c:2717:1-14: alloc with no test, possible model on line 2718

vim +2717 fs/ntfs/super.c
  2714		sb->s_flags |= MS_RDONLY;
  2715	#endif /* ! NTFS_RW */
  2716		/* Allocate a new ntfs_volume and place it in sb->s_fs_info. */
> 2717		sb->s_fs_info = kmalloc(sizeof(ntfs_volume), GFP_NOFS);
  2718		vol = NTFS_SB(sb);
  2719		if (!vol) {
  2720			if (!silent)

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Anton Altaparmakov <anton@tuxera.com>
Cc: kernel-janitors@vger.kernel.org,
	linux-ntfs-dev@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: fs/ntfs/super.c:2717:1-14: alloc with no test
Date: Sun, 26 Aug 2012 17:04:47 +0800	[thread overview]
Message-ID: <20120826090447.GA11098@localhost> (raw)


Hi Anton,

FYI, coccinelle warns about

fs/ntfs/super.c:2717:1-14: alloc with no test, possible model on line 2718

vim +2717 fs/ntfs/super.c
  2714		sb->s_flags |= MS_RDONLY;
  2715	#endif /* ! NTFS_RW */
  2716		/* Allocate a new ntfs_volume and place it in sb->s_fs_info. */
> 2717		sb->s_fs_info = kmalloc(sizeof(ntfs_volume), GFP_NOFS);
  2718		vol = NTFS_SB(sb);
  2719		if (!vol) {
  2720			if (!silent)

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

             reply	other threads:[~2012-08-26  9:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-26  9:04 Fengguang Wu [this message]
2012-08-26  9:04 ` fs/ntfs/super.c:2717:1-14: alloc with no test Fengguang Wu
2012-08-26  9:12 ` devendra.aaru
2012-08-26  9:24   ` devendra.aaru
2012-08-26  9:31   ` Fengguang Wu
2012-08-26  9:31     ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120826090447.GA11098@localhost \
    --to=fengguang.wu@intel.com \
    --cc=anton@tuxera.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.